all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: kiasoc5 via Guix-patches via <guix-patches@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 57927@debbugs.gnu.org
Subject: [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps.
Date: Wed, 28 Sep 2022 04:34:07 +0000	[thread overview]
Message-ID: <20220928043407.181d9060@aria> (raw)
In-Reply-To: <87bkr1ey8x.fsf@nckx>

Hi Tobias,

On Tue, Sep 27 2022, 03:22:19 PM +0200
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> Hi kiasoc5,
> 
> kiasoc5 via Guix-patches via 写道:
> > This fixes src-hilite-lesspipe.sh so that lesspipe.sh is called 
> > instead of lesspipe.
> 
> When you notice a rebuild count higher than the thresholds given 
> here[0], please add a ‘[PATCH core-updates]’ or ‘[PATCH staging]’ 
> warning to your patch subject.  It reduces the chance of these 
> slipping through.

I didn't realize source-highlight was used by so many projects, I'll be
more careful next time.

Just so I understand the rebuilds are occuring because the store path
of source-highlight changed, and the result could not be grafted?

> > * gnu/packages/pretty-print.scm (source-highlight):
> > [arguments]: Use gexps, remove trailing #ts.
> > [phases]: Add phase to make src-highlight-lesspipe.sh work.
> 
> These unrelated changes should be separated into at least two 
> patches next time: one to gexp and remove the #ts, the other to 
> make the functional change.
> < to go 
> straight to master.

1. Does trailing #t change the hash?
2. Why might Gexpification change the hash?




  reply	other threads:[~2022-09-28  4:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19  6:57 [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps kiasoc5 via Guix-patches via
2022-09-27  9:11 ` bug#57927: " Mathieu Othacehe
2022-09-27 13:22 ` [bug#57927] " Tobias Geerinckx-Rice via Guix-patches via
2022-09-28  4:34   ` kiasoc5 via Guix-patches via [this message]
2022-09-28 21:14     ` Maxime Devos
2022-09-28 21:16     ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928043407.181d9060@aria \
    --to=guix-patches@gnu.org \
    --cc=57927@debbugs.gnu.org \
    --cc=kiasoc5@disroot.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.