From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0IlbCfS9I2Mc9QAAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 02:06:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mI1OCfS9I2MurgAA9RJhRA (envelope-from ) for ; Fri, 16 Sep 2022 02:06:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EA3824FFB for ; Fri, 16 Sep 2022 02:06:11 +0200 (CEST) Received: from localhost ([::1]:34314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYyry-0003Y9-Eb for larch@yhetil.org; Thu, 15 Sep 2022 20:06:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYyrr-0003XX-GL for guix-patches@gnu.org; Thu, 15 Sep 2022 20:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYyrr-0001gi-0c for guix-patches@gnu.org; Thu, 15 Sep 2022 20:06:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYyrq-0003lQ-Gt for guix-patches@gnu.org; Thu, 15 Sep 2022 20:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57659] [PATCH v3] gnu: Add blesh. Resent-From: kiasoc5 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Sep 2022 00:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57659 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57659@debbugs.gnu.org, mail@cbaines.net Received: via spool by 57659-submit@debbugs.gnu.org id=B57659.166328672214419 (code B ref 57659); Fri, 16 Sep 2022 00:06:02 +0000 Received: (at 57659) by debbugs.gnu.org; 16 Sep 2022 00:05:22 +0000 Received: from localhost ([127.0.0.1]:59553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYyrB-0003kV-UO for submit@debbugs.gnu.org; Thu, 15 Sep 2022 20:05:22 -0400 Received: from knopi.disroot.org ([178.21.23.139]:40974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYyr7-0003kH-9B for 57659@debbugs.gnu.org; Thu, 15 Sep 2022 20:05:20 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 873B640085; Fri, 16 Sep 2022 02:05:15 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ao-cXSo-K6pS; Fri, 16 Sep 2022 02:05:14 +0200 (CEST) Date: Fri, 16 Sep 2022 00:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1663286714; bh=EoxDe2RZxNazVTTSnOzmCLGPSmJjlcnv0RLlw1OA+ko=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=JF1Pvyin5CoUZl+5Egt7rEFkxl18CIXBY0A6f3rgRcPIe3Oav4VH/KDn4T8HHPzGy rErbBZ5OwiqKSJC5iegreBKVdCTBFX1wDtVBkedcshlGdWHFSijwlTT4bw0TnQCKb9 qFoPg/pXz7RN0S+CRbJgAfVlWavpzwF1d5Lllz3GTZf+HpLKUePFH+83MdfCgukxDG GxY6pqzE9amkOv96yxGLwAR/nqpuc9mI2cjrIXRA5wertDIT8MVrKvxVM1ZIW9lzIu 3Lm4k6VHmhVg5kKQAPShw5Vc4CBs/oLjSs1DrtQJYIqGhkjgHtW+bviRRySxR3+HG6 Tjui0+5aaiJdg== Message-ID: <20220916000511.69ff46e9@aria> In-Reply-To: <4aa38651-563e-000f-3bb0-7a36f01bad6f@telenet.be> References: <20220914030706.47516-1-kiasoc5@disroot.org> <87edwe8hyn.fsf@cbaines.net> <4aa38651-563e-000f-3bb0-7a36f01bad6f@telenet.be> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: kiasoc5 X-ACL-Warn: , kiasoc5 via Guix-patches From: kiasoc5 via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663286772; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=18X9Jikm6sqrMCFZfTUOE7kskAbg5BwlIZS1Y5YL+HQ=; b=Yz1lD4NrA57z28Xyj0owapfsZSZoUiFt64Qhw/+R1Ygt9vNF8BxJf7yEjmifQpWMRvfmY/ GL0iM9xZn53wNRzFbJh5hfg5j041wHH1hDa26/xxU0hPicc5BaOJ7tT7lbmZQX7+nc0pCu 3yO0J3J9ias111uJ86cFjwSwu2S+mhZ1ibDPA4+QX12ECUHjR7OSuUE9HUHegNERAkIie6 giOOLxibaq2vIZ3zQGnuDmNqGj7OQ/yInl/lxJehQnGtqXze1Nj0HWfHWGk3GpaHr/eokX ZFjkH6AMvAGo3wxY8yE+yRcDkeZh1eF690uHfbv7wd13XLqSkrnwT+gZ+8qwjg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663286772; a=rsa-sha256; cv=none; b=hcvGfNQ6qY6oNuix1tjFiPM+mg/cK6HARdoc535YLjWnZd0NN/QFocsY9GPGXuz0gSC1QK u5Lno/erCKCqCWLxXxQF0KXbj5PNLwY2Q+OxI0914yMZKgTUBBmf8KKaHNO9tVNDD7j6WK bSTYENPTs1sxXAkJxe83OxJYeD83oLHBcg9hxSr6q0Bty/83QVpLdi2wmiimWK+VtpOSsW tgVwxkfsnMhgvsqZkjzOmqK+OxYlN3fXOsTndCljKdW8tRtW0QdzNzAvK+c5S0Hzl9KRPl Gwz9Kd9bas2qSHRVI8XG/OcnZBZRzJHIE6iOVlDTht1Dqn0OU5FKk9rdZCk9dQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=JF1Pvyin; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=JF1Pvyin; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9EA3824FFB X-Spam-Score: -0.82 X-Migadu-Scanner: scn1.migadu.com X-TUID: GU9UaJ59b8h5 On Thu, Sep 15 2022, 05:26:30 PM +0200 Maxime Devos wrote: > On 14-09-2022 10:40, Christopher Baines wrote: > > > > kiasoc5 writes: > > > >> Tests pass now. > >> > >> * gnu/packages/bash.scm (blesh): New variable. > >> --- > >> gnu/packages/bash.scm | 45 > >> +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 > >> insertions(+) > > > > Thanks. I've tweaked the name of one of the phaess > > (use-LANG-for-tests rather than use-LC_ALL-for-tests) as that > > seemed more correct. I also removed some inputs that were redundant > > (coreutils is provided by the gnu-build-system, so is an implicit > > input), and git-minimal didn't seem to be required. > > gnu-build-system only provides a _natively compiled_ coreutils (for > --system), not a cross-compiled coreutils (for --target). As such, > it is not redundant (unless it compile-time only (*), the build > system isn't clear to me). Readlink should be required for runtime, how about substituting "PATH=/bin:/usr/bin readlink" -> "readlink" instead of the path to readlink? > >+ (add-after 'unpack 'make-readlink-work > >+ (lambda _ > >+ (substitute* "ble.pp" > >+ (("PATH=/bin:/usr/bin readlink") > >+ (search-input-file %build-inputs > >+ > >"/bin/readlink"))))) > > You're mixing G-exp (new) and %build-inputs (old). How about > (search-input-file inputs "bin/readlink") or (which "readlink") > (depending on whether inputs or native-inputs is appropriate) instead? If we keep coreutils as an input then it would be search-file-inputs. --