From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WB7pIpli1WKbUQAAbAwnHQ (envelope-from ) for ; Mon, 18 Jul 2022 15:39:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ELu8Ipli1WIVQQAA9RJhRA (envelope-from ) for ; Mon, 18 Jul 2022 15:39:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4536410CC4 for ; Mon, 18 Jul 2022 15:39:37 +0200 (CEST) Received: from localhost ([::1]:37328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDQyG-0000Y2-DT for larch@yhetil.org; Mon, 18 Jul 2022 09:39:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDQss-0007nx-ER for guix-patches@gnu.org; Mon, 18 Jul 2022 09:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDQss-0007PG-4w for guix-patches@gnu.org; Mon, 18 Jul 2022 09:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDQss-0005HX-0w for guix-patches@gnu.org; Mon, 18 Jul 2022 09:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56382] bug#20255: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Resent-From: bokr@bokr.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Jul 2022 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56382 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Raghav Gururajan , Morgan.J.Smith@outlook.com, 56382@debbugs.gnu.org, Maxim Cournoyer , 20255@debbugs.gnu.org Received: via spool by 56382-submit@debbugs.gnu.org id=B56382.165815122420268 (code B ref 56382); Mon, 18 Jul 2022 13:34:01 +0000 Received: (at 56382) by debbugs.gnu.org; 18 Jul 2022 13:33:44 +0000 Received: from localhost ([127.0.0.1]:49557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDQsZ-0005Gh-LO for submit@debbugs.gnu.org; Mon, 18 Jul 2022 09:33:44 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:41878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDQsU-0005GH-Tz; Mon, 18 Jul 2022 09:33:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 4BA09E2846; Mon, 18 Jul 2022 13:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1658151213; bh=YWaedQzFVAxzN77LVePc8QihnE0Xeatd+IbYGZJgIw4=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=USXNCC942TEt9OaeJqwvLv9w0OdnaTbJCEZu64iSdIaYm3C1Ydzw7rbVEvBnNBnbJ DW6zJ7h5RWkW/98nnyKkO6HQeTxH/62+6HJen40kyG0uMx3XIWYoUpkLqyKleC0TB3 LF4X7qFl1Qs3b1ZAH91EZucxp5HifLo8UF4M/AvKdB9gAD0sYbuUn6qlBmASsDb1rg dICUXBijg4wP5Chs1hB96kAm2AW4Et1mfExHKfcvlYBjKBxiqZWZ+AN99ZK9N69zYS dTMGfrl7V1OU8eB5f5qE5Ma4mLZNByfroJ8g38UUVsu008q77SyYTM3894LM8bGBt8 xdgKtShSc62EQ== X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TeYpSuVLeBCg; Mon, 18 Jul 2022 13:33:32 +0000 (UTC) Received: from localhost (m90-129-211-26.cust.tele2.se [90.129.211.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id BD477E29C6; Mon, 18 Jul 2022 13:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1658151212; bh=YWaedQzFVAxzN77LVePc8QihnE0Xeatd+IbYGZJgIw4=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=jtEfxLgAZAXc0qso/4Vn98tM3F+BCX6M37ngLxP28RMAnqEl8oT2hLJgIAyBuJDwr eIbSeExAr4RXtGivsBNs+DQFPoOeX53kxzP7/XuFLyyqsANAehmy9r/MGl+fl2OzMw r3SULVTNXed23jJRWtom3NJYfQ6eqJ1ZkfjwJjTkpFDVxeOhJ0KXR75QILeKi1BS/m f3b+6y5GvmGKLlIbrJC0NW1Aty2ekwgFkVcln5eSFz0QVteKMnbekyG2/OAypc7IBw cgV3yrh85rWEMzli+KLjomjeq51HMWwvVrlgXrIZzlwRjAC93Bw4QTVtI6SyArMjxh erGv5KqjNoFIg== From: bokr@bokr.com Date: Mon, 18 Jul 2022 15:33:18 +0200 Message-ID: <20220718133318.GA2771@LionPure> References: <87sfn6asfz.fsf@gnu.org> <877d4e8r79.fsf@gnu.org> <87tu7hsupr.fsf@gmail.com> <87k08a3h0s.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k08a3h0s.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658151577; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XRzX4mVtB2qpAUhXYF6vzQJ+dB+a6U3MuiRSEwmuq1g=; b=YH/9ryLxE7i12/3GHNrQQx3B5lRSCITefCe9oXiiCAfIo0iAJGeb3ulMHZqev3WufmsNqt 6Amyg/9sRQDlITCqcFKp5+xBvvfhq0ipojwCOojQyPoh9sPb/STs82v+V9T3ijB/jhjTfQ nAFWhrEULTWG1xjc/b6SnE9DNBw/kkkm8IXfXVeBRpjwzyJhooaRjFk1h6kLTe4qasFyMA VQ8OqKOjLdOuqopp9q2M9/B/ELhKjcEBd/IDfB5j1n6PWyNr3SNxt5uYKSIbZyIjw8AsBZ okNLZfOEvVWxeP69izZvD1hFxLDt5gqhNIVc/Qi+wFShWmNaSzN3rvMTessbJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658151577; a=rsa-sha256; cv=none; b=SiGBCP1qKFZRDjt84cMUmxeEoRqaNik0jYpDOjU86BtvqxEA+RHbl0Jy5XJCKMpWueSdJ5 4DCdk5mVPdN3TVuKguk8EQVhEtlduDcH/Vh670p/FPfnW4O8ph+Ab1KnMDbnDTPqIWsLnU nCnXSza7ovjFEI7tZo2gO0svBjJeCex9I+OOfgl576pseRCYko01/I4E+Djhvtg7BnBn2u eTtSBBCrts3CHfXdK6y5Bkk9D6Tst5LRa2EtAvj25urlqoPdyG1PS1DtF4vYYRBAc82pE/ VWQFFH7LFf0AAEDA6I8wzRY1NYY285IzmslaTa/sopIQTnYhoEYRDe22+0buKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bokr.com header.s=easymail header.b=USXNCC94; dkim=fail ("headers rsa verify failed") header.d=bokr.com header.s=easymail header.b=jtEfxLgA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=bokr.com header.s=easymail header.b=USXNCC94; dkim=fail ("headers rsa verify failed") header.d=bokr.com header.s=easymail header.b=jtEfxLgA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4536410CC4 X-Spam-Score: 2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: So2O7KTeryby Hi Ludo, On +2022-07-18 11:29:55 +0200, Ludovic Courtès wrote: > Hi, > > Maxim Cournoyer skribis: > > > Hi Ludovic, > > > > Ludovic Courtès writes: > > > >> Hi, > >> > >> "Raghav Gururajan" skribis: > >> > >>>> Does simply adding ‘hicolor-icon-theme’ to ‘inputs’ fix the issue? > >>> > >>> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to be in the profile. Adding these in either system or user profile would prevent this error from occurring. > >> > >> Right, so the proposed patch (adding ‘hicolor-icon-theme’ to ‘inputs’, > >> not ‘propagated-inputs’) shouldn’t make any difference I guess? > > > > I think it works as inputs because of our wrappers (perhaps > > XDG_DATA_DIRS)? But it's kind at odds with our policy which is to let > > users manage icons themselves. > > Yeah. > > > Probably because of #20255 that wouldn't help currently (system and user > > profiles are not merged), but if we fixed that bug we could make the > > situation better by adding 'hicolor-icon-theme' to the default packages > > of our desktop system templates. > > Right. > > BTW, the reason the solution at > was rejected could be revisited. Since that time, search paths made it > into the manifest itself, which brings a speed up: > > --8<---------------cut here---------------start------------->8--- > $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches ' > $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null > > real 0m0.540s > user 0m0.131s > sys 0m0.063s > $ time guix package -p ~/.guix-home/profile -p /run/current-system/profile --search-paths > /dev/null > > real 0m0.135s > user 0m0.130s > sys 0m0.024s > --8<---------------cut here---------------end--------------->8--- > > Thoughts? > > Ludo’. I'm sure you were just after a quick indication and know what can affect timing, but I'm curious: What would the above results be if you did the second timing first, after a power down and cold start? I'm guessing the kernel file systems are pretty clever about caching stuff, especially if you have lots of ram :) I.e., what cached state could the first timing have left for the second to profit from? (I've been fooled maany times, benchmarking and timing :) -- Regards, Bengt Richter