all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alice BRENON <alice.brenon@ens-lyon.fr>
To: 56140@debbugs.gnu.org
Subject: [bug#56140] [Patches] Add and update music packages
Date: Tue, 28 Jun 2022 09:45:26 +0200	[thread overview]
Message-ID: <20220628094526.7ca71999@ens-lyon.fr> (raw)
In-Reply-To: <o8Acm5cfOaqtnIzq2115gx9xgJ2jE0FcDoyhmSHDnUyYRqrMF8zeNDErpYpVcjmuokpGtGw__RkbqGW5xetv_xl_kkmC88mofx2bh08OU4Q=@proton.me>

Hi !

Thanks for submitting this patch ! I'm in no position to provide
a definitive answer to accept or reject this but here are some immediate
things that could be improved.

- your description of Fabla doesn't add much information compared to
  the synopsis. What makes it special ? How is it different from the
  other similar tools ? (see
  https://guix.gnu.org/fr/manual/devel/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions
  for inspiration)
- the other packages seem to have more extensive description, but they
  make very long lines, have you tried formatting your package using
  the `guix style` command ?
  (https://guix.gnu.org/fr/manual/devel/en/html_node/Formatting-Code.html#Formatting-Code)
- you seem to consistently use the "old" syntax for
  packages in native-inputs, as opposed to inputs, is there a good
  reason for that or have you maybe only found examples where the
  native-inputs haven't been modernized ? While it makes sense to
  rename `cmake-minimal` to `cmake` in the definition of
  `distrho-ports` (though I wonder `luppp` didn't require the same
  renaming and keeps the key "cmake-minimal" for `cmake-minimal`, all
  the others occurrences (`("pkg-config" ,pkg-config)`, `("lv2" ,lv2)`…)
  are totally unneeded for as far as I understand and could be
  simplified as `(list pkg-config lv2 mesa)`.

I'm also a bit curious as to why tests need to be explicitly
deactivated in `sorcer`, does running the default cmake command to test
the project result in a failure, not just a NOP ?

I hope some other people will take it over from there because I don't
have much more to contribute : )

Cheers,

Alice




  parent reply	other threads:[~2022-06-28  8:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
2022-06-24  8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
2022-06-28  7:45 ` Alice BRENON [this message]
2022-06-28  8:30 ` [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
2022-06-28 12:40   ` Maxime Devos
2022-07-01 16:04     ` Sughosha via Guix-patches via
2022-07-01 17:29 ` Ricardo Wurmus
2022-07-01 18:05   ` Thorsten Wilms
2023-06-15 16:30 ` [bug#56140] [Patch v2 0/2]: gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-15 16:32 ` [bug#56140] [Patch v2 1/2]: gnu: Add optional-lite Sughosha via Guix-patches via
2023-06-15 16:34 ` [bug#56140] [Patch v2 2/2]: gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-15 18:38   ` Ricardo Wurmus
2023-06-16 14:05 ` [bug#56140] [PATCH v3 0/2] " Sughosha via Guix-patches via
2023-06-16 14:06 ` [bug#56140] [PATCH v3 1/2] gnu: Add optional-lite Sughosha via Guix-patches via
2023-06-16 14:06 ` [bug#56140] [PATCH v3 2/2] gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-16 15:02   ` [bug#56140] [PATCH v4 0/2] " Sughosha via Guix-patches via
2023-06-16 15:04     ` [bug#56140] [PATCH v4 2/2] " Sughosha via Guix-patches via
2023-09-02  1:11     ` [bug#56140] Add optional-lite and distrho-ports Vagrant Cascadian
2023-06-16 15:02 ` [bug#56140] [PATCH v4 1/2] gnu: Add optional-lite Sughosha via Guix-patches via
2023-09-02  8:40 ` bug#56140: Add optional-lite and distrho-ports Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628094526.7ca71999@ens-lyon.fr \
    --to=alice.brenon@ens-lyon.fr \
    --cc=56140@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.