[bug#56248] [PATCH 0/7] Remove use of older check-0.14 from most packages

[bug#56248] [PATCH 0/7] Remove use of older check-0.14 from most packages

[Thiago Jung Bauermann via Guix-patches via]

Hello,

Move packages that are currently using check-0.14 to regular check. Except
for libwapcaplet, which still needs the older version, all others build
fine with the newer one. I noticed this issue because check-0.14 doesn't
build on powerpc64le, and that prevented me from building recutils.

These patches can go on the master branch because according to “guix
refresh -l”, they have few dependents:

- recutils: A single dependent package: emacs-helm-system-packages@1.10.2
- libsigrokdecode: Building the following 2 packages would ensure
  2 dependent packages are rebuilt: pulseview@0.4.2 sigrok-cli@0.7.2
- burp :: No dependents other than itself: burp@2.3.38
- edi :: No dependents other than itself: edi@0.8.0
- libsbml :: Building the following 1 package would ensure 2 dependent
  packages are rebuilt: r-biggr@1.32.0
- iodine :: No dependents other than itself: iodine@0.7.0
- gdm :: Building the following 4 packages would ensure 6 dependent
  packages are rebuilt: gnome-shell-extension-gsconnect@48
  arc-theme@20210412 numix-gtk-theme@2.6.7 gnome@41.0

To test this series, I built all the packages mentioned above on
x86_64-linux. I also built the following ones on powerpc64le-linux:

recutils, emacs-helm-system-packages, libsigrokdecode, sigrok-cli, burp,
libsbml, iodine.

The others don't currently build on powerpc64le-linux for other reasons.

Thiago Jung Bauermann (7):
  gnu: recutils: Use regular check version
  gnu: libsigrokdecode: Use regular check version
  gnu: burp: Use regular check version
  gnu: edi: Use regular check version
  gnu: libsbml: Use regular check version
  gnu: iodine: Use regular check version
  gnu: gdm: Use regular check version

 gnu/packages/backup.scm         | 2 +-
 gnu/packages/bioinformatics.scm | 2 +-
 gnu/packages/databases.scm      | 2 +-
 gnu/packages/electronics.scm    | 2 +-
 gnu/packages/enlightenment.scm  | 2 +-
 gnu/packages/gnome.scm          | 2 +-
 gnu/packages/networking.scm     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)


base-commit: d86ad3d8dff0f6f3d63e52a9309fac9fe279c77a

[bug#56248] [PATCH 1/7] gnu: recutils: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

recutils builds fine with the regular version of check, so use it.

* gnu/packages/databases.scm (recutils)[native-inputs]: Use regular version of
check.
---
 gnu/packages/databases.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 72200fce92d0..0d4405ef90e5 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1577,7 +1577,7 @@ (define-public recutils
      ;; XXX Without labels, the default 'configure phase picks the wrong "bash".
      `(("bc" ,bc)
        ("bash:include" ,bash "include")
-       ("check" ,check-0.14)
+       ("check" ,check)
        ("pkg-config" ,pkg-config)))
     (inputs
      ;; TODO: Add more optional inputs.

[bug#56248] [PATCH 2/7] gnu: libsigrokdecode: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

libsigrokdecode builds fine with the regular version of check, so use it.

* gnu/packages/electronics.scm (libsigrokdecode)[native-inputs]: Use regular
version of check.
---
 gnu/packages/electronics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 6e303f3fdca7..70d960aaab47 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -112,7 +112,7 @@ (define-public libsigrokdecode
                                               "/share/doc/libsigrokdecode"))
              #t)))))
     (native-inputs
-     (list check-0.14 doxygen graphviz pkg-config automake autoconf))
+     (list check doxygen graphviz pkg-config automake autoconf))
     ;; libsigrokdecode.pc lists "python" in Requires.private, and "glib" in Requires.
     (propagated-inputs
      (list glib python))

[bug#56248] [PATCH 3/7] gnu: burp: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

burp builds fine with the regular version of check, so use it.

* gnu/packages/backup.scm (burp)[native-inputs]: Use regular version of check.
---
 gnu/packages/backup.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 5646d909e54a..42c3301958e1 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -1198,7 +1198,7 @@ (define-public burp
            uthash
            zlib))
     (native-inputs
-     (list autoconf automake check-0.14 pkg-config))
+     (list autoconf automake check pkg-config))
     (home-page "https://burp.grke.org")
     (synopsis "Differential backup and restore")
     (description "Burp is a network backup and restore program.  It attempts

[bug#56248] [PATCH 4/7] gnu: edi: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

edi builds fine with the regular version of check, so use it.

* gnu/packages/enlightenment.scm (edi)[native-inputs]: Use regular version of
check.
---
 gnu/packages/enlightenment.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 12d5a56d6a0b..eae3f76301d4 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -465,7 +465,7 @@ (define-public edi
            (lambda _ (setenv "HOME" "/tmp") #t)))
        #:tests? #f)) ; tests require running dbus service
     (native-inputs
-     `(("check" ,check-0.14)
+     `(("check" ,check)
        ("gettext" ,gettext-minimal)
        ("pkg-config" ,pkg-config)))
     (inputs

[bug#56248] [PATCH 5/7] gnu: libsbml: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

libsbml builds fine with the regular version of check, so use it.

* gnu/packages/bioinformatics.scm (libsbml)[native-inputs]: Use regular version
of check.
---
 gnu/packages/bioinformatics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 75973b0dd8fe..bc2d653ba6f2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -14459,7 +14459,7 @@ (define-public libsbml
     (propagated-inputs
      (list libxml2))
     (native-inputs
-     (list check-0.14 swig))
+     (list check swig))
     (home-page "http://sbml.org/Software/libSBML")
     (synopsis "Process SBML files and data streams")
     (description "LibSBML is a library to help you read, write, manipulate,

[bug#56248] [PATCH 6/7] gnu: iodine: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

iodine builds fine with the regular version of check, so use it.

* gnu/packages/networking.scm (iodine)[native-inputs]: Use regular version of
check.
---
 gnu/packages/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b4c50bc783ed..ef8c09a777e3 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -1548,7 +1548,7 @@ (define-public iodine
                           (string-append "prefix=" (assoc-ref %outputs "out")))
        #:test-target "test"))
     (inputs (list net-tools zlib))
-    (native-inputs (list check-0.14 pkg-config))
+    (native-inputs (list check pkg-config))
     (home-page "https://code.kryo.se/iodine/")
     (synopsis "Tunnel IPv4 data through a DNS server")
     (description "Iodine tunnels IPv4 data through a DNS server.  This

[bug#56248] [PATCH 7/7] gnu: gdm: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

gdm builds fine with the regular version of check, so use it.

* gnu/packages/gnome.scm (gdm)[native-inputs]: Use regular version of check.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0cde3caebde8..135d522699a3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8372,7 +8372,7 @@ (define-public gdm
        ("xmllint" ,libxml2)))
     (inputs
      (list accountsservice
-           check-0.14 ;for testing
+           check ;for testing
            elogind
            eudev
            gnome-session

[bug#56248] [PATCH 1/7] gnu: recutils: Use regular check version

[Liliana Marie Prikler]

Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
> recutils builds fine with the regular version of check, so use it.
Mostly duplicate information.  Also you're missing the period at the
end of the message title.  I suggest shortening it to “gnu: recutils:
Use regular check.”

> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
> version of check.
Should be “Replace check-0.14 with check.” or similar.


Likewise for all the other patches, otherwise LGTM.

[bug#56248] [PATCH 1/7] gnu: recutils: Use regular check version

[Thiago Jung Bauermann via Guix-patches via]

Hello Liliana,

Thank you for your prompt review!

Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:

> Am Montag, dem 27.06.2022 um 02:02 -0300 schrieb Thiago Jung Bauermann:
>> recutils builds fine with the regular version of check, so use it.
> Mostly duplicate information.  Also you're missing the period at the
> end of the message title.  I suggest shortening it to “gnu: recutils:
> Use regular check.”
>
>> * gnu/packages/databases.scm (recutils)[native-inputs]: Use regular
>> version of check.
> Should be “Replace check-0.14 with check.” or similar.
>
>
> Likewise for all the other patches, otherwise LGTM.

These are good points. I adopted your suggestions in the v2.

-- 
Thanks
Thiago

[bug#56248] [PATCH v2 0/7] Remove use of older check-0.14 from most packages

[Thiago Jung Bauermann via Guix-patches via]

Hello,

This version addresses Liliana's comments about the message title, body
and changelog, by adopting her suggestions.

Original cover letter:

Move packages that are currently using check-0.14 to regular check. Except
for libwapcaplet, which still needs the older version, all others build
fine with the newer one. I noticed this issue because check-0.14 doesn't
build on powerpc64le, and that prevented me from building recutils.

These patches can go on the master branch because according to “guix
refresh -l”, they have few dependents:

- recutils: A single dependent package: emacs-helm-system-packages@1.10.2
- libsigrokdecode: Building the following 2 packages would ensure
  2 dependent packages are rebuilt: pulseview@0.4.2 sigrok-cli@0.7.2
- burp :: No dependents other than itself: burp@2.3.38
- edi :: No dependents other than itself: edi@0.8.0
- libsbml :: Building the following 1 package would ensure 2 dependent
  packages are rebuilt: r-biggr@1.32.0
- iodine :: No dependents other than itself: iodine@0.7.0
- gdm :: Building the following 4 packages would ensure 6 dependent
  packages are rebuilt: gnome-shell-extension-gsconnect@48
  arc-theme@20210412 numix-gtk-theme@2.6.7 gnome@41.0

To test this series, I built all the packages mentioned above on
x86_64-linux. I also built the following ones on powerpc64le-linux:

recutils, emacs-helm-system-packages, libsigrokdecode, sigrok-cli, burp,
libsbml, iodine.

The others don't currently build on powerpc64le-linux for other reasons.

Thiago Jung Bauermann (7):
  gnu: recutils: Use regular check.
  gnu: libsigrokdecode: Use regular check.
  gnu: burp: Use regular check.
  gnu: edi: Use regular check.
  gnu: libsbml: Use regular check.
  gnu: iodine: Use regular check.
  gnu: gdm: Use regular check.

 gnu/packages/backup.scm         | 2 +-
 gnu/packages/bioinformatics.scm | 2 +-
 gnu/packages/databases.scm      | 2 +-
 gnu/packages/electronics.scm    | 2 +-
 gnu/packages/enlightenment.scm  | 2 +-
 gnu/packages/gnome.scm          | 2 +-
 gnu/packages/networking.scm     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)


base-commit: d86ad3d8dff0f6f3d63e52a9309fac9fe279c77a

[bug#56248] [PATCH v2 1/7] gnu: recutils: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/databases.scm (recutils)[native-inputs]: Replace check-0.14
with check.
---
 gnu/packages/databases.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 72200fce92d0..0d4405ef90e5 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1577,7 +1577,7 @@ (define-public recutils
      ;; XXX Without labels, the default 'configure phase picks the wrong "bash".
      `(("bc" ,bc)
        ("bash:include" ,bash "include")
-       ("check" ,check-0.14)
+       ("check" ,check)
        ("pkg-config" ,pkg-config)))
     (inputs
      ;; TODO: Add more optional inputs.

[bug#56248] [PATCH v2 2/7] gnu: libsigrokdecode: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/electronics.scm (libsigrokdecode)[native-inputs]: Replace
check-0.14 with check.
---
 gnu/packages/electronics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 6e303f3fdca7..70d960aaab47 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -112,7 +112,7 @@ (define-public libsigrokdecode
                                               "/share/doc/libsigrokdecode"))
              #t)))))
     (native-inputs
-     (list check-0.14 doxygen graphviz pkg-config automake autoconf))
+     (list check doxygen graphviz pkg-config automake autoconf))
     ;; libsigrokdecode.pc lists "python" in Requires.private, and "glib" in Requires.
     (propagated-inputs
      (list glib python))

[bug#56248] [PATCH v2 3/7] gnu: burp: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/backup.scm (burp)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/backup.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 5646d909e54a..42c3301958e1 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -1198,7 +1198,7 @@ (define-public burp
            uthash
            zlib))
     (native-inputs
-     (list autoconf automake check-0.14 pkg-config))
+     (list autoconf automake check pkg-config))
     (home-page "https://burp.grke.org")
     (synopsis "Differential backup and restore")
     (description "Burp is a network backup and restore program.  It attempts

[bug#56248] [PATCH v2 4/7] gnu: edi: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/enlightenment.scm (edi)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/enlightenment.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/enlightenment.scm b/gnu/packages/enlightenment.scm
index 12d5a56d6a0b..eae3f76301d4 100644
--- a/gnu/packages/enlightenment.scm
+++ b/gnu/packages/enlightenment.scm
@@ -465,7 +465,7 @@ (define-public edi
            (lambda _ (setenv "HOME" "/tmp") #t)))
        #:tests? #f)) ; tests require running dbus service
     (native-inputs
-     `(("check" ,check-0.14)
+     `(("check" ,check)
        ("gettext" ,gettext-minimal)
        ("pkg-config" ,pkg-config)))
     (inputs

[bug#56248] [PATCH v2 5/7] gnu: libsbml: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/bioinformatics.scm (libsbml)[native-inputs]: Replace check-0.14
with check.
---
 gnu/packages/bioinformatics.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 75973b0dd8fe..bc2d653ba6f2 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -14459,7 +14459,7 @@ (define-public libsbml
     (propagated-inputs
      (list libxml2))
     (native-inputs
-     (list check-0.14 swig))
+     (list check swig))
     (home-page "http://sbml.org/Software/libSBML")
     (synopsis "Process SBML files and data streams")
     (description "LibSBML is a library to help you read, write, manipulate,

[bug#56248] [PATCH v2 6/7] gnu: iodine: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/networking.scm (iodine)[native-inputs]: Replace check-0.14 with
check.
---
 gnu/packages/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b4c50bc783ed..ef8c09a777e3 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -1548,7 +1548,7 @@ (define-public iodine
                           (string-append "prefix=" (assoc-ref %outputs "out")))
        #:test-target "test"))
     (inputs (list net-tools zlib))
-    (native-inputs (list check-0.14 pkg-config))
+    (native-inputs (list check pkg-config))
     (home-page "https://code.kryo.se/iodine/")
     (synopsis "Tunnel IPv4 data through a DNS server")
     (description "Iodine tunnels IPv4 data through a DNS server.  This

[bug#56248] [PATCH v2 7/7] gnu: gdm: Use regular check.

[Thiago Jung Bauermann via Guix-patches via]

* gnu/packages/gnome.scm (gdm)[native-inputs]: Replace check-0.14 with check.
---
 gnu/packages/gnome.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0cde3caebde8..135d522699a3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -8372,7 +8372,7 @@ (define-public gdm
        ("xmllint" ,libxml2)))
     (inputs
      (list accountsservice
-           check-0.14 ;for testing
+           check ;for testing
            elogind
            eudev
            gnome-session

bug#56248: [PATCH v2 0/7] Remove use of older check-0.14 from most packages

[Liliana Marie Prikler]

Am Samstag, dem 02.07.2022 um 01:07 -0300 schrieb Thiago Jung
Bauermann:
> Hello,
> 
> This version addresses Liliana's comments about the message title,
> body and changelog, by adopting her suggestions.
Pushed to master.

Thanks

[bug#56248] [PATCH v2 0/7] Remove use of older check-0.14 from most packages

[Thiago Jung Bauermann via Guix-patches via]

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 02.07.2022 um 01:07 -0300 schrieb Thiago Jung
> Bauermann:
>> Hello,
>> 
>> This version addresses Liliana's comments about the message title,
>> body and changelog, by adopting her suggestions.
> Pushed to master.

Thank you!

-- 
Thanks
Thiago