From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 1dE/DQ5TpmKbHgEAbAwnHQ (envelope-from ) for ; Sun, 12 Jun 2022 22:56:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KLxgCw5TpmLa4wAAG6o9tA (envelope-from ) for ; Sun, 12 Jun 2022 22:56:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF9DA27B82 for ; Sun, 12 Jun 2022 22:56:45 +0200 (CEST) Received: from localhost ([::1]:40450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0UdY-00061o-O3 for larch@yhetil.org; Sun, 12 Jun 2022 16:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0Ubu-0001xX-GB for guix-patches@gnu.org; Sun, 12 Jun 2022 16:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0Ubu-00012e-6C for guix-patches@gnu.org; Sun, 12 Jun 2022 16:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0Ubu-0005OF-4e for guix-patches@gnu.org; Sun, 12 Jun 2022 16:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55896] [PATCH v2] gnu: Add python-pybare. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Jun 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55896 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55896@debbugs.gnu.org Received: via spool by 55896-submit@debbugs.gnu.org id=B55896.165506727120678 (code B ref 55896); Sun, 12 Jun 2022 20:55:02 +0000 Received: (at 55896) by debbugs.gnu.org; 12 Jun 2022 20:54:31 +0000 Received: from localhost ([127.0.0.1]:56569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0UbP-0005NR-DP for submit@debbugs.gnu.org; Sun, 12 Jun 2022 16:54:31 -0400 Received: from mx1.dismail.de ([78.46.223.134]:17822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0UbK-0005N9-Eq for 55896@debbugs.gnu.org; Sun, 12 Jun 2022 16:54:30 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id ff10eaf6; Sun, 12 Jun 2022 22:54:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=fkbydiEBP45xbnJG1RiCAGlgyP3LP51VGYiZx3YaLQA=; b=Bk9 QBrw99M15esQfm7X7/QuImG/1XduO5Fj2RbMiUhTN4WvuvofhLHBXNSWcr9l25aN zqWZCDED61TFeefNbjg8zuNAyfKxoWvtgpfcShHcmY/NIxgveKpl2GVcMCbrKYos cdgffgGo2CJtmoKNHvzUluhK/mFORInC+aT0ZZ/o4Ve/AJd0d0gR5tB2v+11Li3B 41Yz6L+RMueHVy2nrrfOA+orFQ0cgXdJfl7probqMOfUte10het9GIDVtxB6Emgs ggP+ECE8DEqKCs2s7VVE6YG11/oAmy/WeutfZPhPvOafv6uG2809u5eHzFW4cKSa k0uhdodDwhVSF+U6z6Q== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id eaa1c5bb; Sun, 12 Jun 2022 22:54:18 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 576a657d; Sun, 12 Jun 2022 22:54:18 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 26ad4fc4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 12 Jun 2022 22:54:17 +0200 (CEST) Date: Sun, 12 Jun 2022 15:54:18 -0500 Message-ID: <20220612155418.GC1648@gac> In-Reply-To: References: <20220611202700.5655-1-jgart@dismail.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655067405; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=egioY/Zf8kz8Zi24rwyn0CVVeeYzYvWkoJaCv0R7K80=; b=Ll7ZPDMTMuurrejZi43ALUJfmiGP9VEd/zilPNfofUGT2LFy6k/+OKNCIvk2e7K7tbSC1p ELh9p+iXmW5StJUTb/+QGPmM3TM9whtzVn2KqGseFSHNA3vszQR+wTdg2nAsaQehgN6MAb qMZYRvq6ypLriI4M5Jb4f4C41z3+JnuzLs9S2fQ85FbSilO8idvRmIDuP894kHyvcHrvGR Z7gd+MYRnTe75QM2uTmLucrDnAdmv2KLGlVoQcusyN+jj/fr31YO12Srz4/KErVVFZEiHI 23c17sAU4uthI+Ey236D/1qv6jzxzhqJeUpsuHeETtmG1aWbcLfF3hswajVJkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655067405; a=rsa-sha256; cv=none; b=W9n2bbd7l+BhtYkWmxt3pzGF4SQFvmLemQusXDLpCrPov5Z0SpY5NfRZ/SdXx2hnKvukt+ XvLmWPhNdvKdfhr4zt0bRgNnBAq9Yp99DRbxtL68Y1LnlNicXDc41L0UFj8FD/Qm2FbOZJ kq1xLzm1KjK0uJQBk7VLtxAON4UgGJdRnCXeYlIKSs/s6M75oyxeK0naSKN57AWzYzhDgR voyFZHMXJlyyg6tQMLx+Pril3Wh7bWl/plmYjKMknPiKCBZ2Nc3KWpzNnfhBx9Bf7oyAU4 3ujiVq29/D55+H0gB3XI8NtXNGCJSvijGer+6jKsnpBVS8hTwE6TEfmJ5HiKag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="Bk9 QBrw"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="Bk9 QBrw"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BF9DA27B82 X-Spam-Score: -3.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: boOayCKoz2XJ On Sun, 12 Jun 2022 17:41:57 +0200 Maxime Devos wrote: > jgart schreef op za 11-06-2022 om 15:27 [-0500]: > > +(define-public python-pybare > > +  (package > > +    (name "python-pybare") > > +    (version "0.1.1") > > +    (source > > +      (origin > > +        (method git-fetch) > > +        (uri > > +         (git-reference > > +          (url "https://git.sr.ht/~chiefnoah/pybare") > > +          (commit (string-append "v" version)))) > > +        (file-name (git-file-name name version)) > > +        (sha256 > > +         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by")))) > > +    (build-system python-build-system) > > +    (arguments > > +      (list #:phases > > +            #~(modify-phases %standard-phases > > +                (replace 'check > > +                  (lambda* (#:key tests? #:allow-other-keys) > > +                    (when tests? > > +                      (chdir "bare") > > +                      (invoke "pytest" "-vv" "."))))))) > > +    (native-inputs > > +      (list python-pytest)) > > +    (home-page "https://sr.ht/~chiefnoah/PyBARE/") > > +    (synopsis "Declarative implementation of BARE for Python") > > +    (description > > +"@code{python-pybare} is a general purpose library for strongly typed > > +primitives in Python that supports serializing to and from @acronym{BARE, > > +Binary Application Record Encoding} messages.") > > +    (license license:expat > > > Package definition LGTM, but I have only looked at the definition, not > the sources etc. Hi Maxime, no worries. Take your time. The review is much appreciated. I just looked at the sources again myself and noticed that the tests use pre-generated BARE binaries to test against. See here: https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225 and here: https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples Should I ask the author if they can provide a way to generate those binaries for testing instead of vendoring the pre-compiled binaries without their sources? all best, jgart