From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IO2hAOhRSGKexwAAgWs5BA (envelope-from ) for ; Sat, 02 Apr 2022 15:38:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ENqVOedRSGJLSwEA9RJhRA (envelope-from ) for ; Sat, 02 Apr 2022 15:38:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C491E290 for ; Sat, 2 Apr 2022 15:38:47 +0200 (CEST) Received: from localhost ([::1]:51218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nadxl-00051n-S6 for larch@yhetil.org; Sat, 02 Apr 2022 09:38:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nadxP-00051f-E1 for guix-devel@gnu.org; Sat, 02 Apr 2022 09:38:23 -0400 Received: from mail92c40.carrierzone.com ([209.235.156.232]:41962 helo=mail117c40.carrierzone.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nadxN-0005B2-25 for guix-devel@gnu.org; Sat, 02 Apr 2022 09:38:23 -0400 X-Authenticated-User: bokr@oz.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=carrierzone.com; s=mailmia; t=1648906694; bh=0rG3VDtuVlQ3PRhEs/zPm/k8Dvz7EAXxxXptRYGK9j0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=wC0JJRDSTwAkL2O9U+eQnVA4qoi2WfHDf3Gp3rHRXW2Wzalygc5UKmeToeIVsCmaw gC9qKraAqug3h29p1qQBYdHTPj3dd/oDGaRQzmJBl/k38c5Ygt3BPmBwg4QPOiFwph IvOV8eM4ScQRLP5hy85Gy5A+99z+cX2fhIcfu06I= Feedback-ID: bokr@oz.net Received: from localhost (m90-129-212-190.cust.tele2.se [90.129.212.190]) (authenticated bits=0) by mail117c40.carrierzone.com (8.14.9/8.13.1) with ESMTP id 232Dc9os002444 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 2 Apr 2022 13:38:12 +0000 Date: Sat, 2 Apr 2022 15:38:00 +0200 From: Bengt Richter To: Liliana Marie Prikler Subject: Re: New review checklist Message-ID: <20220402133800.GA2462@LionPure> References: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> <447d4df82b8626181b37bedb37ba60d212cd98e9.camel@telenet.be> <01ff99a0452cb12718938646388302ac372a7416.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01ff99a0452cb12718938646388302ac372a7416.camel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CTCH-RefID: str=0001.0A742F19.624851C6.0017, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: pass client-ip=209.235.156.232; envelope-from=bokr@oz.net; helo=mail117c40.carrierzone.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648906727; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=G8STdLAz143NoRCVYs9Dz7qdJE1/DXMmMZP09r9Urk4=; b=lsidfcljnNo8+mSm5a9wF0Z9+bhogGYAe35/s/ThufxGzk/5u+wM+QEPGKZBP/ajanlL6V kzuyc5GuNmUI3lNNpWGA46LW4XQgwTyhoK5hiojujmJG60ujFLNZIHjzB+WfNhaYVhLR5n RBYq02Sltg8Vb2NbZAnSpV1mxVA6s6Er0qkwhU6vdVPrPOVtPum93NvuR6o4hV4OjlCoK4 V7Fln7POHZqPqcCc3wYv3IsdGn/tw5m2r47y+RCUbp9jiuAsrohWWimMMZbBCdxu0PbHAz F7K5k+/eu7d6P0xan8PxVZwVjhyFsGma/QWblJrdAqu/DPg0kBJD6mHN0JtVbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648906727; a=rsa-sha256; cv=none; b=GZHOsxaiLgurn0T7hVVcGH+EqnluMfL7CDaetXPPfRwNdnj/f+n1RVGsQQ4vWrd24zoJEe KwWeNXxZUZtiOHLOMp3K8ZAXQdID2rmaiNG8/mF68eBxhj+pxKQ8GbbyoOjFghU29fw/VD 93hmacNdakiY6uyTH3PoU9J8wnnX2m4YGt6wgXOpdf1jor1Zgcc3sXTBOAwVGsugaaL7Cf QtM5WrZ7Wm4O9qvrbsQKKV8KFfssdzkroCXyd6hEOcPbyVZA8i/T6Os70KVgkLkWr4NRtz gXGKRG5hkuWpAVc5g5ufvAqN2qkzYdsIWquJ5lePrVBfYw56Kd2B5Tm9PBM9Uw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carrierzone.com header.s=mailmia header.b=wC0JJRDS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carrierzone.com header.s=mailmia header.b=wC0JJRDS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0C491E290 X-Spam-Score: 1.62 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0Sh8+xFQxGWO Hi Liliana, Maxime, et al, On +2022-04-01 20:25:37 +0200, Liliana Marie Prikler wrote: > Hi Maxime, > > Am Freitag, dem 01.04.2022 um 19:46 +0200 schrieb Maxime Devos: > > [...] > > I know there have been some discussions in the past about whether > > git-version should be used when a commit is explicitly chosen, > > whether > > tags should be used instead of commits, how high a risk there a is that > > version->commit can become multi-valued, ‘tricking peer review’ ... > > > > However, my question isn't about any of that.  It is only about the > > let-binding itself, in situations where the bound variable is only Here ISTM important to understand exactly what you mean by "let-binding" so I would really like it if I could type --8<---------------cut here---------------start------------->8--- info guile let-binding --8<---------------cut here---------------end--------------->8--- into my command line interpreter, and get right to the details as I often can for other things, e.g. --8<---------------cut here---------------start------------->8--- info guile define-macro --8<---------------cut here---------------end--------------->8--- This suggests to me something like a translation project, except not bewween local natural languages, but between expert guile/guix implementer's terminology and detailed explanations that various level programmers can go into as deeply as they want (following suggested reading if not included in the info doc itself). I am also imagining info could be instrumented to emit a minimal email to a server that could accumulate statistics on no-hit lookups, and that this could be visible in some tool when someone feels like contributing to make --8<---------------cut here---------------start------------->8--- info guile what-does-this-mean --8<---------------cut here---------------end--------------->8--- produce a result that we can all refer to when we want/need to say "that's what I am talking about." After getting past foot-binding and other bindings, wikipedia got me to [0], which might be a nice read-further hint, but what did Maxime mean, out of all those possibilities? [0] https://en.wikipedia.org/wiki/Scope_(computer_science) To be really precise, if he could point to a formal definition in some style from [1] [1] https://en.wikipedia.org/wiki/Denotational_semantics that could really nail it when such detail was necessary. Of course, --8<---------------cut here---------------start------------->8--- info guile define-language --8<---------------cut here---------------end--------------->8--- leads to wonder-land. But if you just want a quick check that you have the right concept for something you read, well, good luck in RL -- in fact I just missed a local library music event because I was reading guile info docs to make examples for this post -- i.e. got drawn into reading about define-language and not watching the time ;-/ I think for best effect, there should be no dependencies to prevent usage anywhere "info guile" answers usefully at the command line. Anyone else want to know exactly what Maxime meant by "let-binding" ? :) > > used in a single place.  What is the reason for doing > > > > (let ((commit "cabba9e...")) > >   (package > >     (name "foobar") > >     (version "0.1.2") > >     (source (origin ... > >               ;; this is the only use of the 'commit' variable bound > > in > >               ;; the above 'commit' > >               (commit commit))) > >     ...)) > > > > when it can be simplified to > > > > (packaeg > >   (name "foobar") > >   (version "0.1.2") > >   (source (origin ... (commit "cabba9e..."))))? > > > > I mean, we don't do this for, say, 'name', 'version' and 'uri': > > > > ;; these three variables are only used in a single location > > (let ((name "foobar") > >       (version "0.1.2") > >       (uri "https://foo.bar")) > >   (package > >     (name name) > >     (version version) > >     (source (origin (uri uri) (commit ) [...])) > >     ...)) > > > > Why would things be different for 'commit' here?  How does putting > > the value of 'commit' in a let-form reduce surprises? > The main goal of let-binding commit and revision is to allow for easier > change. Suppose you need to reference some half-release for some > obscure reason, then this style makes it easier to switch to what is > already established praxis. > > In general, consider the poor soul who may have to read and maintain > your code after you get hit by a car because neither busses nor trams > run in your region. > -- Regards, Bengt Richter