From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ACp2AC80O2JEYwAAgWs5BA (envelope-from ) for ; Wed, 23 Mar 2022 15:52:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4G7bNC40O2I0eQEAG6o9tA (envelope-from ) for ; Wed, 23 Mar 2022 15:52:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2F3615FF0 for ; Wed, 23 Mar 2022 15:46:18 +0100 (CET) Received: from localhost ([::1]:60770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX2Fd-0001fk-TR for larch@yhetil.org; Wed, 23 Mar 2022 10:46:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX2Ee-0001Iv-6a for bug-guix@gnu.org; Wed, 23 Mar 2022 10:45:17 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX2DS-0006Do-D9 for bug-guix@gnu.org; Wed, 23 Mar 2022 10:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX2DS-0002RF-BV for bug-guix@gnu.org; Wed, 23 Mar 2022 10:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#53368: [PATCH v3] Added orca-lang package References: <99e271fa-7b0e-30f6-0613-57e7942826a3@gmail.com> In-Reply-To: <99e271fa-7b0e-30f6-0613-57e7942826a3@gmail.com> Resent-From: Christopher Rodriguez Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 23 Mar 2022 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53368 X-GNU-PR-Package: guix X-GNU-PR-Keywords: moreinfo To: 53368@debbugs.gnu.org Received: via spool by 53368-submit@debbugs.gnu.org id=B53368.16480466109318 (code B ref 53368); Wed, 23 Mar 2022 14:44:02 +0000 Received: (at 53368) by debbugs.gnu.org; 23 Mar 2022 14:43:30 +0000 Received: from localhost ([127.0.0.1]:45473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX2Cr-0002Q7-9M for submit@debbugs.gnu.org; Wed, 23 Mar 2022 10:43:30 -0400 Received: from mail-qv1-f52.google.com ([209.85.219.52]:43582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX2Cq-0002Pu-2d for 53368@debbugs.gnu.org; Wed, 23 Mar 2022 10:43:24 -0400 Received: by mail-qv1-f52.google.com with SMTP id f3so1330127qvz.10 for <53368@debbugs.gnu.org>; Wed, 23 Mar 2022 07:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hDcxsf+OLFEQMYQHaB+CXRPHh/BvP7RoUHq4M17LyOg=; b=Qxv9fXDzukCvEbq2n9g5jjqoj2G+YOCX+Xy510q31XJmWlUvnAq/EWs16GRN8MEHUJ lmZx3hdB6WC/gCIiNMZsOeRK6Xhsi+ciCL4Ght9F15aCETjeRoyM6Kh2hSBQXpFhBlFk wLTuCZ35XvpiFnVkq2VvAl0pHk+KN1dleFVPg8ymHsaWjET/tmoYT4dqNZAUW2wxSd+y ONml0sON/HzAmU4hbcpkaFgM1O8clvaZXkIJQdDyE3ZQ8mOiHIpJnhSQGzxSSWcOH14H idpitEwteRzsBQbMN3K5GBpjSQlc+m6wRMO7oEERSqQrRBysk8SG+hMRI/2rtUokRw+9 QAGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hDcxsf+OLFEQMYQHaB+CXRPHh/BvP7RoUHq4M17LyOg=; b=rU6lSKkeZDRXKp/nLx+5YtFOzVz2K9DPMAo8V+4XhXLNoib3Vv3AUemTFgd+CMF4qZ UZVZRY1XwfyVgQ34HUmihLJdB10Ovt6OeUEhsx1XdXQjkmH8/ZpfvnOxXg+R/pB46vMj GVwNoSM3TxIbNNApR69hdvLHCSLA6WeRpYQDezrmDnoPqz9SRkJ1+/pA/HDkph/jjsYM Od968AGlcHpfSNQ+skkwWyfS3WhpU+e5q6CEaRPz7Qdft5KGWUfqNWGwRvjcNFV8uvDT yN38fYBw3nnyMuoPrGnbYkmXl/QRfo6Qg7zI8Ic8nxk+2PM58SlVSDFLlU3SXD44Tl9y 6U0A== X-Gm-Message-State: AOAM533chfUiuik4EfJVHW/eD88Zh07mNGgzaS3OU7zXeOl8hkXtCtkp v9y9TTsoYtjZb/kn150v9vToflpPR00= X-Google-Smtp-Source: ABdhPJzYM+i6C+Y3e4o83LUCqV/3jnWvkh6YwxZJa9H8YqavoTva18uoDQsNa5919MrFpN9KP9L2oA== X-Received: by 2002:a05:6214:508a:b0:440:f89a:af4e with SMTP id kk10-20020a056214508a00b00440f89aaf4emr138838qvb.110.1648046597926; Wed, 23 Mar 2022 07:43:17 -0700 (PDT) Received: from gorse.members.linode.com ([2600:3c03::f03c:92ff:fec0:a2d7]) by smtp.gmail.com with ESMTPSA id b13-20020ac85bcd000000b002e06856b04fsm174714qtb.51.2022.03.23.07.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 07:43:17 -0700 (PDT) From: Christopher Rodriguez Date: Wed, 23 Mar 2022 10:42:52 -0400 Message-Id: <20220323144252.22915-1-yewscion@gmail.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christopher Rodriguez Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648046779; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hDcxsf+OLFEQMYQHaB+CXRPHh/BvP7RoUHq4M17LyOg=; b=SecUc4B0dx10VqWrOdGj49/HIT0Ur2Cl49o9/ZgpqyYCKDDV4Lp9xKYLNjrI88XlRdQPyE ZWejED73TsKLuyyRexnwNz961pV3ts0Xq9x0FOiD+me0tQnm/aXaQPFPErMxA/rRESuJx1 l/KsqLW+scSW0VA4yd1+ScwQFIs/dVoNSkhpX/yHt399QGxqND1cp4308c3neloMMV6Nnk ITvGpZ7Ymi8Eeg6lfpOg3j46Jw0C8xIsMrJlRVoRe2HcvfxBnZag9R4/KPSVvophU8CVY4 JyDL4ZbEG312PZn6xx3jJagG3LJCPpmtqiuX2pUL1CfVkK6ohEj3EKuafJli9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648046779; a=rsa-sha256; cv=none; b=iAMXUOM262FeWYA+Mdx5d63SgPqB9UOqn4jvvH7ZZoyXerkCutgcC+LX3jba+JOAepui+A IV8qIPyzKfsiW1E+ZnikugJF7ofLdEd56HHwgv86NLT8kraFSDZAcZM4GHarQ31RdFwwEV BQ2VThxDJdiuAYkbD2G3YMCv3CmSfeL50ZCo6eJ3YaLgmy/EVKaPkC2GA/eEk0XYOblB3g J3IcZ7OK8lAaWzPFvTJX8sALLwDKmc6hutcylTPAtRxkXvOJJ2YVxVa4NZYpVCYRtdz3/W xmv8CEelY62+Xv2zz42K0TqS45Evh/TCDljHcyb+EVMohYbfgxOTYWUHSO9bKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Qxv9fXDz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 10.41 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Qxv9fXDz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F2F3615FF0 X-Spam-Score: 10.41 X-Migadu-Spam: Yes X-Migadu-Scanner: scn0.migadu.com X-TUID: GKWuv5Hl1UJz --- > This is broken when cross-compiling, try 'cc-for-target'. > Additionally, 'outputs' and 'inputs' are unused here. > Why? > Why the capital letters? And why mention ‘Esoteric’ in the synopsis and > description? Also, it is not actually a programming language, it is > more an implementation of a language for producing music. > This is not texinfo markup. > Personally I'd go with "orca-music". > I don't think that abbreviations are necessary here, these's enough > space here. > Spacing went wrong here, try running "./pre-inst-env guix style" on the > package. > This seems rather confusing naming. Libraries are put in [...]/lib, > not [...]/share. Alsso, I think you could drop the 'dest-' prefix > here. > Phases do not need to return #f anymore. All of the above were amended as written in this version of the patch. > Why are these phases deleted? Went back and audited the phases I initially deleted; Two remain deleted in this patch: configure, and check. This is due to the package not using a configure script, nor having any 'check' defined for make. > Why are these propagated? I've propagated both alsa-plugins and alsa-plugins:pulseaudio because this package using portmidi for midi output, and needs to load the `libasound_module_conf_pulse.so` shared library to interface with MIDI when using `pulseaudio`. Is there another way to do this without propagating these? > Where does this revision come from? This is the first version of orca > in Guix. The revision was in my personal channel; I kept bumping the revision number because I needed to recompile the package, and `guix build -f` would assume the package was already compiled. I've reverted it to revision 1. > "git" is not a version numberr, I suggest "0" instead. > Also, why is a ‘random’ git commit used instead of an upstream version? The upstream package at https://git.sr.ht/~rabbits/orca does not have any tags, let alone version tags. And as near as I can tell, it does not use semantic versioning at all. I used "git" because of my experience with rpm packaging; I have changed this to 0 here, to align with Guix conventions. > Is it agpl3-only or agpl3+? It is actually expat; apparently I neglected to update this field when defining this package. I have fixed this here. > If you do this, you'll have to add the native-search-paths of ncurses > to orca-lang, because of https://issues.guix.gnu.org/issue/22138. Discussed this with maximed on #guix. When I tried to apply `(package-native-search-paths ncurses)` it introduced a bunch of undefined variable errors. This may be due to cyclic imports; either way, it seems to be an issue outside the scope of this package. I've chosen to instead explicitly define the same native search path (namely, for TERMINFO_DIRS) as ncurses in this package, to work around this bug. Here's the patch. Let me know what else can be improved. Particularly, I am worried about the name of the binary. It is currently installed as `orca`, which is (I believe) the same name given to the binary for the orca screen reader. Should I change this? And if so, how? gnu/packages/music.scm | 57 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 9c8203aa80..1240027050 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6879,3 +6879,60 @@ (define-public musikcube streaming audio server.") (home-page "https://musikcube.com/") (license license:bsd-3))) +(define-public orca-music + (let ((commit "5ba56ca67baae3db140f8b7a2b2fc46bbac5602f") (revision "1")) + (package + (name "orca-music") + ;; No upstream version numbers; Using commit instead. + (version (git-version "0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~rabbits/orca") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1mnhk68slc6g5y5348vj86pmnz90a385jxvm3463fic79k90gckd")))) + (build-system gnu-build-system) + (arguments + `(#:phases (modify-phases %standard-phases + (delete 'configure) ;; No autoconf + (delete 'check) ;; No make check + (replace 'build + (lambda* (#:key inputs outputs #:allow-other-keys) + (setenv "CC" + ,(cc-for-target)) + (invoke "make" "release"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) (dest-bin (string-append + out + "/bin")) + (share (string-append out "/share")) + (dest-examples (string-append share "/examples")) + (dest-doc (string-append share "/doc"))) + (install-file "./build/orca" dest-bin) + (copy-recursively "./examples" dest-examples) + (install-file "./README.md" dest-doc))))))) + (inputs (list ncurses portmidi)) + (native-inputs (list pkg-config)) + ;; The below are needed as propagated inputs to let orca interact with + ;; alsa/pulse MIDI. + (propagated-inputs `(("alsa-plugins" ,alsa-plugins) ("alsa-plugins:pulseaudio" ,alsa-plugins + "pulseaudio"))) + (native-search-paths (list + (search-path-specification + (variable "TERMINFO_DIRS") + (files '("share/terminfo"))))) + (synopsis "musical live-coding environment") + (description + "This is the C implementation of the ORCΛ language and terminal +livecoding environment. It's designed to be power efficient. It can handle +large files, even if your terminal is small. + +Orca is not a synthesizer, but a flexible livecoding environment capable of +sending MIDI, OSC, and UDP to your audio/visual interfaces like Ableton, +Renoise, VCV Rack, or SuperCollider.") + (home-page "https://100r.co/site/orca.html") + (license license:expat)))) -- 2.34.0