From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ED7gHIRjK2JInAAAgWs5BA (envelope-from ) for ; Fri, 11 Mar 2022 15:58:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eGKSFYRjK2LSVgAAG6o9tA (envelope-from ) for ; Fri, 11 Mar 2022 15:58:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B1483C5BB for ; Fri, 11 Mar 2022 15:58:12 +0100 (CET) Received: from localhost ([::1]:38718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSgiY-0008RQ-EG for larch@yhetil.org; Fri, 11 Mar 2022 09:58:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSgiQ-0008QW-Bu for guix-patches@gnu.org; Fri, 11 Mar 2022 09:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSgiQ-0001Bd-3e for guix-patches@gnu.org; Fri, 11 Mar 2022 09:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSgiQ-0001nU-0O for guix-patches@gnu.org; Fri, 11 Mar 2022 09:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54323] [PATCH] Add font-google-roboto-mono References: In-Reply-To: Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54323 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54323@debbugs.gnu.org Received: via spool by 54323-submit@debbugs.gnu.org id=B54323.16470106606873 (code B ref 54323); Fri, 11 Mar 2022 14:58:01 +0000 Received: (at 54323) by debbugs.gnu.org; 11 Mar 2022 14:57:40 +0000 Received: from localhost ([127.0.0.1]:38153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSgi3-0001mn-Oj for submit@debbugs.gnu.org; Fri, 11 Mar 2022 09:57:39 -0500 Received: from cyberdimension.org ([80.67.179.20]:57066 helo=gnutoo.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSgi1-0001mb-Se for 54323@debbugs.gnu.org; Fri, 11 Mar 2022 09:57:38 -0500 Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1]) by cyberdimension.org (OpenSMTPD) with ESMTP id a1254809 for <54323@debbugs.gnu.org>; Fri, 11 Mar 2022 14:57:25 +0000 (UTC) Received: from primarylaptop.localdomain (localhost [::1]) by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 0d697332 for <54323@debbugs.gnu.org>; Fri, 11 Mar 2022 14:57:25 +0000 (UTC) Date: Fri, 11 Mar 2022 15:57:57 +0100 From: Denis 'GNUtoo' Carikli Message-ID: <20220311155757.424f9fc1@primarylaptop.localdomain> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/pcA+1=htlvwi5LuwdaGOxIS"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647010692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=dKRUQbXW4xqUJMCIJS/FfWzK9o/phrUeEDUM4ROwG9o=; b=D/3b3xnrU1kTNmFpkXxF0GVrTz7VFRbQUvP+HGdDtUjwbavcY31oORiocxd7eTiJsSKMeV NYB8d9I/Bfh+AvMHPTol5LD1Z3ehvAaJmgnHpXoBUL7JhwadaP3jv3Zt3cK1asNJf9oj1R 0qjB1Pv1U5UCoQSKdZpqVOquYP31eQfIj7fGt1U0DGOBeeVqkF8Cx3jxrV0gro6pqRFgmS g1ZKJNrMnJObW7c3aHXEzLIWRClEui0NI0bwisNw/qEAMbxvL6U+84UV/uqIuHSgnYORRL GBWFBE4NxrudbT/WhE2+cTGbje+jI+A9MSY1yYa3VUnJYGmSaP24ko1yh+zg+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647010692; a=rsa-sha256; cv=none; b=LhRQfwrl3DxtfrlooXmz3hmlQRQWWWSNRbBCAy26bJ9HfSEUPY2qsQiu/s4uXFvMBqs9V2 BC97BNKbJgikjNTjyTpDeMch+83UHWKpaa5BViZ6Oq/5XIjDa16lsl7Mf+HD4NZTNn40BP wTTdcaE8Y1+KU44F+Siel8myEIKXpgj24fzav7E1sGjP8WwStz824MCGnHjNlYbU1pFuz/ H6u0VjkGeoQg1JzKpmA8p7kYzUFRE3eMg1DGsZE4vPb2UnqYfZ3/73e8Zu6VvH0+9RTGZL JRBj9+MT2Tn15QkcKp/w7dXefYKcwg9vq3gNmGb1ZVnkQRb+zcXYX2l5yr7+/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.69 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0B1483C5BB X-Spam-Score: -5.69 X-Migadu-Scanner: scn0.migadu.com X-TUID: dlsNsqA+RoAA --Sig_/pcA+1=htlvwi5LuwdaGOxIS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Thanks for working on this patch. Note that I'm not a Guix maintainer (I only managed to send some patches and get them accepted), but I've seen several things to fix in this patch and I've also some questions: - You used 'license:asl2.0' as the license, while looking rapidly at the source I didn't find any license. Do you know where the license is stated in the font source code? - If you really want to fix font-adobe-source-code-pro and font-dseg code style, it should be done in one or two separate patches. Two patches are probably easier for maintainers to review. - I've also noticed that this patch lacks any commit message details. Something like that should work: gnu: Add font-google-roboto-mono =20 * gnu/packages/fonts.scm (font-google-roboto-mono): New variable. Also there may or may not be additional issues as I've only looked at it rapidly. Denis. --Sig_/pcA+1=htlvwi5LuwdaGOxIS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmIrY3YACgkQX138wUF3 4mMoPg/7BdMtJ6tNo8OMO8Cn2mILW1dpYnYx1IJ0dJ5/xIfl8fpO0Nk7S140Q6Uc m0Nhf1btrQbz2iL7aP+yvJUSxmeMbd6vZ2Kuae+R6iaoVILh7Kd/ljNBPQF3C/S+ IRGaYjgnm4DMvdLw5IjcGYmePwNXeJD4xgPSdxrimUHuw6uFIP7CN7HG4cRbcaFI GBzqDWJPwa2ByWsuxU2pGd4BTfHAKsrUMpXVgc5pNUT2KbD2wJhAKy5ruSNpo6au //uFzhMCfubuf/uhntA1M4GU1FucQvO6ouCUyDquSnozNwFTEWFw5t+NkIHcmRsE 63uJrW/vfljIH3BdBCAxj/HhvEW4ojhhQDk9wjP+blCriObi5Mz15gLH4zW1DRFx A2ny2Z0fQO43eTRPhCL6CKwABUR6lo+LewmiijPiplXdR5QTVGVChN2CRt25PRTc ptzhWP06u3glG1zUCbo4ApdV+CJmmUlMUY+RgVY8GAaBAU0MfSNrNP8H1xZ2tPk8 tzs9KsVUfvyHmA6f3OwsfzIT2M6JvQvJ0e/bF1vcZoZ/HxurMMz8GRJlh5nlaLHB 0shVbDgzRa+E9gVSQcobdmkgc75QPxqTDpVctT1rZw11xHTafxsDwiZl3ivDQHlF Z/sWZByHNChYKgQj1hwjNDSt7yb7s+E1zICO6v2BXbDUoxwgyS4= =Vj99 -----END PGP SIGNATURE----- --Sig_/pcA+1=htlvwi5LuwdaGOxIS--