From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UHeTNiEXFGKVBgAAgWs5BA (envelope-from ) for ; Mon, 21 Feb 2022 23:50:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kJVVLyEXFGIYYwEAG6o9tA (envelope-from ) for ; Mon, 21 Feb 2022 23:50:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D6421520C for ; Mon, 21 Feb 2022 23:50:09 +0100 (CET) Received: from localhost ([::1]:58076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMHVP-0008An-Eu for larch@yhetil.org; Mon, 21 Feb 2022 17:50:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMHQU-00085P-Qd for bug-guix@gnu.org; Mon, 21 Feb 2022 17:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMHQU-0001IH-DT for bug-guix@gnu.org; Mon, 21 Feb 2022 17:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMHQU-0004bT-9Y for bug-guix@gnu.org; Mon, 21 Feb 2022 17:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#54097: go importer does not honor multi-module repositories Resent-From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 21 Feb 2022 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54097 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54097@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.164548344817603 (code B ref -1); Mon, 21 Feb 2022 22:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2022 22:44:08 +0000 Received: from localhost ([127.0.0.1]:39371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHPc-0004Zr-HF for submit@debbugs.gnu.org; Mon, 21 Feb 2022 17:44:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:49684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMHPb-0004Zk-4b for submit@debbugs.gnu.org; Mon, 21 Feb 2022 17:44:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMHPY-0005zu-K6 for bug-guix@gnu.org; Mon, 21 Feb 2022 17:44:06 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:52508 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMHPV-0001DX-0V for bug-guix@gnu.org; Mon, 21 Feb 2022 17:44:02 -0500 Received: from alma-ubu.fritz.box (p508ac6e4.dip0.t-ipconnect.de [80.138.198.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id 5116F3F9B0 for ; Mon, 21 Feb 2022 23:43:57 +0100 (CET) Date: Mon, 21 Feb 2022 23:43:54 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20220221234354.7698f141@alma-ubu.fritz.box> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/wDeKKh4SGBL=NxJVg=fQze="; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=83.151.27.109; envelope-from=bjoern.hoefling@bjoernhoefling.de; helo=bjoernhoefling.de X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.187, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645483809; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post; bh=hXxo9La6gXSfq/5CvUDyKPXsD9YeCiHv8wLHzE8wbMI=; b=nEiyGLTcEiOGvloJZaoAyWkwxGN5poJEgSIYlM7i2v0AlxjirkILDN5gxgfL1aAIVao60d xER0iME7fCZ3ZKZYX1DC7FaT82lmfmU0xEg5wM7mIrD/1utmm5f/QRj43bIAmT+kxkt+s1 Pvg548cn0uOeiy6fsttZuWtIAVnyBnfUb0yARyPF+o1diBBVikHMhJkd1pSi8bWVsE4DYp oNjXNCvm+IKrbD6boo5tfMC+P49Y+3v1UQIl4MrLjEG5hN+IxQDOiLtdvZnF18WcCAmjMF fnQNmFFwgpiNyHqtBqAks8YUiAQZgpT38Jwzu8NArk5pFffxhnj6ke1nycS67A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645483809; a=rsa-sha256; cv=none; b=lzLHNcq9YpHWcSb/+MYQzmDpRvd6rIjInDZBXRHyEwNNhci1SsyxG3f8qCuR4c7RDHA0W+ 9vWqo03rX54dmIhVjCx4h7FNaOjLOt2Rl7J5HLEamLgE38MwqIrBWmBTJ95AwxpAFSrtcj TKisEp1wl4wTP15XPMJwvx11AVxtd/9LuaT6q39oVxHGUkyyZEHBa818usUgknY5/08FgO Pi+RMq9l6f5OGb00vHMChFdfFHniy98XVWC+prW9mRxL7KMDGC/FjJz1+u2CsQUC+f6ut/ DCMoAb7HoyGpflx91MGLIGpE2mCHUpWECdZMSBf176WLgZ4b9HvR/wDIBEOazA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4D6421520C X-Spam-Score: -5.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: YsQIxRCHQeOR --Sig_/wDeKKh4SGBL=NxJVg=fQze= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go usually has the 1 repository=3D1 module convention. However, it is also allowed that one repository contains multiple go modules. If repository "foo" contains only one module, then versions are tagged "v1.2.3". However, if the repository "foo" contains modules "bar" and "baz", each in a sub-directory of "foo", the versions will be tagged with their respective prefix, i.e.: foo/v1.2.3 bar/v4.5.6 See here: https://github.com/golang/go/wiki/Modules#publishing-a-release https://github.com/golang/go/wiki/Modules#faqs--multi-module-repositories https://stackoverflow.com/questions/64701064/golang-separate-versioning-of-= multiple-modules However, our go-importer does not honor this. The Google Cloud API modules are structured into sub-modules, but our importer searches the wrong tag and raises an exception: $ ./pre-inst-env guix import go cloud.google.com/go/storage URL FOR VERSIONS: https://proxy.golang.org/cloud.google.com/go/storage/@v/l= ist FETCH_GO_MOD: https://proxy.golang.org/cloud.google.com/go/storage/@v/v1.21= .0.mod Backtrace: In ice-9/boot-9.scm: 1752:10 17 (with-exception-handler _ _ #:unwind? _ # _) In unknown file: 16 (apply-smob/0 #) In ice-9/boot-9.scm: 724:2 15 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 14 (_ #(#(#))) In guix/ui.scm: 2209:7 13 (run-guix . _) 2172:10 12 (run-guix-command _ . _) In guix/scripts/import.scm: 124:11 11 (guix-import . _) In ice-9/boot-9.scm: 1752:10 10 (with-exception-handler _ _ #:unwind? _ # _) In guix/scripts/import/go.scm: 116:29 9 (_) In ice-9/exceptions.scm: 406:15 8 (go-module->guix-package* . _) In ice-9/boot-9.scm: 1752:10 7 (with-exception-handler _ _ #:unwind? _ # _) In guix/import/go.scm: 525:18 6 (go-module->guix-package "cloud.google.com/go/storage" # ?) In guix/git.scm: 277:4 5 (update-cached-checkout _ #:ref _ #:recursive? _ # _ # _ ?) 266:18 4 (resolve _) In git/reference.scm: 60:8 3 (_ _ _) In git/bindings.scm: 77:2 2 (raise-git-error _) In ice-9/boot-9.scm: 1685:16 1 (raise-exception _ #:continuable? _) 1683:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1683:16: In procedure raise-exception: Git error: reference 'refs/tags/v1.21.0' not found The correct git reference to look for is: refs/tags/storage/v1.21.0 Bj=C3=B6rn --Sig_/wDeKKh4SGBL=NxJVg=fQze= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCYhQVqgAKCRC/KGy2WT5f /ZkFAJ95cF6s1cJeWpRDWStaIRt/4l+pqACfYTBZk5zVa/zMVkRtlci2Myuj+bA= =KgGG -----END PGP SIGNATURE----- --Sig_/wDeKKh4SGBL=NxJVg=fQze=--