all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home.
@ 2022-02-12 14:38 Florian Pelz
  2022-02-26 15:13 ` bug#53959: " pelzflorian (Florian Pelz)
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Pelz @ 2022-02-12 14:38 UTC (permalink / raw)
  To: 53959

Connman's online check is unreliable for me.

* gnu/installer/connman.scm (connman-online?): Accept if
connman state is ready instead of online.
---
 gnu/installer/connman.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm
index 2f33b58453..6095d99947 100644
--- a/gnu/installer/connman.scm
+++ b/gnu/installer/connman.scm
@@ -287,7 +287,7 @@ (define (connman-disconnect service)
 
 (define (connman-online?)
   (let ((state (connman-state)))
-    (eq? state 'online)))
+    (member state '(ready online))))
 
 (define (connman-connect-with-auth service password-proc)
   "Connect to the given SERVICE with the password returned by calling

base-commit: 5996aab354831d942b10253bc70217a4f2e6a247
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#53959: [PATCH] installer: Continue even if Connman cannot phone home.
  2022-02-12 14:38 [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home Florian Pelz
@ 2022-02-26 15:13 ` pelzflorian (Florian Pelz)
  0 siblings, 0 replies; 2+ messages in thread
From: pelzflorian (Florian Pelz) @ 2022-02-26 15:13 UTC (permalink / raw)
  To: 53959-done

On Sat, Feb 12, 2022 at 03:38:32PM +0100, Florian Pelz wrote:
>  (define (connman-online?)
>    (let ((state (connman-state)))
> -    (eq? state 'online)))
> +    (member state '(ready online))))


Pushed to master as cc11905568065409fe46487174e1cf404291bda1
using memq instead of member.

It will take effect once the guix package is updated.

Regards,
Florian




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-26 15:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-12 14:38 [bug#53959] [PATCH] installer: Continue even if Connman cannot phone home Florian Pelz
2022-02-26 15:13 ` bug#53959: " pelzflorian (Florian Pelz)

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.