bug#53250: icedove clears user data on upgrade

bug#53250: icedove clears user data on upgrade

[Nicholas von Klitzing via Bug reports for GNU Guix]

Hello Guix,

Every time I upgrade icedove (via guix pull && guix system reconfigure), all of my user data is cleared from icedove.

All of my mail settings, accounts, etc. are just gone and I need to manually set them all up again.

When I check ~/.icedove, my profile and settings are still there after the upgrades, but they're not loaded by icedove.

```
nicholas@guix14 ~$ ls .icedove/
dz83arz0.default/  profiles.ini
nicholas@guix14 ~$ cat .icedove/profiles.ini
[Profile0]
Name=default
IsRelative=1
Path=dz83arz0.default
Default=1

[General]
StartWithLastProfile=1
Version=2
```

Kind regards,
Nicholas

bug#53250: icedove clears data

[Nicholas von Klitzing via Bug reports for GNU Guix]

A brief follow up:

It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).

Now looking into ~./thunderbird instead I see several more profiles.

```
nicholas@guix14 ~/.thunderbird$ ls
bv7r86h9.default/            installs.ini               profiles.ini
gdmykixq.default-default-1/  k6sjw3jm.default-default/
nicholas@guix14 ~/.thunderbird$ cat profiles.ini
[Profile2]
Name=default-default-1
IsRelative=1
Path=gdmykixq.default-default-1

[Profile1]
Name=default
IsRelative=1
Path=bv7r86h9.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=k6sjw3jm.default-default

[Install281FC43567D8867D]
Default=gdmykixq.default-default-1
Locked=1

[General]
StartWithLastProfile=1
Version=2

[Install3F4F07DFB18472B1]
Default=k6sjw3jm.default-default
Locked=1
```

Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.

I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.

Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.

Kind regards,
Nicholas

bug#53250: icedove clears data

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
2022 om 12:02 [+0000]:
> A brief follow up:
> 
> It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
> 
> Now looking into ~./thunderbird instead I see several more profiles.
> 
> ```
> nicholas@guix14 ~/.thunderbird$ ls
> bv7r86h9.default/            installs.ini               profiles.ini
> gdmykixq.default-default-1/  k6sjw3jm.default-default/
> nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> [Profile2]
> [...]
> [Profile1]
> [...]
> [Profile0]
> [...]
> [Install281FC43567D8867D]
> [General]
> [...]
> [Install3F4F07DFB18472B1]
> [...]
> ```
> 
> Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
> 
> I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
> 
> Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.

Maybe take a look at the following code in 'icedove':

         ;; Fixes issue where each installation directory generates its
own profile.
         ;; See e.g.
https://trac.torproject.org/projects/tor/ticket/31457
         (add-after 'patch-source-shebangs 'fix-profile-setting
           (lambda _
             (substitute* "comm/mail/moz.configure"
               (("MOZ_DEDICATED_PROFILES, True")
                "MOZ_DEDICATED_PROFILES, False"))
             #t))

Seems like this was fixed at some point but the fix broke?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#53250: icedove clears data

[Nicholas von Klitzing via Bug reports for GNU Guix]

Hi Maxime,

It seems that this issue is describing the new fix that is needed:
https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33734

Only a simple patch would be necessary:
https://gitlab.torproject.org/acat/tor-browser/-/commit/92f480c30178c0847e6866a4115a9393f1d49a28

Kind regards,
Nicholas

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Friday, January 14th, 2022 at 2:52 PM, Maxime Devos <maximedevos@telenet.be> wrote:

> Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
>
> 2022 om 12:02 [+0000]:
>
> > A brief follow up:
> >
> > It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
> >
> > Now looking into ~./thunderbird instead I see several more profiles.
> >
> >     nicholas@guix14 ~/.thunderbird$ ls
> >     bv7r86h9.default/            installs.ini               profiles.ini
> >     gdmykixq.default-default-1/  k6sjw3jm.default-default/
> >     nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> >     [Profile2]
> >     [...]
> >     [Profile1]
> >     [...]
> >     [Profile0]
> >     [...]
> >     [Install281FC43567D8867D]
> >     [General]
> >     [...]
> >     [Install3F4F07DFB18472B1]
> >     [...]
> >
> >
> > Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
> >
> > I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
> >
> > Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.
>
> Maybe take a look at the following code in 'icedove':
>
> ;; Fixes issue where each installation directory generates its
>
> own profile.
>
> ;; See e.g.
>
> https://trac.torproject.org/projects/tor/ticket/31457
>
> (add-after 'patch-source-shebangs 'fix-profile-setting
>
> (lambda _
>
> (substitute* "comm/mail/moz.configure"
>
> (("MOZ_DEDICATED_PROFILES, True")
>
> "MOZ_DEDICATED_PROFILES, False"))
>
> #t))
>
> Seems like this was fixed at some point but the fix broke?
>
> Greetings,
>
> Maxime.

bug#53250: icedove clears data

[Nicholas von Klitzing via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 2644 bytes --]



‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, January 17th, 2022 at 9:44 AM, Nicholas von Klitzing <nicholas@nvk.pm> wrote:

> Hi Maxime,
>
> It seems that this issue is describing the new fix that is needed:
>
> https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33734
>
> Only a simple patch would be necessary:
>
> https://gitlab.torproject.org/acat/tor-browser/-/commit/92f480c30178c0847e6866a4115a9393f1d49a28
>
> Kind regards,
>
> Nicholas
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Friday, January 14th, 2022 at 2:52 PM, Maxime Devos maximedevos@telenet.be wrote:
>
> > Nicholas von Klitzing via Bug reports for GNU Guix schreef op vr 14-01-
> >
> > 2022 om 12:02 [+0000]:
> >
> > > A brief follow up:
> > >
> > > It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
> > >
> > > Now looking into ~./thunderbird instead I see several more profiles.
> > >
> > >     nicholas@guix14 ~/.thunderbird$ ls
> > >     bv7r86h9.default/            installs.ini               profiles.ini
> > >     gdmykixq.default-default-1/  k6sjw3jm.default-default/
> > >     nicholas@guix14 ~/.thunderbird$ cat profiles.ini
> > >     [Profile2]
> > >     [...]
> > >     [Profile1]
> > >     [...]
> > >     [Profile0]
> > >     [...]
> > >     [Install281FC43567D8867D]
> > >     [General]
> > >     [...]
> > >     [Install3F4F07DFB18472B1]
> > >     [...]
> > >
> > >
> > > Launching icedove with `icedove -p` and then iterating through the 3 listed profiles all leads to a blank profile, except for default-default. The default-default profile contains all of my mail account and settings.
> > >
> > > I now set default-default to be my main profile (resolving my issue) but I doubt this is what users expect the software to do.
> > >
> > > Is it possible that icedove creates a new profile on upgrades and sets it as default? I definitely did not manually create 3 profiles.
> >
> > Maybe take a look at the following code in 'icedove':
> >
> > ;; Fixes issue where each installation directory generates its
> >
> > own profile.
> >
> > ;; See e.g.
> >
> > https://trac.torproject.org/projects/tor/ticket/31457
> >
> > (add-after 'patch-source-shebangs 'fix-profile-setting
> >
> > (lambda _
> >
> > (substitute* "comm/mail/moz.configure"
> >
> > (("MOZ_DEDICATED_PROFILES, True")
> >
> > "MOZ_DEDICATED_PROFILES, False"))
> >
> > #t))
> >
> > Seems like this was fixed at some point but the fix broke?
> >
> > Greetings,
> >
> > Maxime.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-icedove-stop-per-install-profile-generation.patch --]
[-- Type: text/x-patch; name=0001-gnu-icedove-stop-per-install-profile-generation.patch, Size: 1016 bytes --]

From 300eb9cc705f4529672f900bd107ba1dc7b69ad5 Mon Sep 17 00:00:00 2001
From: Nicholas von Klitzing <nicholas@nvk.pm>
Date: Mon, 17 Jan 2022 10:46:36 +0100
Subject: [PATCH] gnu: icedove: stop per-install profile generation.

* gnu/packages/gnuzilla.scm (): New variable.
---
 gnu/packages/gnuzilla.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 27a9d099ce..bc7f32131b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1371,8 +1371,8 @@ (define-public icedove
          (add-after 'patch-source-shebangs 'fix-profile-setting
            (lambda _
              (substitute* "comm/mail/moz.configure"
-               (("MOZ_DEDICATED_PROFILES, True")
-                "MOZ_DEDICATED_PROFILES, False"))
+               (("MOZ_NORMANDY, True")
+                "MOZ_NORMANDY, False"))
              #t))
          (add-after 'prepare-thunderbird-sources 'rename-to-icedove
            (lambda _
-- 
2.34.0

bug#53250: icedove clears data

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

Nicholas von Klitzing schreef op ma 17-01-2022 om 09:44 [+0000]:
> It seems that this issue is describing the new fix that is needed:
> https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33734
> 
> Only a simple patch would be necessary:
> https://gitlab.torproject.org/acat/tor-browser/-/commit/92f480c30178c0847e6866a4115a9393f1d49a28
> 

Seems reasonable to me (untested).

Greetings
Maxime (not a committer)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#53250: icedove clears user data on upgrade

[Ludovic Courtès]

Hi,

Nicholas von Klitzing <nicholas@nvk.pm> skribis:

> It seems the ~/.icedove folder is not used by icedove (it was probably a relic of when I used icedove-wayland).
>
> Now looking into ~./thunderbird instead I see several more profiles.

Indeed; when running ‘guix pull’, you might have seen this entry:

  Icedove 91: profile folder moved to @file{~/.thunderbird}

  Icedove 91 expects your profile folder under @file{~/.thunderbird}.
  You need to manually copy your Icedove profiles from @file{~/.icedove} to
  @file{~./thunderbird}.  It may be required to start Icedove with
  @option{--ProfileManager} for the first time after the migration.

HTH,
Ludo’.

bug#53250: icedove clears user data on upgrade

[Jonathan Brielmaier]

Hello Nicholas,

thanks for the patch, I test it right now :)

~Jonathan

bug#53250: [PATCH] gnu: icedove: Stop per-install profile generation.

[Jonathan Brielmaier]

From: Nicholas von Klitzing <nicholas@nvk.pm>

Fixes https://issues.guix.gnu.org/53250

* gnu/packages/gnuzilla.scm (icedove)[arguments]: Disable MOZ_NORMANDY.

Signed-off-by: Jonathan Brielmaier <jonathan.brielmaier@web.de>
---
 gnu/packages/gnuzilla.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index a9b5ed9fe9..929e43d71d 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1372,7 +1372,9 @@ (define-public icedove
            (lambda _
              (substitute* "comm/mail/moz.configure"
                (("MOZ_DEDICATED_PROFILES, True")
-                "MOZ_DEDICATED_PROFILES, False"))
+                 "MOZ_DEDICATED_PROFILES, False")
+               (("MOZ_NORMANDY, True")
+                "MOZ_NORMANDY, False"))
              #t))
          (add-after 'prepare-thunderbird-sources 'rename-to-icedove
            (lambda _
--
2.34.0

bug#53250: icedove clears user data on upgrade

[Jonathan Brielmaier]

I tested your patch, Nicholas, and the one I sent in. But sadly non of
them resolved the problem for me :(

Maybe we should add a service or something to start icedove always with
`icedove -P YOUR-PROFILE-NAME`. As a "dirty" hack...

bug#53250: (No Subject)

[Nicholas von Klitzing via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Hi Jonathan,

Thanks for testing the patch. What exactly doesn't work?

Is icedove still generating new profiles upon install?

Even if it stops generating profiles, you still need to use `icedove -p` to select the correct default.

Kind regards,

Nicholas

[-- Attachment #2: Type: text/html, Size: 452 bytes --]

bug#53250: icedove clears user data on upgrade

[Maxim Cournoyer]

Hi,

Nicholas von Klitzing <nicholas@nvk.pm> writes:

> Hi Jonathan,
>
> Thanks for testing the patch. What exactly doesn't work?
>
> Is icedove still generating new profiles upon install?
>
> Even if it stops generating profiles, you still need to use `icedove -p` to select the correct default.

I believe the reason it wasn't working was because the substitution of
the MOZ_DEDICATED_PROFILES value to False was not effective:

I believe this should fix it:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/gnuzilla.scm
@@ -1335,8 +1335,8 @@ (define-public icedove-minimal
           (add-after 'patch-source-shebangs 'fix-profile-setting
             (lambda _
               (substitute* "comm/mail/moz.configure"
-                (("MOZ_DEDICATED_PROFILES, True")
-                 "MOZ_DEDICATED_PROFILES, False"))))
+                (("\"MOZ_DEDICATED_PROFILES\", True")
+                 "\"MOZ_DEDICATED_PROFILES\", False"))))
           (add-after 'build 'neutralize-store-references
             (lambda _
               ;; Mangle the store references to compilers & other build tools in
--8<---------------cut here---------------end--------------->8---

Pushed to master as c81d2d448c, after testing resolution on an affected
machine.

Closing!

-- 
Thanks,
Maxim