From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SNFHMAt7mGG00QAAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 05:35:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0LcuKwt7mGEORAAAB5/wlQ (envelope-from ) for ; Sat, 20 Nov 2021 04:35:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF3342FB35 for ; Sat, 20 Nov 2021 05:35:22 +0100 (CET) Received: from localhost ([::1]:34496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moI5x-0002J9-VM for larch@yhetil.org; Fri, 19 Nov 2021 23:35:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moI5f-0002Ii-3U for guix-patches@gnu.org; Fri, 19 Nov 2021 23:35:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moI5e-0007OH-7x for guix-patches@gnu.org; Fri, 19 Nov 2021 23:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moI5e-0007wm-1c; Fri, 19 Nov 2021 23:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v2 01/26] gnu: node: Avoid duplicating build phases. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 04:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51838@debbugs.gnu.org Cc: Liliana Marie Prikler X-Debbugs-Original-Xcc: Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163738285530187 (code B ref 51838); Sat, 20 Nov 2021 04:35:01 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 04:34:15 +0000 Received: from localhost ([127.0.0.1]:41161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moI4s-0007qo-UF for submit@debbugs.gnu.org; Fri, 19 Nov 2021 23:34:15 -0500 Received: from mail-qk1-f182.google.com ([209.85.222.182]:47102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moI4r-0007qU-KP for 51838@debbugs.gnu.org; Fri, 19 Nov 2021 23:34:14 -0500 Received: by mail-qk1-f182.google.com with SMTP id a11so12320990qkh.13 for <51838@debbugs.gnu.org>; Fri, 19 Nov 2021 20:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=KH4RQSW2Vl/+hSZ71LTsM4xePvjwFAevZ9cxlfrinCQ=; b=GwjefNglQClkVKWybgbEMQ0rhHnxlW1J7Nn2HXt5dPNZ+8NztORJQvfaYuKhgfuilN brEmAgK9/WEaUTfBJXIVrZ4Sog08de/xxB+qTtFIBYFBBPefEytBSlBHBwbOuwFSlnxa GTptNYvq6C/ig6961X+/hYa/gefKUNkP82SQayn8I28LA7XBH4cVu5HvgtXFHx4j1TZF ZtfvxyGCDk42zT8aUh7lm4cOTwif8BAstKsqqE/ciE6NWudNoJ2+h1m/UGSHOCP4MWjF 9lcBUPW0u+uh/6o4Xx2r9EKe8FIhjn6LuJVf5TUok+ndr+ljSKpkboVHH7n0Pjs8PnRW 5RJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KH4RQSW2Vl/+hSZ71LTsM4xePvjwFAevZ9cxlfrinCQ=; b=N/lzPKhtr+71ll/vJW99LbIoRbwgDCPRAxxCnkfgRTbBt5vje/lgJckM2F2mFOu3L0 ub5aftQr8i9wkrDEQpWt9uSdcrKnqmfNWLeU+FD8W6+8PahVvAZ9yQyykHoXQI3NK4yG YC27J946Tqnt9f/LE+FMMttCxEEudDf3zRx2eAS1U4dtcchLgi/ixMrTqvYr6w/bnYkq XC9FHiCJ2reG3TWhRysSbSznACnWKB1ndtyHtkHiIJ1KsNY1ZKkfd/IFbTNigviKoD14 aZxyGGI3HmCdpmOW1ZqjB8mPzNZfG8O0gRmXpibmS6Rt1dzcVhiKdhnMvNPF6AYKE0Ll 1v8w== X-Gm-Message-State: AOAM533oLoRetVZ9f7WoFCjmWswPuT/O4hfietKrSFM2cts6QeHgRpWx IyGeO4tEJ/m2Swh4ueLYZplPXwt5zO8uh66g X-Google-Smtp-Source: ABdhPJzt5m/NcaMytJewB1QWw47WHGoYL33zPtdWYnZAm7OG3KwFN8f7IDw3kR1dde1TjcAUsKhPmw== X-Received: by 2002:a37:9cf:: with SMTP id 198mr32983015qkj.308.1637382847785; Fri, 19 Nov 2021 20:34:07 -0800 (PST) Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id r20sm1059262qkp.21.2021.11.19.20.34.07 for <51838@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 20:34:07 -0800 (PST) From: Philip McGrath Date: Fri, 19 Nov 2021 23:33:41 -0500 Message-Id: <20211120043406.952350-1-philip@philipmcgrath.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637382922; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KH4RQSW2Vl/+hSZ71LTsM4xePvjwFAevZ9cxlfrinCQ=; b=ZqkuiyiWQZ9SM0fx7pSf/nmzhE/6DHRnl7wcfHyrKY85AnWZKdj7YesDU1GmXZchgAewnJ hgyq+bXqa4E+Y7XRyLCu2GwpHiD+77vpYuEoNfyWgAIttuo1gx90xdFZwktdMbPtdyRrkz RkF8uwlq11oilBFRKpGJ2I77HAMOmNTH4NLFHzQEkIv/Pb+f0IzdXVFPidsJ8vD9nZoHwb hS5ygl00okgxFNOKoggKiKEPRqH15OVrrszRGhNyepAd3oXobYBI5YQtZ4EAy8KyjYk+g9 ohpN9c17i8BaAkvE/kTfFqg9f44HIThNNIcAxQsEJ4sQLDVjSnQ/94ZKEVAv5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637382922; a=rsa-sha256; cv=none; b=NuJiLViKfVeskm16d68s9ToQLhFXTNpmu2nCIlnhe6gCC+XHYZ8ULlDIDJCI5hvX/55bxn qGNaxnzRmUEoaqFqtdWS5wyi4CBrS2IJjFW81fbMmhlRwBjpCW32dtAQ4JwComx6i2U9sv 8VGqq5Eewh3sQdTxim3s8RgUDAMuSBs7+spa86F+CILwnME/4KOSEta+Jv/JdMBfPqeMkr 04235hBQYtZho39ZEZtcHdkp3i0vatSiITjHARtVuqsvo9yTIRpVM5UqaaqT91i757xaqo EuSDH4/v+qDRzpYe8RnSnLJlFAf4xaEUJ/R5nXEf6NRFv+fKDG2t2UHuok0HpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=GwjefNgl; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=GwjefNgl; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CF3342FB35 X-Spam-Score: -0.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: es+t+2LIXmBf * gnu/packages/node.scm (node)[arguments]: Split 'patch-files phase into 'patch-hardcoded-program-references and 'delete-problematic-tests. Adapt 'patch-hardcoded-program-references and 'configure to work unmodified on node-lts, but don't try to share 'delete-problematic-tests, because those details seem to change too much between node versions. (node, node-lts)[inputs]: Use bash-minimal rather than bash. (node-lts)[arguments]: Inherit 'patch-hardcoded-program-references, and 'configure phases from the bootstrap node. Remove the 'patch-files phase, keeping its remaining non-inherited work in a new 'replace-llhttp-sources phase. --- gnu/packages/node.scm | 105 +++++++++++++----------------------------- 1 file changed, 32 insertions(+), 73 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index dccf871d2c..7ebbbc3060 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2020, 2021 Pierre Langlois ;;; Copyright © 2020 Ricardo Wurmus ;;; Copyright © 2021 Simon Tournier +;;; Copyright © 2021 Philip McGrath ;;; ;;; This file is part of GNU Guix. ;;; @@ -105,14 +106,22 @@ (define-public node #:test-target "test-ci-js" #:phases (modify-phases %standard-phases - (add-before 'configure 'patch-files + (add-before 'configure 'patch-hardcoded-program-references (lambda* (#:key inputs #:allow-other-keys) + ;; Fix hardcoded /bin/sh references. - (substitute* '("lib/child_process.js" - "lib/internal/v8_prof_polyfill.js" - "test/parallel/test-child-process-spawnsync-shell.js" - "test/parallel/test-stdio-closed.js" - "test/sequential/test-child-process-emfile.js") + (substitute* + (let ((common + '("lib/child_process.js" + "lib/internal/v8_prof_polyfill.js" + "test/parallel/test-child-process-spawnsync-shell.js" + "test/parallel/test-stdio-closed.js" + "test/sequential/test-child-process-emfile.js")) + ;; not in bootstap node: + (sigxfsz "test/parallel/test-fs-write-sigxfsz.js")) + (if (file-exists? sigxfsz) + (cons sigxfsz common) + common)) (("'/bin/sh'") (string-append "'" (assoc-ref inputs "bash") "/bin/sh'"))) @@ -122,7 +131,10 @@ (define-public node "test/parallel/test-child-process-exec-env.js") (("'/usr/bin/env'") (string-append "'" (assoc-ref inputs "coreutils") - "/bin/env'"))) + "/bin/env'"))))) + (add-after 'patch-hardcoded-program-references + 'delete-problematic-tests + (lambda* (#:key inputs #:allow-other-keys) ;; FIXME: These tests fail in the build container, but they don't ;; seem to be indicative of real problems in practice. @@ -217,9 +229,13 @@ (define-public node (setenv "CXX" ,(cxx-for-target)) (setenv "PKG_CONFIG" ,(pkg-config-for-target)) (apply invoke - (string-append (assoc-ref (or native-inputs inputs) - "python") - "/bin/python") + (let ((python + (string-append (assoc-ref (or native-inputs inputs) + "python") + "/bin/python"))) + (if (file-exists? python) + python + (string-append python "3"))) "configure" flags)))) (add-after 'patch-shebangs 'patch-npm-shebang (lambda* (#:key outputs #:allow-other-keys) @@ -256,7 +272,7 @@ (define-public node (variable "NODE_PATH") (files '("lib/node_modules"))))) (inputs - `(("bash" ,bash) + `(("bash" ,bash-minimal) ("coreutils" ,coreutils) ("c-ares" ,c-ares) ("http-parser" ,http-parser) @@ -712,66 +728,8 @@ (define-public node-lts libuv "/lib:" zlib "/lib" "'],")))))) - (replace 'configure - ;; Node's configure script is actually a python script, so we can't - ;; run it with bash. - (lambda* (#:key outputs (configure-flags '()) native-inputs inputs - #:allow-other-keys) - (let* ((prefix (assoc-ref outputs "out")) - (xflags ,(if (%current-target-system) - `'("--cross-compiling" - ,(string-append - "--dest-cpu=" - (match (%current-target-system) - ((? (cut string-prefix? "arm" <>)) - "arm") - ((? (cut string-prefix? "aarch64" <>)) - "arm64") - ((? (cut string-prefix? "i686" <>)) - "ia32") - ((? (cut string-prefix? "x86_64" <>)) - "x64") - ((? (cut string-prefix? "powerpc64" <>)) - "ppc64") - (_ "unsupported")))) - ''())) - (flags (cons - (string-append "--prefix=" prefix) - (append xflags configure-flags)))) - (format #t "build directory: ~s~%" (getcwd)) - (format #t "configure flags: ~s~%" flags) - ;; Node's configure script expects the CC environment variable to - ;; be set. - (setenv "CC_host" "gcc") - (setenv "CXX_host" "g++") - (setenv "CC" ,(cc-for-target)) - (setenv "CXX" ,(cxx-for-target)) - (setenv "PKG_CONFIG" ,(pkg-config-for-target)) - (apply invoke - (string-append (assoc-ref (or native-inputs inputs) - "python") - "/bin/python3") - "configure" flags)))) - (replace 'patch-files + (replace 'delete-problematic-tests (lambda* (#:key inputs #:allow-other-keys) - ;; Fix hardcoded /bin/sh references. - (substitute* '("lib/child_process.js" - "lib/internal/v8_prof_polyfill.js" - "test/parallel/test-child-process-spawnsync-shell.js" - "test/parallel/test-fs-write-sigxfsz.js" - "test/parallel/test-stdio-closed.js" - "test/sequential/test-child-process-emfile.js") - (("'/bin/sh'") - (string-append "'" (assoc-ref inputs "bash") "/bin/sh'"))) - - ;; Fix hardcoded /usr/bin/env references. - (substitute* '("test/parallel/test-child-process-default-options.js" - "test/parallel/test-child-process-env.js" - "test/parallel/test-child-process-exec-env.js") - (("'/usr/bin/env'") - (string-append "'" (assoc-ref inputs "coreutils") - "/bin/env'"))) - ;; FIXME: These tests fail in the build container, but they don't ;; seem to be indicative of real problems in practice. (for-each delete-file @@ -810,8 +768,9 @@ (define-public node-lts ;; TODO: Regenerate certs instead. (for-each delete-file '("test/parallel/test-tls-passphrase.js" - "test/parallel/test-tls-server-verify.js")) - + "test/parallel/test-tls-server-verify.js")))) + (add-after 'delete-problematic-tests 'replace-llhttp-sources + (lambda* (#:key inputs #:allow-other-keys) ;; Replace pre-generated llhttp sources (let ((llhttp (assoc-ref inputs "llhttp"))) (copy-file (string-append llhttp "/src/llhttp.c") @@ -838,7 +797,7 @@ (define-public node-lts ("python" ,python) ("util-linux" ,util-linux))) (inputs - `(("bash" ,bash) + `(("bash" ,bash-minimal) ("coreutils" ,coreutils) ("c-ares" ,c-ares-for-node) ("icu4c" ,icu4c-67) -- 2.32.0