From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id INYMFkpciWHcRwEAgWs5BA (envelope-from ) for ; Mon, 08 Nov 2021 18:20:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ECu9EUpciWHIHQAA1q6Kng (envelope-from ) for ; Mon, 08 Nov 2021 17:20:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BFFC21FB7 for ; Mon, 8 Nov 2021 18:20:09 +0100 (CET) Received: from localhost ([::1]:58974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mk8JU-0001PK-Fb for larch@yhetil.org; Mon, 08 Nov 2021 12:20:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk8JO-0001PB-MB for guix-patches@gnu.org; Mon, 08 Nov 2021 12:20:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mk8JO-0000rU-CZ for guix-patches@gnu.org; Mon, 08 Nov 2021 12:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mk8JO-00047G-90 for guix-patches@gnu.org; Mon, 08 Nov 2021 12:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51538] First Patch Submit Ever: Additions to the Cookbook Documentation Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Nov 2021 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51538 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Disseminate Dissent Cc: 51538@debbugs.gnu.org Received: via spool by 51538-submit@debbugs.gnu.org id=B51538.163639194515739 (code B ref 51538); Mon, 08 Nov 2021 17:20:02 +0000 Received: (at 51538) by debbugs.gnu.org; 8 Nov 2021 17:19:05 +0000 Received: from localhost ([127.0.0.1]:59301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk8IT-00045m-FZ for submit@debbugs.gnu.org; Mon, 08 Nov 2021 12:19:05 -0500 Received: from pelzflorian.de ([5.45.111.108]:58076 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk8IP-00045J-Hb for 51538@debbugs.gnu.org; Mon, 08 Nov 2021 12:19:03 -0500 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 5D8473606B4; Mon, 8 Nov 2021 18:18:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1636391939; bh=a8t13jMyhpF6s316CAs3tqTMJ07UxwDRDAlSUW/3Chs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=uR1L5rnKSw9iE+PPTw5FFX0ZpExW9ZOSV9vSu9Dty5Yma4cePZ75yi5K3Nz0GXEYu jHpn9PFteemkPlBg//lCyEuRIlo8hBSc4OpTU7aTgyu3BGnRacoCktsuBjFwKQs1KJ DPA5Sn1kuzbgkbzau0/ETPTidW7zak4YwFtD50Ts= Date: Mon, 8 Nov 2021 18:18:50 +0100 From: "pelzflorian (Florian Pelz)" Message-ID: <20211108171850.q6pqyiv4g5q2oktr@pelzflorian.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636392009; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cyY6t83GnN8aE5KAmw8F7utTYcN8s/ytGVDxUWG1AyI=; b=R78fP7KOV1VJezzzpJ9nPvdQYT+3svaKusc7vyr0jV6D6wGK8LirN64oqRD2DE6h5Iyj6r oEzh8BFcu0Ad/tjTNxULucnNxUwDk9A0RqzEumAJaGe4+EqIF5uF3QGEtUHmAp4SC9NWK2 iit78FRA0cPhWKgHYc7YisPRNWeBtdXex+AsGDGX6O42jceciccD2H9WKk2/+8hTBSob75 lJnK5x1XEjV2hoaGAkQ4B76iPcXFUdWvNx8hcvBS7ciNRHtjHY+66SoRD3OwwuBnuFmPi8 udhG3BQ94dLLKHKi19iSaIwX3rO+FyuJVAoXjM2zOEEmx1m8SXKdOI8+B10ULw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636392009; a=rsa-sha256; cv=none; b=o8IJddiRrPT6G0hmglm4Nhlqx53UIdXsxu8/J6QsU2tqDh6IP4SQgzgSGXMo6I6fl8ZgAm IRstWOixr08FsB4yV5bdE2jDl9A4eV3NH5Ddb+pq91XsBFis7y6oJpGrVwVR/Xe/KRjGPE GxCXIW6w1Bx3nkEp1r61n3TguSSPNH0wSdQEbmSyYvVcBxciUdfCwwxafrf8+N8dz4ic85 1L8goXEl3Lpu3Bd9uZKD/6mdlfp3/nPnYXz7B63bhpkaOtvv59/Q+p3sOzjHomlYySgGp3 RIteOlJMndF/VMP9Y/oc4M3SHAlGVFb6pkFTRXkU36OhkTo/MjmTFU8Q1k6ceA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=uR1L5rnK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=uR1L5rnK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5BFFC21FB7 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: g01nYVhpSWsa Disseminate, thank you for your work. On Mon, Nov 08, 2021 at 01:48:39PM +0000, Disseminate Dissent wrote: > Thanks for the comments Florian, > > Added periods and removed whitespace. > > In my initial Guix setup I was unable to clear the terminal with > neither `clear` nor C-l. Installing ncurses solved that issue and is > listed as a dependency for GNU Readline. Bash always enables readline as far as I can see. Perhaps you used a system that disabled C-l in the ~/.inputrc file, which would also disable it for a Guix-installed bash? Some Slackware users complain about non-working C-l on stackoverflow. Anyway I will leave this patch for experienced guix commiters to decide; IMHO the clear command should not be needed with Guix and the cookbook so far contains only what can be done with Guix itself. Even though I like the idea of a FAQ section and am happy about new Guix contributors such as you. As for the patch: On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-patches via wrote: > Corrected missing periods and whitespace. > You have not addressed this latter passive Added instead of Add: On Mon, Nov 08, 2021 at 10:29:00AM +0100, pelzflorian (Florian Pelz) wrote: > For the commit message, Guix uses the active voice “Add a FAQ section > with …”. > > > > * doc/guix-cookbook.texi: Added FAQ section. > > Here too. Then: On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-patches via wrote: > @menu > * Scheme tutorials:: Meet your new favorite language! > -* Packaging:: Packaging tutorials > -* System Configuration:: Customizing the GNU System > +* Packaging:: Packaging tutorials. > +* System Configuration:: Customizing the GNU System. > * Advanced package management:: Power to the users! > -* Environment management:: Control environment > +* Environment management:: Control environment. > +* FAQ:: Commonly asked questions. Your commit should only add the period to your sentence; other sentences should remain untouched (fixing them belongs in a separate commit). I should fix such things myself in other commits; probably I won’t do it. Other than that, it is a nicely written patch. It seems the issue when running the commands from `info "(guix)Building from Git"` is that the other menu > +@menu > +* How do I clear my terminal screen? > +@end menu does not contain double colons followed by a sentence like the other @menu. Regards, Florian