From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aKl5JHiXeGEvdgEAgWs5BA (envelope-from ) for ; Wed, 27 Oct 2021 02:04:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8AMeIHiXeGFFdQAAB5/wlQ (envelope-from ) for ; Wed, 27 Oct 2021 00:04:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D37F516C61 for ; Wed, 27 Oct 2021 02:04:07 +0200 (CEST) Received: from localhost ([::1]:56750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfWQI-0006se-Va for larch@yhetil.org; Tue, 26 Oct 2021 20:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfWQE-0006r0-KP for guix-patches@gnu.org; Tue, 26 Oct 2021 20:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfWQE-0003l4-8X for guix-patches@gnu.org; Tue, 26 Oct 2021 20:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfWQE-0005E1-2s for guix-patches@gnu.org; Tue, 26 Oct 2021 20:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51113] bug#51424: snooze: malformed installation path Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Oct 2021 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51113 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: Christopher Howard , 51113@debbugs.gnu.org, 51424-done@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 51113-submit@debbugs.gnu.org id=B51113.163529301620051 (code B ref 51113); Wed, 27 Oct 2021 00:04:02 +0000 Received: (at 51113) by debbugs.gnu.org; 27 Oct 2021 00:03:36 +0000 Received: from localhost ([127.0.0.1]:47928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfWPo-0005DF-Ba for submit@debbugs.gnu.org; Tue, 26 Oct 2021 20:03:36 -0400 Received: from mx1.dismail.de ([78.46.223.134]:6322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfWPm-0005Ct-5G; Tue, 26 Oct 2021 20:03:35 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 92cf1404; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=LaNT1AWOrQFwX4QL6x3IsVKagjr2M89hyGKoPRn8/ts=; b=Ai4 CTfwEQx+086mgjDrkMENL+uBKHQdrUFGWnS3g0qYrxOfAtxC0ebnn1iaxkor2kPJ YdqML0WgEUeBDXQ/EjAh8sZcEcajA7rU3polVJ8qOjdZc8PeAFH1c9DqsySYyFa4 MOE1e1l0oviR77nCGP8d55ZB5as4vE92DbKb71fUCFLCxZQ72CrcSBykVUDcpz4c IeidW3G3SsjUNy6Ynnh3jU2KJRvbttVeCZvfyDbZ8Kc2McmWzwEH8cQTiS9TBWrY 6LpSLcxQXvfP9CuC3cZxv8DEFF8H2HRjQgc3iUpERxbr/p6RQ6KhnipLPxFHavyJ pMQZhT2JxH4JaD86xBg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 45e62a3a; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id dd6b5e45; Wed, 27 Oct 2021 02:03:26 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id a418518c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 27 Oct 2021 02:03:25 +0200 (CEST) Date: Tue, 26 Oct 2021 20:03:22 -0400 Message-ID: <20211026200322.GB9051@gac.attlocal.net> In-Reply-To: <87a6ivl8u0.fsf@nckx> References: <87a6ivl8u0.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635293048; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=S8ziizmDgTAb6lEB3vnPleLKHb80WEnYPP282GLJV1w=; b=Q/7OvjpsbINrwFqg3BSmboW8bnBlYPLQy5oR+KhB4lJxOKG/dySWEzzQgJezX8wHrBUW7b vnPVK+8Rbg1bcEa3pdsoW9d9hfMH3E4Z0lCndiaKGKhXF4i4nAxDWxk4xE7JFaUcpggV0r 3wANl09D3V7H/Jfd5EvCh6k04KehfjXJ79zVwKE+eQm+cbmjaGBfKiEpddsnazQAoB/LXM VZG2pDX4a/TNImC3FdYo8gR4NgIUU0jz5JBta2lqLzavVf/v9OAUmJBgmUM3dsYh2JL5xh PcsaYDqkitXBGbERXWOZr3SGRe2bjlstZu7Ro71wMjVMyqSWgHkpzt/n9PJ+gw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635293048; a=rsa-sha256; cv=none; b=IkO+4tClFMkH0+9iP6dExPb67Nr13X+btq0X9DV8543jS9vWzTlZnS9bKRAB+S4nH16qSC laKQXrOx9+YCv3TTzjF/CjKL+Sq42htdxLQYEXaFMCKfqGvTREkFk0I4p4ZFUJ2MNWdO9c Egt28MYfNfMSHoEONsc58og4it52HIPBgD9vtFXKWfKjTX778IqPeYg9qrV1+WwRFQ1HsF uAc0sVo9d0dAd4IYaLXUKnxwF9EP1yb6qh07VElQheY7ky3HtpRRFZnxjyYgNTA1xW45ZJ F0WwOiBiYKeBVKy5GG/SmuT+Q3oFYts8P/0Z34yQK0xYjBgSbB50hI2nnudImA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="Ai4 CTfw"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b="Ai4 CTfw"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D37F516C61 X-Spam-Score: -1.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: OIHUn1laU+nA On Wed, 27 Oct 2021 00:13:47 +0200 Tobias Geerinckx-Rice wrote: > Christopher, jgart, Nicolas, > > Christopher Howard 写道： > > the path to the binary is malformed: > > Indeed it was. > > DESTDIR does not mean ‘final destination’; it's meant as a > temporary install-time ‘staging’ directory whose contents are > expected to move back to / later. For example, ‘make install > DESTDIR=/tmp/my-package-manager-output && cd > /tmp/my-package-manager-output && tar cf foo.pkg .’. Guix does > not use this packaging method. > > Setting DESTDIR in Guix is almost always a bug. The few places in > Guix where it is used are using it as a hack around buggy build > systems. It just happens to work (because, well, the build > system's buggy). > > Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add. > > Thanks! > > T G-R > When reviewing patches, I find the ‘tree’ command very useful to > immediately spot such weirdness. Much more so than ‘ls -R’. > YMMV. I use nnn or another file manager like broot sometimes but this one escaped me. Thanks for fixing that. I was actually going to send a patch fix for it but had not found the time. I noticed it after the patch was accepted. Thanks! all best, jgart