From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6NvILFawZWHAOQAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 17:57:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yFdsKFawZWEwWQAA1q6Kng (envelope-from ) for ; Tue, 12 Oct 2021 15:57:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 406BB37394 for ; Tue, 12 Oct 2021 17:57:10 +0200 (CEST) Received: from localhost ([::1]:43552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maK9N-0000ji-CI for larch@yhetil.org; Tue, 12 Oct 2021 11:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maK9G-0000j4-UJ for guix-patches@gnu.org; Tue, 12 Oct 2021 11:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maK9G-0005wN-LF for guix-patches@gnu.org; Tue, 12 Oct 2021 11:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maK9G-0002Pq-Kr for guix-patches@gnu.org; Tue, 12 Oct 2021 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51122] [PATCH v2] maint: Factorize po xref translation. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Oct 2021 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51122 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51122@debbugs.gnu.org Received: via spool by 51122-submit@debbugs.gnu.org id=B51122.16340541899205 (code B ref 51122); Tue, 12 Oct 2021 15:57:02 +0000 Received: (at 51122) by debbugs.gnu.org; 12 Oct 2021 15:56:29 +0000 Received: from localhost ([127.0.0.1]:49950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maK8j-0002OO-A3 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 11:56:29 -0400 Received: from pelzflorian.de ([5.45.111.108]:34350 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maK8f-0002Nj-3e for 51122@debbugs.gnu.org; Tue, 12 Oct 2021 11:56:26 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 9B0DF36069D; Tue, 12 Oct 2021 17:56:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1634054183; bh=m3uKSkemHoliD6oJwNh/bD/xwVghudLLvkMCYHasgNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=B7mBtayKAJMpl+FaSPCSNf2uPke17X7IE7j4CS/rx0HasVMXDGKhnyuEaue1fOv5/ MKECnQpTr2TzeWdr8XlzvcUPEAz0w6fbGyWcds32jrny3anC649FP8ac/RLamAeKU6 c4ImdZ4mICwdzHGNffTdQuw87nZKJSbeCW6HgUzQ= Date: Tue, 12 Oct 2021 17:56:11 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20211012155611.vbhkyxjmqlc3ja77@pelzflorian.localdomain> References: <8a210e8ceaadfa600e60b0b97a1e7aba04b2bb02.1633901513.git.julien@lepiller.eu> <20211010233711.23bb1e9e@tachikoma.lepiller.eu> <20211011082415.j6wera4b5t4mtnxa@pelzflorian.localdomain> <20211011144626.0049af43@tachikoma.lepiller.eu> <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> <20211012000657.11daa7a3@tachikoma.lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211012000657.11daa7a3@tachikoma.lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634054230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SvwC4VuDWfiYaVG/Yb7o5//g3+JE/aPL26BD6fyAhSM=; b=aNrI9ljVzdmbJXUJIA/oUUxdnndgPo2yLBmlpP9o4Ymw/V1f05UQSky3BZNLqTVB1QdqAV 9+zrHYYuRXiHPKV295CnfYomZn4L+WkAZNfH1Cx7JuXGC0nLgUvTEe0aWrK7DvJI37FRPh neJ7tPIo7cwkZNaZlP1miOJv9gYgV15Bm/qNjiJ9ogh3t6dnvyDnxiKse+BX1n4wY2FjnR +9N+NVggloA3FqPUjNS8sidkOd935Vd/Y6nkav/pWdsTemFrAKC/Wp8ZwPOQV6J+E24Z2u A+04BQACK2Gqa2bWl3Bzm6WXSLiriaszqb6wQMX+DVm7ibvRUoZMl+z3WI/HKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634054230; a=rsa-sha256; cv=none; b=RHl6rPzKH8k18I5QSG0tfTscXXSUHP07PKfXO0u7OZZaUCLfzThBTHForl+bpjLRYcdL/n pN9uRwUvu5pzp1kG6Hkg/JEd/kF/SntwKcc9BNvUzTnttgdYnbrHNI+xdsNk3Y7WmD6qom afRAnBdnlHuACRDbiG1hb8s5WBRV2odJyv0kvbSzxkh9Rp1zl6WCyP5vKyK06JRT+djEe2 a0jw/6qz6nKPR8BHt2sWMIperYfbRi/JwIyM3SI31FZMe5OBLph0W0t6uZ9Q+5RjAHiL9J 1AM3Ckw8iyvWlZ8cN0auH8kRzQCxoHZp263g0i8liRVGzag7QzuOMF/PVu4zGw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=B7mBtayK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=B7mBtayK; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 406BB37394 X-Spam-Score: -1.81 X-Migadu-Scanner: scn1.migadu.com X-TUID: hkFose/jNfgl On Tue, Oct 12, 2021 at 12:06:57AM +0200, Julien Lepiller wrote: > Le Mon, 11 Oct 2021 19:17:28 +0200, > "pelzflorian (Florian Pelz)" a écrit : > > Also POXREF is run twice for each > > guix.??.texi file. Maybe I did something wrong, maybe it is your > > patch. Not sure. Testing takes long anyway. > It only runs it once here, but there are three files to translate: > guix.xx.texi, guix-cookbook.xx.texi and contributing.xx.texi. At least when depending on make-core-go instead of make-go, it does POXREF each file twice, in between printing “Updating doc/version.texi”. Anyway, this is more important: > It looks like depending on make-go or make-core-go means we rebuild the > texi files everytime we run "make", so that's not great :/. We definitely want to compile guix/build/po.scm, I think, because it should be run each time a guix-manual.LL.po or guix-cookbook.LL.po file changes. GNU Make manual says : > A phony target should not be a prerequisite of a real target file; if > it is, its recipe will be run every time make goes to update that > file. But Makefile.am defines guile-compilation-rule to create a Phony target. This is bad for us because likely there should not be duplicate code to compile guix/build/po.scm and to compile the rest. So I presume part of guile-compilation-rule must be split off? Regards, Florian