From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 51122@debbugs.gnu.org
Subject: [bug#51122] [PATCH v2] maint: Factorize po xref translation.
Date: Mon, 11 Oct 2021 19:17:28 +0200 [thread overview]
Message-ID: <20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain> (raw)
In-Reply-To: <20211011144626.0049af43@tachikoma.lepiller.eu>
Thanks Julien!
On Mon, Oct 11, 2021 at 02:46:26PM +0200, Julien Lepiller wrote:
> Thanks for the quick review! I've updated the commit message and
> updated the copyright headers in guix/build/po.scm and guix/self.scm.
In guix/self.scm you only removed code. I don’t think a copyright
header is needed there.
> I had to make the texi files depend on make-go because otherwise, I get
> messages like "guix/build/po.scm is newer than compiled
> .../guix/build/po.go" and it takes forever to build that file, once for
> each texi. For some reason, it's almost instantaneous when building in
> make-go.
make-core-go instead of make-go is enough in my testing, but something
more fine-grained would save time. Also POXREF is run twice for each
guix.??.texi file. Maybe I did something wrong, maybe it is your
patch. Not sure. Testing takes long anyway.
Regards,
Florian
next prev parent reply other threads:[~2021-10-11 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 21:32 [bug#51122] [PATCH] maint: Factorize po xref translation Julien Lepiller
2021-10-10 21:37 ` Julien Lepiller
2021-10-11 8:45 ` pelzflorian (Florian Pelz)
2021-10-11 12:46 ` [bug#51122] [PATCH v2] " Julien Lepiller
2021-10-11 17:17 ` pelzflorian (Florian Pelz) [this message]
2021-10-11 22:06 ` Julien Lepiller
2021-10-12 15:56 ` pelzflorian (Florian Pelz)
2021-10-12 18:09 ` pelzflorian (Florian Pelz)
2021-10-12 19:25 ` Julien Lepiller
2021-10-16 2:12 ` Julien Lepiller
2021-10-16 18:45 ` pelzflorian (Florian Pelz)
2021-10-17 20:12 ` bug#51122: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011171603.3m7spi6bwlhpgjiv@pelzflorian.localdomain \
--to=pelzflorian@pelzflorian.de \
--cc=51122@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.