* [bug#50796] [PATCH] gnu: Add pn.
@ 2021-09-25 3:28 Antero Mejr via Guix-patches via
2021-09-28 18:59 ` [bug#50873] " Xinglu Chen
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Antero Mejr via Guix-patches via @ 2021-09-25 3:28 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
* gnu/packages/telephony.scm (pn): New variable.
---
Add pn and its dependencies.
It's a phone number CLI tool used by Linux phone GUIs like SXMO.
gnu/packages/telephony.scm | 72 ++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 48bbe12920..9015cf536a 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -54,12 +55,14 @@
#:use-module (gnu packages documentation)
#:use-module (gnu packages file)
#:use-module (gnu packages protobuf)
+ #:use-module (gnu packages gawk)
#:use-module (gnu packages gettext)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages gtk)
+ #:use-module (gnu packages icu4c)
#:use-module (gnu packages image)
#:use-module (gnu packages libcanberra)
#:use-module (gnu packages linphone)
@@ -907,3 +910,72 @@ Initiation Protocol (SIP) and a multimedia framework.")
telephony functionality into custom Telegram clients.")
(home-page "https://github.com/zevlg/libtgvoip")
(license license:unlicense)))
+
+(define-public libphonenumber
+ (package
+ (name "libphonenumber")
+ (version "8.12.33")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/google/libphonenumber")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'enter-dir
+ (lambda _ (chdir "cpp") #t)))))
+ (inputs
+ `(("boost" ,boost)
+ ("googletest" ,googletest)
+ ("protobuf" ,protobuf)
+ ("icu4c" ,icu4c)))
+ (home-page "https://github.com/google/libphonenumber")
+ (synopsis "C++ library for phone number parsing")
+ (description
+ "libphonenumber is Google's common Java, C++ and JavaScript library for
+parsing, formatting, and validating international phone numbers.")
+ (license license:asl2.0)))
+
+(define-public pn
+ (package
+ (name "pn")
+ (version "0.9.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Orange-OpenSource/pn")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'sub-bin-path
+ (lambda _
+ (substitute* "CMakeLists.txt" (("DESTINATION \\$\\{AWKLIBPATH\\}")
+ "DESTINATION bin")))))))
+ (inputs
+ `(("libphonenumber" ,libphonenumber)
+ ("icu4c" ,icu4c)
+ ("protobuf" ,protobuf)
+ ("gawk" ,gawk)))
+ (home-page "https://github.com/Orange-OpenSource/pn")
+ (synopsis "Command-line validation tool for phone numbers")
+ (description
+ "pn is a tool that allows command line user/programmers to operate on
+phone numbers (get validity information, reformat them, or extract numbers
+from a text snippet), using libphonenumber.")
+ (license license:asl2.0)))
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#50873] [bug#50796] [PATCH] gnu: Add pn.
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
@ 2021-09-28 18:59 ` Xinglu Chen
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
2 siblings, 0 replies; 9+ messages in thread
From: Xinglu Chen @ 2021-09-28 18:59 UTC (permalink / raw)
To: 50873; +Cc: Antero Mejr, Ludovic Courtès, Andrew Tropin
[-- Attachment #1: Type: text/plain, Size: 5267 bytes --]
On Fri, Sep 24 2021, Antero Mejr via Guix-patches via wrote:
> * gnu/packages/telephony.scm (pn): New variable.
The ‘libphonenumber’ package is also added; this should be split into
patches, each adding one new package.
> ---
> Add pn and its dependencies.
> It's a phone number CLI tool used by Linux phone GUIs like SXMO.
>
> gnu/packages/telephony.scm | 72 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index 48bbe12920..9015cf536a 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -20,6 +20,7 @@
> ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
> ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
> +;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -54,12 +55,14 @@
> #:use-module (gnu packages documentation)
> #:use-module (gnu packages file)
> #:use-module (gnu packages protobuf)
> + #:use-module (gnu packages gawk)
> #:use-module (gnu packages gettext)
> #:use-module (gnu packages gl)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages icu4c)
> #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linphone)
> @@ -907,3 +910,72 @@ Initiation Protocol (SIP) and a multimedia framework.")
> telephony functionality into custom Telegram clients.")
> (home-page "https://github.com/zevlg/libtgvoip")
> (license license:unlicense)))
> +
> +(define-public libphonenumber
> + (package
> + (name "libphonenumber")
> + (version "8.12.33")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/google/libphonenumber")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f
There should be a comment explaining why tests are disabled.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-dir
> + (lambda _ (chdir "cpp") #t)))))
Phases don’t have to return #t.
> + (inputs
> + `(("boost" ,boost)
> + ("googletest" ,googletest)
> + ("protobuf" ,protobuf)
> + ("icu4c" ,icu4c)))
> + (home-page "https://github.com/google/libphonenumber")
> + (synopsis "C++ library for phone number parsing")
> + (description
> + "libphonenumber is Google's common Java, C++ and JavaScript library for
> +parsing, formatting, and validating international phone numbers.")
I would use @code{libphonenumber}.
The package doesn’t seem to be reproducible; ‘guix build libphonenumber
--rounds=2’ fails with
--8<---------------cut here---------------start------------->8---
guix build: error: derivation `/gnu/store/a0vycg9ic70bziygn098bbvw4hy39zzb-libphonenumber-8.12.33.drv' may not be deterministic: output `/gnu/store/1ifj4ndpf3mv8nwbjp0gzrx5jpjvghgb-libphonenumber-8.12.33' differs
--8<---------------cut here---------------end--------------->8---
Could you look into this?
> + (license license:asl2.0)))
> +
> +(define-public pn
> + (package
> + (name "pn")
> + (version "0.9.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Orange-OpenSource/pn")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f
Why are tests disabled?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'sub-bin-path
> + (lambda _
> + (substitute* "CMakeLists.txt" (("DESTINATION \\$\\{AWKLIBPATH\\}")
> + "DESTINATION bin")))))))
> + (inputs
> + `(("libphonenumber" ,libphonenumber)
> + ("icu4c" ,icu4c)
> + ("protobuf" ,protobuf)
> + ("gawk" ,gawk)))
> + (home-page "https://github.com/Orange-OpenSource/pn")
> + (synopsis "Command-line validation tool for phone numbers")
> + (description
> + "pn is a tool that allows command line user/programmers to operate on
> +phone numbers (get validity information, reformat them, or extract numbers
> +from a text snippet), using libphonenumber.")
I suggest
@code{pn} provides a command line tools that allows on to operate on
phone numbers (get validity information, reformat them, or extract
numbers from a text snippet), using @code{libphonenumber}.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH 0/2] Add pn.
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
2021-09-28 18:59 ` [bug#50873] " Xinglu Chen
@ 2021-09-28 20:56 ` Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 2/2] gnu: Add pn Antero Mejr via Guix-patches via
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
2 siblings, 2 replies; 9+ messages in thread
From: Antero Mejr via Guix-patches via @ 2021-09-28 20:56 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
Thanks for the suggestions Xinglu, I updated with the changes.
> The package doesn’t seem to be reproducible; ‘guix build libphonenumber
> --rounds=2’ fails
libphonenumber reproduces on my main computer, I can try again with a different one later:
successfully built /gnu/store/dyf2a70slkvfxf4qcims3q69a51ydb0x-libphonenumber-8.12.33.drv
successfully built /gnu/store/dyf2a70slkvfxf4qcims3q69a51ydb0x-libphonenumber-8.12.33.drv
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH 1/2] gnu: Add libphonenumber.
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
@ 2021-09-28 20:56 ` Antero Mejr via Guix-patches via
2021-09-29 11:42 ` Xinglu Chen
2022-01-17 10:06 ` Nicolas Goaziou
2021-09-28 20:56 ` [bug#50796] [PATCH 2/2] gnu: Add pn Antero Mejr via Guix-patches via
1 sibling, 2 replies; 9+ messages in thread
From: Antero Mejr via Guix-patches via @ 2021-09-28 20:56 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
* gnu/packages/telephony.scm (libphonenumber): New variable.
---
gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 48bbe12920..50b5790ae3 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -20,6 +20,7 @@
;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
+;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -54,12 +55,14 @@
#:use-module (gnu packages documentation)
#:use-module (gnu packages file)
#:use-module (gnu packages protobuf)
+ #:use-module (gnu packages gawk)
#:use-module (gnu packages gettext)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages gtk)
+ #:use-module (gnu packages icu4c)
#:use-module (gnu packages image)
#:use-module (gnu packages libcanberra)
#:use-module (gnu packages linphone)
@@ -907,3 +910,38 @@ Initiation Protocol (SIP) and a multimedia framework.")
telephony functionality into custom Telegram clients.")
(home-page "https://github.com/zevlg/libtgvoip")
(license license:unlicense)))
+
+(define-public libphonenumber
+ (package
+ (name "libphonenumber")
+ (version "8.12.33")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/google/libphonenumber")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'enter-dir
+ (lambda _ (chdir "cpp")))
+ (replace 'check
+ (lambda _ (invoke "./libphonenumber_test"))))))
+ (inputs
+ `(("boost" ,boost)
+ ("googletest" ,googletest)
+ ("protobuf" ,protobuf)
+ ("icu4c" ,icu4c)))
+ (home-page "https://github.com/google/libphonenumber")
+ (synopsis "C++ library for phone number parsing")
+ (description
+ "@code{libphonenumber} is Google's common Java, C++ and JavaScript
+library for parsing, formatting, and validating international phone numbers.")
+ (license license:asl2.0)))
+
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH 1/2] gnu: Add libphonenumber.
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
@ 2021-09-29 11:42 ` Xinglu Chen
2022-01-17 10:06 ` Nicolas Goaziou
1 sibling, 0 replies; 9+ messages in thread
From: Xinglu Chen @ 2021-09-29 11:42 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
[-- Attachment #1: Type: text/plain, Size: 3512 bytes --]
On Tue, Sep 28 2021, Antero Mejr via Guix-patches via wrote:
> * gnu/packages/telephony.scm (libphonenumber): New variable.
> ---
> gnu/packages/telephony.scm | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index 48bbe12920..50b5790ae3 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -20,6 +20,7 @@
> ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
> ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
> +;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -54,12 +55,14 @@
> #:use-module (gnu packages documentation)
> #:use-module (gnu packages file)
> #:use-module (gnu packages protobuf)
> + #:use-module (gnu packages gawk)
> #:use-module (gnu packages gettext)
> #:use-module (gnu packages gl)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages icu4c)
> #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linphone)
> @@ -907,3 +910,38 @@ Initiation Protocol (SIP) and a multimedia framework.")
> telephony functionality into custom Telegram clients.")
> (home-page "https://github.com/zevlg/libtgvoip")
> (license license:unlicense)))
> +
> +(define-public libphonenumber
> + (package
> + (name "libphonenumber")
> + (version "8.12.33")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/google/libphonenumber")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0r12icyig6jy0v87j9n3w14acfa2yfckzzfbmnjx1hww6qc9ih25"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-dir
> + (lambda _ (chdir "cpp")))
> + (replace 'check
> + (lambda _ (invoke "./libphonenumber_test"))))))
Great that you got the tests to run; however this ‘check’ phase doesn’t
respect the ‘--without-tests’ package transformation. The snippet below
should do.
--8<---------------cut here---------------start------------->8---
(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "./libphonenumber_test")))
--8<---------------cut here---------------end--------------->8---
> + (inputs
> + `(("boost" ,boost)
> + ("googletest" ,googletest)
> + ("protobuf" ,protobuf)
> + ("icu4c" ,icu4c)))
> + (home-page "https://github.com/google/libphonenumber")
> + (synopsis "C++ library for phone number parsing")
> + (description
> + "@code{libphonenumber} is Google's common Java, C++ and JavaScript
> +library for parsing, formatting, and validating international phone numbers.")
> + (license license:asl2.0)))
For some reason the build is still not reproducible for me; I ran
diffoscope on the two outputs, and it produced 120 MB worth of output…
Maybe a third person could test if the build is reproducible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH 1/2] gnu: Add libphonenumber.
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
2021-09-29 11:42 ` Xinglu Chen
@ 2022-01-17 10:06 ` Nicolas Goaziou
1 sibling, 0 replies; 9+ messages in thread
From: Nicolas Goaziou @ 2022-01-17 10:06 UTC (permalink / raw)
To: 50796; +Cc: antero
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Hello,
Antero Mejr via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/telephony.scm (libphonenumber): New variable.
Thank you.
I tweaked the package and updated it to 8.12.41. I'm attaching the resulting package.
Unfortunately I couldn't make it build. Could you have a look?
Regards,
--
Nicolas Goaziou
[-- Attachment #2: Add libphonenumber --]
[-- Type: text/x-diff, Size: 3675 bytes --]
From b51b0f4b9b9afb9843e6e3f0b248677725961d1b Mon Sep 17 00:00:00 2001
Message-Id: <b51b0f4b9b9afb9843e6e3f0b248677725961d1b.1642413903.git.mail@nicolasgoaziou.fr>
From: Antero Mejr <antero@kodmin.com>
Date: Mon, 17 Jan 2022 11:04:50 +0100
Subject: [PATCH] gnu: Add libphonenumber.
* gnu/packages/telephony.scm (libphonenumber): New variable.
---
gnu/packages/telephony.scm | 40 ++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index b4b2585935..264c5a738f 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -22,6 +22,7 @@
;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev>
;;; Copyright © 2021 Demis Balbach <db@minikn.xyz>
+;;; Copyright © 2021 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -50,18 +51,21 @@ (define-module (gnu packages telephony)
#:use-module (gnu packages boost)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
+ #:use-module (gnu packages cpp)
#:use-module (gnu packages crypto)
#:use-module (gnu packages databases)
#:use-module (gnu packages docbook)
#:use-module (gnu packages documentation)
#:use-module (gnu packages file)
#:use-module (gnu packages protobuf)
+ #:use-module (gnu packages gawk)
#:use-module (gnu packages gettext)
#:use-module (gnu packages gl)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages gtk)
+ #:use-module (gnu packages icu4c)
#:use-module (gnu packages image)
#:use-module (gnu packages libcanberra)
#:use-module (gnu packages linphone)
@@ -92,6 +96,7 @@ (define-module (gnu packages telephony)
#:use-module (guix utils)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix gexp)
#:use-module (guix git-download)
#:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
@@ -156,6 +161,41 @@ (define-public libilbc
(home-page "https://github.com/TimothyGu/libilbc")
(license license:bsd-3)))
+(define-public libphonenumber
+ (package
+ (name "libphonenumber")
+ (version "8.12.41")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/google/libphonenumber")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0w2jy4nng8y2203l56m2bg5mzfkan99q9k4ixqa83ss8sj0ris4q"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'enter-dir
+ (lambda _ (chdir "cpp")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "./libphonenumber_test")))))))
+ (native-inputs
+ (list googletest pkg-config))
+ (inputs
+ (list boost icu4c protobuf))
+ (home-page "https://github.com/google/libphonenumber")
+ (synopsis "C++ library for phone number parsing")
+ (description
+ "@code{libphonenumber} is Google's common Java, C++ and JavaScript
+library for parsing, formatting, and validating international phone numbers.")
+ (license license:asl2.0)))
+
(define-public spandsp
(package
(name "spandsp")
--
2.34.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH 2/2] gnu: Add pn.
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
@ 2021-09-28 20:56 ` Antero Mejr via Guix-patches via
1 sibling, 0 replies; 9+ messages in thread
From: Antero Mejr via Guix-patches via @ 2021-09-28 20:56 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
* gnu/packages/telephony.scm (pn): New variable.
---
gnu/packages/telephony.scm | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 50b5790ae3..d30c8aa661 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -945,3 +945,38 @@ telephony functionality into custom Telegram clients.")
library for parsing, formatting, and validating international phone numbers.")
(license license:asl2.0)))
+(define-public pn
+ (package
+ (name "pn")
+ (version "0.9.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Orange-OpenSource/pn")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:tests? #f ; no tests
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'sub-bin-path
+ (lambda _
+ (substitute* "CMakeLists.txt" (("DESTINATION \\$\\{AWKLIBPATH\\}")
+ "DESTINATION bin")))))))
+ (inputs
+ `(("libphonenumber" ,libphonenumber)
+ ("icu4c" ,icu4c)
+ ("protobuf" ,protobuf)
+ ("gawk" ,gawk)))
+ (home-page "https://github.com/Orange-OpenSource/pn")
+ (synopsis "Command-line validation tool for phone numbers")
+ (description
+ "@code{pn} provides a command line tool that allows users to operate on
+phone numbers (get validity information, reformat them, or extract
+numbers from a text snippet), using @code{libphonenumber}.")
+ (license license:asl2.0)))
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [bug#50796] [PATCH] gnu: Add pn.
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
2021-09-28 18:59 ` [bug#50873] " Xinglu Chen
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
@ 2022-08-11 19:11 ` Antero Mejr via Guix-patches via
2022-08-12 14:39 ` bug#50796: " Efraim Flashner
2 siblings, 1 reply; 9+ messages in thread
From: Antero Mejr via Guix-patches via @ 2022-08-11 19:11 UTC (permalink / raw)
To: 50796; +Cc: Antero Mejr
* gnu/packages/messaging.scm (pn): New variable.
---
Updated with new gexps and retested.
gnu/packages/messaging.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 47798c3586..704feb1177 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3446,4 +3446,35 @@ (define-public python-harmony
(home-page "https://github.com/taylordotfish/harmony")
(license license:gpl3+)))
+(define-public pn
+ (package
+ (name "pn")
+ (version "0.9.0")
+ (home-page "https://github.com/Orange-OpenSource/pn")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f ;no tests
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'sub-bin-path
+ (lambda _
+ (substitute* "CMakeLists.txt"
+ (("DESTINATION \\$\\{AWKLIBPATH\\}")
+ "DESTINATION bin")))))))
+ (inputs (list libphonenumber icu4c protobuf))
+ (synopsis "Command-line validation tool for phone numbers")
+ (description
+ "@code{pn} provides a command line tool that allows users to operate on
+phone numbers (get validity information, reformat them, or extract numbers from
+a text snippet), using @code{libphonenumber}.")
+ (license license:asl2.0)))
+
;;; messaging.scm ends here
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#50796: [PATCH] gnu: Add pn.
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
@ 2022-08-12 14:39 ` Efraim Flashner
0 siblings, 0 replies; 9+ messages in thread
From: Efraim Flashner @ 2022-08-12 14:39 UTC (permalink / raw)
To: Antero Mejr; +Cc: 50796-done
[-- Attachment #1: Type: text/plain, Size: 2470 bytes --]
I pushed the patch with a few changes.
On Thu, Aug 11, 2022 at 03:11:05PM -0400, Antero Mejr via Guix-patches via wrote:
> * gnu/packages/messaging.scm (pn): New variable.
> ---
> Updated with new gexps and retested.
>
> gnu/packages/messaging.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 47798c3586..704feb1177 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -3446,4 +3446,35 @@ (define-public python-harmony
> (home-page "https://github.com/taylordotfish/harmony")
> (license license:gpl3+)))
>
> +(define-public pn
> + (package
> + (name "pn")
> + (version "0.9.0")
> + (home-page "https://github.com/Orange-OpenSource/pn")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1lvzb0yixj7wmmqzsri20k9nn3gf06j0yjvmg2mi1zihywq7s4dx"))))
> + (build-system cmake-build-system)
> + (arguments
> + (list #:tests? #f ;no tests
> + #:phases #~(modify-phases %standard-phases
> + (add-after 'unpack 'sub-bin-path
> + (lambda _
> + (substitute* "CMakeLists.txt"
> + (("DESTINATION \\$\\{AWKLIBPATH\\}")
> + "DESTINATION bin")))))))
I changed the DESTINATION so that the library would install to
#$output/lib.
> + (inputs (list libphonenumber icu4c protobuf))
I re-sorted the inputs alphabetically.
> + (synopsis "Command-line validation tool for phone numbers")
> + (description
> + "@code{pn} provides a command line tool that allows users to operate on
> +phone numbers (get validity information, reformat them, or extract numbers from
> +a text snippet), using @code{libphonenumber}.")
> + (license license:asl2.0)))
> +
> ;;; messaging.scm ends here
> --
> 2.37.1
>
>
>
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-12 14:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-25 3:28 [bug#50796] [PATCH] gnu: Add pn Antero Mejr via Guix-patches via
2021-09-28 18:59 ` [bug#50873] " Xinglu Chen
2021-09-28 20:56 ` [bug#50796] [PATCH 0/2] " Antero Mejr via Guix-patches via
2021-09-28 20:56 ` [bug#50796] [PATCH 1/2] gnu: Add libphonenumber Antero Mejr via Guix-patches via
2021-09-29 11:42 ` Xinglu Chen
2022-01-17 10:06 ` Nicolas Goaziou
2021-09-28 20:56 ` [bug#50796] [PATCH 2/2] gnu: Add pn Antero Mejr via Guix-patches via
2022-08-11 19:11 ` [bug#50796] [PATCH] " Antero Mejr via Guix-patches via
2022-08-12 14:39 ` bug#50796: " Efraim Flashner
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.