From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YKC9KDrIT2F4uQAAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 03:09:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cOpnJDrIT2FzeQAAB5/wlQ (envelope-from ) for ; Sun, 26 Sep 2021 01:09:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D6E42B0B2 for ; Sun, 26 Sep 2021 03:09:14 +0200 (CEST) Received: from localhost ([::1]:53280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUIfJ-0000GO-9b for larch@yhetil.org; Sat, 25 Sep 2021 21:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUIf8-0000GD-72 for guix-patches@gnu.org; Sat, 25 Sep 2021 21:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUIf8-0003Ku-0B for guix-patches@gnu.org; Sat, 25 Sep 2021 21:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUIf7-0004xc-Hp for guix-patches@gnu.org; Sat, 25 Sep 2021 21:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50793] [PATCH 1/2] gnu: Add JSON.sh Resent-From: Stephen Paul Weber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Sep 2021 01:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50793 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50793@debbugs.gnu.org Received: via spool by 50793-submit@debbugs.gnu.org id=B50793.163261850919029 (code B ref 50793); Sun, 26 Sep 2021 01:09:01 +0000 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 01:08:29 +0000 Received: from localhost ([127.0.0.1]:35187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIeb-0004wr-55 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:08:29 -0400 Received: from singpolyma.net ([192.99.233.116]:51673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIea-0004wk-9i for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 21:08:28 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 6FBFB486167C; Sun, 26 Sep 2021 01:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632618507; bh=Z1+Gr/OdzkV6SxAVxIG8OJ1Rt4tW/DVWfOT6ig013dY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pi1lrsDJbVLEzEvLBxkRJWmV3FuOxSt9Z4nU9cfmOEiOXufO31MOR93Ex8VwbKoLD 55iQfVLwAO4CdpCVyOh9cduwULemraSFhw3xju+qVYBseudsJJYzWklP+F0ou2MUg/ wqDA/H1yb7vWn06ixzeI6HMTGeEiGUe725f5fdXQ= Date: Sat, 25 Sep 2021 20:08:27 -0500 From: Stephen Paul Weber Message-ID: <20210926010827.GA16766@singpolyma-beefy.lan> References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210925013934.2763-1-singpolyma@singpolyma.net> <86k0j5wecb.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline In-Reply-To: <86k0j5wecb.fsf@mgsn.dev> Jabber-ID: singpolyma@singpolyma.net OpenPGP: id=CE519CDE; url=https://singpolyma.net/public.asc X-URL: https://singpolyma.net User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 7D6E42B0B2 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: ftqJqmxLbZjT --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline >> +(define-public JSON.sh >> + (package >> + (name "JSON.sh") > >I can't find a rule for this per se, but it's convention that package >names to be lowercase (and for the variable name to match). Ok. Should I keep the . for "json.sh" or go with "jsonsh" ? Should I change the script/command name to match? >> + (version "0d5e5c7") > >Since this isn't a tagged version, this should follow the 'git-version' >pattern (search for usages of 'git-version' for examples). Will do. >> + (add-before 'install 'check >> + (lambda _ >> + (invoke "./all-tests.sh") >> + #t)) > >Check phases should respect #:tests?, like so: > > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > [...])) Ok >> + '("grep" "coreutils")) > >Does this script actually use coreutils? It uses printf > On the other hand, it looks >like it does use gawk gawk is only used if egrep is not present > and sed. Missed this, will add. --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEWeaCw+rzmiEMpzU00RwpEc5RnN4FAmFPyAAACgkQ0RwpEc5R nN7L6A//Qdjw8aYXNpCgfpIZSIvdeG0BFhTpIkfku19LVyokPJaRotXj0QA5DhLz uXu4Y9BixmXyqkOQCKM/oRv5aeLQVx78AmTV3Us+hUVk6ZT2mOOn8mpA+reuPk59 xqvUWM7LZvnmqlQ+aSvJRwSQ/yWX0bMqEUA1+/eSEQYhopdUn+USYu6y2umk0FQQ +49o2WK/conJ1UfFOMaL8KUqc5pOuwL9oCYZjhNCHDe+88dK62hWwZpVw9yOmM4a BcT7yOK2sX//CW03k3/Q24g/tGMGoFHZZQgCuZiPRjRBidd3FqxDIN7eCdL+GNZg R7sVWEZa/o3/yzB/e+EB2OokSBkqR1QlsSi5/9nOaucR0roaF8bFMPoVJ/zg5Fce l/fy/yu9+uFZJrDMoYczL8U3swyGadoNxfw2FWKEwLuRIIqNfaLQxXP39/R8JBGn f3nQAPhkzZU7AkGv2+my/XOBy9dV+gfolOIdzRLeYe3yGJXNpHCoUJon6euteIuk qsZ0Rzp8UhhDc6pAvLwm5QK6heCxyJyTZx6ogBpSsXR1CdJA6I2I6FOjzM/sR6iJ dvBOtt31JdUV26LLv5U/1NM2dyhMCsksFVQuEDtSlcW9wEkeh9/zkoD8baxKzZyn v5lyTqBaWnMhCXsDZESafouVF8f0FRpfLq6qQDR1n+3uKZRJNL0= =aXki -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q--