From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oMuYGb1gEWH7UwEAgWs5BA (envelope-from ) for ; Mon, 09 Aug 2021 19:07:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YAU6Fb1gEWGILwAAbx9fmQ (envelope-from ) for ; Mon, 09 Aug 2021 17:07:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFFBC2B54E for ; Mon, 9 Aug 2021 19:07:08 +0200 (CEST) Received: from localhost ([::1]:47310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD8jz-0007aC-SR for larch@yhetil.org; Mon, 09 Aug 2021 13:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD8ju-0007YQ-8O for guix-patches@gnu.org; Mon, 09 Aug 2021 13:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mD8ju-0008UV-1U for guix-patches@gnu.org; Mon, 09 Aug 2021 13:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mD8jt-0001G6-Ne for guix-patches@gnu.org; Mon, 09 Aug 2021 13:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49934] [PATCH 1/3] gnu: Add libx86emu Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Aug 2021 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49934 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49934@debbugs.gnu.org, Vincent Legoll Received: via spool by 49934-submit@debbugs.gnu.org id=B49934.16285288104822 (code B ref 49934); Mon, 09 Aug 2021 17:07:01 +0000 Received: (at 49934) by debbugs.gnu.org; 9 Aug 2021 17:06:50 +0000 Received: from localhost ([127.0.0.1]:57664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD8je-0001Fe-Hw for submit@debbugs.gnu.org; Mon, 09 Aug 2021 13:06:50 -0400 Received: from pelzflorian.de ([5.45.111.108]:56080 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mD8jY-0001FR-W4 for 49934@debbugs.gnu.org; Mon, 09 Aug 2021 13:06:45 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 6D7B3360674; Mon, 9 Aug 2021 19:06:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1628528799; bh=L3roS8QGCXO9w86BJxQPTJz49DKzN5K2sBpO+QKvyiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=uncEEoiFYoIEgIJQrxGnvNA1Eb2CEi8kz7R+mV2OrhC0B83Kt7gPSdJvkAWHnXB0a lWI1qLZQo6Sojx9xmqbXJH4tiSvGI2CouWC4QeHYXOW2AHiFHRCpe3n+Wcbq3FzlNt qDUOr4VAKm23qIlLxRJG9SRkdUva84DPKHr1Goz0= Date: Mon, 9 Aug 2021 19:06:28 +0200 From: "pelzflorian (Florian Pelz)" Message-ID: <20210809170628.4yx45hvxcso6zgng@pelzflorian.localdomain> References: <20210808101003.gf66cz5raojbic4c@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628528829; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PopQtOj6KPIxahE045fLmfsjNjM3I40dzp3wNYsnFF8=; b=Y6d1HLedH5Gv/DctraogGt9TV2IJSQbz1KAwSinVCJfPLUoy45MzCt/wb1vDj0QvMEYbbi C7ZXgw7zDYHXwHyZK5FTd6lQ5GJRGwNJZbQjw9/6NHwhi4dEW0khyXRvxOjKzizNS3HNdd tMuC/LTKK2iSD4RUO0ze3BIupclcVaIZ9YE71WfVos++NZxeeufDXEcMV37CEpVb2rnOPA Ow+O/IzlQEIPWsPF9lmDscNf7yuQerZRWLkoVdejqt0gAzsoMLZeghISt5rH57xzBxTRYD vr9g4dV5NcYYwhDFvUTFRPNLq4inNEzgaqQojir2/G2ywu3d4W3BINcpI9a0Zw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628528829; a=rsa-sha256; cv=none; b=l50EbEZKuCUGeFwJ9nZxFd/XOx0yweswHFXmWFvJOLn2wHyopAFpSAGWxT273vBZz8xryc OaqtT4oM1m/viHsvWRQsiHFDOu4JvhPusQI/Cy+dCdsLOk2FpBSaxr40tmQNKGOU4dqcvZ 9WV8zeaf5sF4U+bGhiPFRYfu8mhUBau+1ujSzrtMlBSD9SMPzbY7Rc/ePq/0HdvTxV/jJI UnvrChWwQYZx86CKqGjnh3Uto0OqHwadlq6Wfkn9ALVS4R3H858PosZt2IgO1QrCdc2yDa UnhrFT+H7GOzf8oUJU21otyrE8C1nUzhJwvvQdc72LVhcebP3X504nhHwm2U/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=uncEEoiF; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=mail header.b=uncEEoiF; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EFFBC2B54E X-Spam-Score: -1.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: V+ZoKNhb240o On Mon, Aug 09, 2021 at 12:00:00PM +0000, phodina wrote: > Thanks. I didn't know there's a patch already. The aim of this one is to get the hwinfo and hw-prober to get the hardware details. I think it is good to get your patch into shape and merged. While I haven’t been involved in package review (shame on me), I’ll give it a try. You should, after applying each of your patches, cd to the guix repo and run `./etc/indent-code.el gnu/packages/hardware.scm` as described in `info '(guix)Formatting Code'`. `./pre-inst-env guix lint libx86emu` warns that your custom check phase does not consider #:tests? (i.e. it does not work with the --without-tests transform option). As for the package libx86emu proper: > (define-public libx86emu > (package > (name "libx86emu") > (version "3.1") > (source (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/wfeldt/libx86emu") > (commit version))) > (file-name (git-file-name name version)) > (sha256 > (base32 > "104xqc6nj9rpi7knl3dfqvasf087hlz2n5yndb1iycw35a6j509b")))) > (build-system gnu-build-system) > (arguments > `(#:make-flags (list > (string-append "CC=" ,(cc-for-target)) > (string-append "DESTDIR=" %output) > (string-append "LIBDIR=/lib")) > #:phases (modify-phases %standard-phases > (delete 'configure) > (add-after 'unpack 'fix-version-and-usr > (lambda* (#:key inputs #:allow-other-keys) > (delete-file "git2log") I am not sure, would it be better to delete this git2log in an origin snippet? I have not checked. > (let* ((file (open-file "VERSION" "a"))) > (display ,version file) > (close-port file)) > (substitute* "Makefile" > (("/usr") "/")))) > (replace 'check > (lambda* _ > (invoke "make" "test")))))) > (native-inputs `(("git" ,git) ("perl" ,perl) ("nasm" ,nasm))) > (synopsis "Library for x86 emulation") > (description "Small library to emulate x86 instructions. The focus here > is not a complete emulation (go for qemu for this) but to cover enough for > typical firmware blobs. The start of the sentence is missing before @enumerate. “You can”? > @enumerate > @item intercept any memory access or directly map real memory ranges > @item intercept any i/o access, map real i/o ports, or block any real i/o > @item intercept any interrupt > @item provides hook to run after each instruction Either “provides a hook” or “provides hooks”. > @item recognizes a special x86 instruction that can trigger logging s/recognizes/recognize/ > @item has integrated logging Maybe s/has/use/ > @end enumerate") > (home-page "https://github.com/wfeldt/libx86emu") > (license license:bsd-1))) The license is not bsd-1 but x11-style, I think. Regards, Florian