all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gabriel Wicki <gabriel@erlikon.ch>
To: guix-devel@gnu.org
Subject: Re: Removing package input labels: last call!
Date: Wed, 7 Jul 2021 14:29:28 +0200	[thread overview]
Message-ID: <20210707122928.6s34jblnx5zhvd5f@knurd> (raw)
In-Reply-To: <87h7hgssb2.fsf@inria.fr>

Hi!

I hope I'm not too late!  I've given the patch a try and have a couple
of questions:

 - Since not all the inputs *have* to be converted to the new format:
   is this more some kind of syntactic sugar and less of a "we really
   want this to be the new standard" kind of improvement?
   Or is the goal to replace *all* input lists with the new style?

 - Regarding the speed of the transition: do I understand correctly that
   the script should be able to convert the vast majority of packages
   and that afterwards maybe other definitions will/might/could be
   translated by hand?
 - Follow up: is your intention to adjust the script to work with more
   and more package definitions or are you leaning into a more "let's
   have a sound script which is useful for many cases but leaves a
   biggish bunch of manual labor but at least it won't break a thing"
   kind of solution?

 - Is there a way to check the integrity of a package definition
   *without* building the whole thing?  I had some ideas (see below)
   for adding special cases to your `guix style` script but was unable
   to test whether they actually work (because compiling tonnes of
   codes unsurprisingly takes quite some time).


What I found:
 - Small things like libX11 vs libx11.  If I understood correctly the
   new patch series takes care of this case.

 - I think there's a whole class of cases where version-names and
   other package-definition specifics make the "does-the-package-name-
   match-the-label-exactly" algo fail:
    - ,python-wrapper vs. "python"
    - ,python-minimal-wrapper vs. "python"
    - ,python2 vs. "python"
    - ,python-cython vs. "cython"
    - ,iproute2 vs. "iproute"
    - etc

I've written some code and tested it with some specific package
definitions but since I was unable to test whether these substitutions
actually work for *all* package definitions I'll just leave these
remarks here :)


I hope this is somewhat help- or useful.

Gabriel


  reply	other threads:[~2021-07-07 12:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:40 Removing package input labels: last call! Ludovic Courtès
2021-07-07 12:29 ` Gabriel Wicki [this message]
2021-07-10 14:38   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707122928.6s34jblnx5zhvd5f@knurd \
    --to=gabriel@erlikon.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.