From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCoLD+POzWCJrQAAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 13:02:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4BvWCuPOzWCgSQAA1q6Kng (envelope-from ) for ; Sat, 19 Jun 2021 11:02:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39A1729945 for ; Sat, 19 Jun 2021 13:02:58 +0200 (CEST) Received: from localhost ([::1]:47638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luYka-0003S2-T4 for larch@yhetil.org; Sat, 19 Jun 2021 07:02:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luYjj-00039t-3G for guix-patches@gnu.org; Sat, 19 Jun 2021 07:02:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luYji-00027o-MN for guix-patches@gnu.org; Sat, 19 Jun 2021 07:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luYji-0002Lu-FG for guix-patches@gnu.org; Sat, 19 Jun 2021 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49101] [PATCH v2 1/5] gnu: ocaml4.07-pcre: Switch to default OCaml compiler. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 11:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 49101@debbugs.gnu.org Received: via spool by 49101-submit@debbugs.gnu.org id=B49101.16241005059004 (code B ref 49101); Sat, 19 Jun 2021 11:02:02 +0000 Received: (at 49101) by debbugs.gnu.org; 19 Jun 2021 11:01:45 +0000 Received: from localhost ([127.0.0.1]:58620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luYjR-0002LA-93 for submit@debbugs.gnu.org; Sat, 19 Jun 2021 07:01:45 -0400 Received: from lepiller.eu ([89.234.186.109]:45210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luYjO-0002L0-C0 for 49101@debbugs.gnu.org; Sat, 19 Jun 2021 07:01:43 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 42c48394; Sat, 19 Jun 2021 11:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=lw1yuQyIqjOo gNOt77xCjPlRzD71ObqQqJZvGunkGlA=; b=ZZ7MS9eK0J/dAonOkAthwdD8/rCX SXVRnTnoUJWMgh+cLt9apo720ba3eqsmNH335R3dbVFv3/7o/IckTRLDRUJQyFa/ ceS6pk+030hIqJwaXnsEMKGXn/4xX0+p5kf6+Hc8xYUNxCLi6cFc9Ha6Cq5mGrgH To5d4pTMm8UY1qnDl+g6+vC0YVQwb/4FAqVriW+7tmLuW+KpBxB1+dJnBAKyFDhd EII9kFLIJS+46+IldzgUCgiscIY6cuOFo/JEof7QvlA8bGPYjAv7qWj7wcjLGpju wPpxN8hN6pfTuCNqs+pQT3j6HIuaUzxDLqPpq5LzMtgzDHiJInA5qM21Tg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 0eebd124 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 19 Jun 2021 11:01:39 +0000 (UTC) Date: Sat, 19 Jun 2021 13:01:36 +0200 From: Julien Lepiller Message-ID: <20210619130136.02d59fd1@tachikoma.lepiller.eu> In-Reply-To: <297c3da0df390937b17eb9fceb33202a25bf1f34.1624093132.git.public@yoctocell.xyz> References: <297c3da0df390937b17eb9fceb33202a25bf1f34.1624093132.git.public@yoctocell.xyz> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624100578; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4kU708/21oGQCPIUy4yyXqKnEaK4DuzLAMU6glH4JEI=; b=Iojx5CD8Nn1su6DoFwA+9MCirtwO+5fb4AtHK+vNG83PuC1TbYTcyGoFUyNQcbMJMoo5Kf qjHjeOZkpXZ/GtYaYfhkGev4oq9/NSncP6RmA0yj0LtTfdxMQoLq5/Mt+X++Z+c3FYVBnI R7Iz60OvgW7BQ/g0WiqdcYwgIbt9ugyWEMSlLMLpS1+65hnAHKUL2z54agfPDFAIkvDegw UcDaTtoakMrvqDgBGcf5bnwYc9R0kONKU3MxCniMjXq38exRN29u3ohM8Ee+RJi4C+J0ei E1g74hDUWTRYV2IdAoysyDf7ySXFcTYbydU4XSZsGuQnIdlqZcb/V7usm7+rWw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624100578; a=rsa-sha256; cv=none; b=ANvG+ULvMdA9SjtMxPAVgdFcsajz9ytzPpyawOayYrXMATCxJRuv6BD5aTX4+zczToSd/b DzPabz9LUJsE2GSW+oEKRvbm2cJffm8mStags5l8sbvM7uuchCcUzlwIAXacu1NCGCY9Ab hYtLQ9cMoh3gdn6/OaV0IfMXRG3xBNfK1s3BOpnOBlxGgnsyV5VzTE25qpGJl/puoeTSTR 8XhBrlGwUwuUgLtGRsWne25mQNP/KeefvJRU7jQRYr/54cQJkHRp2Ik3IUAWjX2FbNUJmb 6CXd2V8A3GvcNfiiT3MaQlXRPeLej3zgPKJ7wdQolY+gw0APt8NfF+xcsuQaYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=ZZ7MS9eK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=ZZ7MS9eK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 39A1729945 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: Rl8RaboezDBG Le Sat, 19 Jun 2021 11:03:39 +0200, Xinglu Chen a =C3=A9crit : > * gnu/packages/ocaml.scm (ocaml4.07-pcre): Rename to =E2=80=98ocaml-pcre= =E2=80=99. > [version]: Update to latest version. > [arguments]: Use default OCaml compiler. > [native-inputs]: Adjust accordingly. > [propagated-inputs]: Likewise. Great! > --- > gnu/packages/ocaml.scm | 50 > ++++++++++++++++++++++-------------------- 1 file changed, 26 > insertions(+), 24 deletions(-) >=20 > diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm > index a8432ebbfe..e02684fefd 100644 > --- a/gnu/packages/ocaml.scm > +++ b/gnu/packages/ocaml.scm > @@ -3086,35 +3086,37 @@ every compliant installation of OCaml and > organize these libraries into a hierarchy of modules.") > (license license:lgpl2.1+))) > =20 > -(define-public ocaml4.07-pcre > +(define-public ocaml-pcre > (package > - (name "ocaml4.07-pcre") > - (version "7.4.1") > - (source (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/mmottl/pcre-ocaml") > - (commit version))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - > "11sd8g668h48790lamz0riw9jgnfkaif5qdfa0akcndwa6aj07jf")))) > + (name "ocaml-pcre") > + (version "7.4.6") If possible, it would be best not to update pcre at the same time. You can try updating first, then switch to the latest ocaml, or the other way around. If it's really not possible, please add the version number to the commit message. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/mmottl/pcre-ocaml") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + > "11mck879p5zvkghps4ky8yslm0isgz52d84adl0dmcfxv2ibvcym")))) > (build-system dune-build-system) (arguments > - `(#:test-target "." > - #:ocaml ,ocaml-4.07 > - #:findlib ,ocaml4.07-findlib > - #:dune ,ocaml4.07-dune)) > + ;; No tests. > + '(#:tests? #f)) Are you sure there are no tests? There used to be tests that could be found at the top-level directory (#:test-target "."). Doesn't that work anymore? > + (propagated-inputs > + `(("dune-configurator" ,dune-configurator) > + ("pcre" ,pcre))) > (native-inputs > - `(("ocaml-base" ,(package-with-ocaml4.07 ocaml-base)) > - ("pcre:bin" ,pcre "bin"))) > - (propagated-inputs `(("pcre" ,pcre))) > + `(("pcre:bin" ,pcre "bin"))) > (home-page "https://mmottl.github.io/pcre-ocaml") > - (synopsis "Bindings to the Perl Compatibility Regular > Expressions library") > - (description "Pcre-ocaml offers library functions for string > pattern -matching and substitution, similar to the functionality > offered by the Perl -language.") > - (license license:lgpl2.1+))); with the OCaml link exception > + (synopsis > + "Bindings to the Perl Compatibility Regular Expressions > library") > + (description "pcre-ocaml offers library functions for string > +pattern matching and substitution, similar to the functionality > +offered by the Perl language.") > + ;; With static linking exception > + (license license:lgpl2.1+))) Otherwise, looks good. > =20 > (define-public ocaml4.07-expect > (package