From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iLHpNi7WzGDrYgAAgWs5BA (envelope-from ) for ; Fri, 18 Jun 2021 19:21:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WHu4Mi7WzGALSgAA1q6Kng (envelope-from ) for ; Fri, 18 Jun 2021 17:21:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F3621371A for ; Fri, 18 Jun 2021 19:21:50 +0200 (CEST) Received: from localhost ([::1]:51786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luIBh-00019G-F9 for larch@yhetil.org; Fri, 18 Jun 2021 13:21:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luIA3-0007gY-Gz for guix-patches@gnu.org; Fri, 18 Jun 2021 13:20:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luIA3-00049i-7y for guix-patches@gnu.org; Fri, 18 Jun 2021 13:20:07 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luIA3-0004sY-4F for guix-patches@gnu.org; Fri, 18 Jun 2021 13:20:07 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49025] [PATCH v3 core-updates 09/37] libgpg-error: Prevent silent miscompilation some systems. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Jun 2021 17:20:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49025 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49025@debbugs.gnu.org Cc: othacehe@gnu.org, Maxime Devos Received: via spool by 49025-submit@debbugs.gnu.org id=B49025.162403675918414 (code B ref 49025); Fri, 18 Jun 2021 17:20:07 +0000 Received: (at 49025) by debbugs.gnu.org; 18 Jun 2021 17:19:19 +0000 Received: from localhost ([127.0.0.1]:58024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luI9G-0004mg-T5 for submit@debbugs.gnu.org; Fri, 18 Jun 2021 13:19:19 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:34876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luI97-0004j6-JC for 49025@debbugs.gnu.org; Fri, 18 Jun 2021 13:19:11 -0400 Received: from localhost.localdomain ([213.119.219.214]) by andre.telenet-ops.be with bizsmtp id JhK5250094e8Tal01hK9bd; Fri, 18 Jun 2021 19:19:09 +0200 From: Maxime Devos Date: Fri, 18 Jun 2021 19:16:03 +0200 Message-Id: <20210618171631.20534-9-maximedevos@telenet.be> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210618171631.20534-1-maximedevos@telenet.be> References: <20210618171631.20534-1-maximedevos@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1624036749; bh=nKM9iRbL4pxeve/Z9zTlm79RMuw3U+bWD4uPyj+c1VU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:Reply-To; b=bS7lOiQrb9kU0ZsoRIa/VFYzGahZuP/a6uvURHfh6mfUPzyTuh5RkkbTEzTElDjZi +CvhHbkZPXYDnAgN1VNZLupS3FiNnchNkSW4/vC4Y0GdXpCXrWGD9uMHbZTpSrnEmg uZflcUUF8kQHcx2lxWtcCEWp5GqEGELzS20XnuYaddja43MkigfgTdvkV8gkZdqDhC 4IE6hsgpR2eT07XExl1kwa1/gAxtJ2jU0mHpHoqnjoXskDKzq8TBJgB56r43wS9yeJ ++e/9j7dandJzOwz+Hc2PpX0WDXvD/y8QzM/BpSzHo3M95cxyErcr8mhgFCFwAehTX JlRQs+OfodKCQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 49025@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624036910; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nKM9iRbL4pxeve/Z9zTlm79RMuw3U+bWD4uPyj+c1VU=; b=iaTquMZFHvkLxtdISrTwxuVgCqtCT/DZyBeDDmPp4C+lIp+vWg6V6Z6lYWckCNAGHTtV5G ZtvxoKOIxrKsK6N+Yg2dnZI5lkkgOXKdI/umWvoT1Or6DxvG5dSs1kmZ8Yiob2oQdi94cl Bz0L1N+iaT0nHDzxieY1wJ3z4RAhITs8GC1WMPEk3S+WAKXQ7KHRXoXjI4tb5oCAKHd8YH jiKPWhrC6y6W+W67u9AmXgziufjq86SEIFi+R/2taavqLToe8Ea1ENCm3m9/d/D1sPym/A amGvtGhG5Xp6e0Gg0ZRWbsxlEEY6Oce2RNqol5j96sSLgC141NMvNDjzfAJeCQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624036910; a=rsa-sha256; cv=none; b=eoobb6Sd+9keXPsUKrK7uodOQdXwh9OYdhmm6U+tEHgck7TDrAdWzliEfBtwbb2MKCV+Os uGbiPxfqjHPtoFVV9ZtFO9+Zz/nNApP8btSzvhy6AbW/U7ZQiELjneUBx+JgB3Wd0ySYnX BVMgaMUvaAFuBxM6QDMGxorOdv69eVlegedB6LwKPJNwGi48gQ1vcxuVokOV5GNpBm8MA0 lGw1GVtd0Y/nz6MzNbl9WGg5JFMU3MUY4U5f6M+R85uhV/8932d1MAcCwJi+mQX6RgvA5B nIf74Pd0vEFkzpxVN6Bk+Zrlul8H4HfJ53SSfAwtjga5FWyIZIZ9xQ7bmsMPBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=bS7lOiQr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=bS7lOiQr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5F3621371A X-Spam-Score: 1.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: MVet7uWToT23 * gnu/packages/gpg.scm (libgpgerror)[arguments]<#:phases>{cross-symlinks}: Only link to src/syscfg/lock-obj-pub.linux-gnu.h if the package is being compiled for a Linux target. Do not link either if the architecture is unknown, as the headers vary with the architecture. --- gnu/packages/gnupg.scm | 40 ++++++++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm index 2f44e6ec6a..de213d381f 100644 --- a/gnu/packages/gnupg.scm +++ b/gnu/packages/gnupg.scm @@ -18,6 +18,7 @@ ;;; Copyright © 2018 Björn Höfling ;;; Copyright © 2019 Mathieu Othacehe ;;; Copyright © 2020 Fredrik Salomonsson +;;; Copyright © 2021 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -77,6 +78,7 @@ #:use-module (guix build-system gnu) #:use-module (guix build-system perl) #:use-module (guix build-system python) + #:use-module (ice-9 match) #:use-module (srfi srfi-1)) (define-public libgpg-error @@ -94,27 +96,37 @@ (build-system gnu-build-system) (arguments (if (%current-target-system) - `(#:modules ((ice-9 match) - (guix build gnu-build-system) + `(#:modules ((guix build gnu-build-system) (guix build utils)) #:phases (modify-phases %standard-phases ;; When cross-compiling, some platform specific properties cannot ;; be detected. Create a symlink to the appropriate platform - ;; file. See Cross-Compiling section at: + ;; file if required. Note that these platform files depend on + ;; both the operating system and architecture! + ;; + ;; See Cross-Compiling section at: ;; https://github.com/gpg/libgpg-error/blob/master/README (add-after 'unpack 'cross-symlinks - (lambda* (#:key target inputs #:allow-other-keys) - (let ((triplet - (match (string-take target - (string-index target #\-)) - ("armhf" "arm-unknown-linux-gnueabi") - ("mips64el" "mips-unknown-linux-gnu") - (x - (string-append x "-unknown-linux-gnu"))))) - (symlink - (string-append "lock-obj-pub." triplet ".h") - "src/syscfg/lock-obj-pub.linux-gnu.h")))))) + (lambda _ + (define (link triplet source) + (symlink (string-append "lock-obj-pub." triplet ".h") + (string-append "src/syscfg/lock-obj-pub." + source ".h"))) + ,(let* ((target (%current-target-system)) + (architecture + (string-take target (string-index target #\-)))) + (cond ((target-linux? target) + (match architecture + ("armhf" + `(link "arm-unknown-linux-gnueabi" "linux-gnu")) + ("mips64el" + `(link "mips-unknown-linux-gnu" "linux-gnu")) + ;; Don't always link to the "linux-gnu" + ;; configuration, as this is not correct for + ;; all architectures. + (_ #t))) + (#t #t))))))) '())) (native-inputs `(("gettext" ,gettext-minimal))) (home-page "https://gnupg.org") -- 2.32.0