From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id R4V7GIAlxWC14wAAgWs5BA (envelope-from ) for ; Sat, 12 Jun 2021 23:22:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MPKIE4AlxWCrOAAAB5/wlQ (envelope-from ) for ; Sat, 12 Jun 2021 21:22:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF2C62DCDE for ; Sat, 12 Jun 2021 23:22:07 +0200 (CEST) Received: from localhost ([::1]:56786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsB4w-0004u7-Vw for larch@yhetil.org; Sat, 12 Jun 2021 17:22:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsB4s-0004ti-MM for guix-patches@gnu.org; Sat, 12 Jun 2021 17:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsB4s-0000QC-EU for guix-patches@gnu.org; Sat, 12 Jun 2021 17:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lsB4s-0008Kq-Bm for guix-patches@gnu.org; Sat, 12 Jun 2021 17:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48981] [PATCH 2/2] gnu: pre-commit: Respect #:tests?. References: <20210612211933.785958-1-monego@posteo.net> In-Reply-To: <20210612211933.785958-1-monego@posteo.net> Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Jun 2021 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48981 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48981@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 48981-submit@debbugs.gnu.org id=B48981.162353290532012 (code B ref 48981); Sat, 12 Jun 2021 21:22:02 +0000 Received: (at 48981) by debbugs.gnu.org; 12 Jun 2021 21:21:45 +0000 Received: from localhost ([127.0.0.1]:42224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsB4U-0008K9-Vq for submit@debbugs.gnu.org; Sat, 12 Jun 2021 17:21:45 -0400 Received: from mout02.posteo.de ([185.67.36.66]:42321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lsB4T-0008Jt-DG for 48981@debbugs.gnu.org; Sat, 12 Jun 2021 17:21:38 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E8C7F2400FD for <48981@debbugs.gnu.org>; Sat, 12 Jun 2021 23:21:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1623532890; bh=6mbXkxDmq7oyPfdN/WTNmqzu4Qq4w/hPPNSvXmMH9RE=; h=From:To:Cc:Subject:Date:From; b=Ho7hthkdiNxNYER1huY8ZAKE2u1DihmGBGHtj9dBrzsBGZqRIAn4onzkWnacVY5Bh PFgGDaZuopX0GpliymZIWCQOX0kfGYm6PTs8RyfpzVmR6XsKrj7sL4dgXumYy1TdIB fa7yoifXXXcd7oLOP9XEQ78nEpy2yojG/w767xUsk3GctgCLqOtYw7X7WOL1i5bNdS NYGHihnXDuFOETxWb5dXHiHUeThYT7jXieukPI0lDpkU62CfOvaEHOZCP74dFylUx4 OO7HinXoBYUUCO4S7mJis7M+MZxwW++4PJ9eZz2akkklylO251Qq9xse64nC/9+p5O 9LLCOCJFMf0RQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G2VyK3rvvz9rxP; Sat, 12 Jun 2021 23:21:29 +0200 (CEST) From: Vinicius Monego Date: Sat, 12 Jun 2021 21:21:10 +0000 Message-Id: <20210612212110.786147-1-monego@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623532928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RrQcmZtnB0bRwhy3IRZDPYfMf5dbMc3xA+YWtghIU6o=; b=eYPlajH13WwlerulWYrLEGLcJFqWu07m58C5HA1V58Cb6ViR+4a/aB3gLcyvJrKlioBu9M uCQSlcwWcjzYcJFqU47vm6Fq30cdfI1LxkQAJoG3m92PLXhuQmHzHK2ybV/haxuG0WQnEQ ugGD5Mq1haf9MNtmcZPxt9gbfQR7PgnItpuXfYj3eJwcaUACVhtd14ChksetBptwuuCyU0 U4kYcy5a1PVOGA8g/Suc6zFBiEyrBEqkyRS+lmyXBAOXTTmk6X5/fwbkjr2BSmM9gEkWCe HYk9FQEe7c/vFr4Ud15bjsBaiEELktnuVDH2NfaVrBC5ucnJ0jCsURgfDnBOxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623532928; a=rsa-sha256; cv=none; b=G7fsv0RCA604KMFR7U0vHELUSxN/qZ7bVJhZ2Z4T+fzHSjbBKqjc9bEBAxH/RdINRvRYcg qvCX8iMW88pUrmED39B1swgaRqeX9JImcCiYOJj5AGAuRAXvlaPD/wVJ8ttt8HV259xgvX W2xTdE2ojq0yY4KKmriZw2yUI7Iydy0TLoF9hlrtMvddQMgBhvV/Q+AL3azVV9dQbNKaE0 I3CKaxkWXJycQzJZdpRZsA2xgsTtvYEJ1pJN7s6sQjmpDypmO7SPp0v6JdkHsgXoaFXZw3 6rYI3zxUt6L7rTFXxhJSrMQM1lUZL4kT3INA64kEVcPEOTVKk1IB2LzkYZF8Og== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Ho7hthkd; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 5.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Ho7hthkd; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DF2C62DCDE X-Spam-Score: 5.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3/ZoiCeSq49T * gnu/packages/version-control.scm (pre-commit)[arguments]: Respect #:tests? in the 'check phase. --- gnu/packages/version-control.scm | 39 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9f5341b4f9..7792c608e4 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -1552,26 +1552,27 @@ control to Git repositories.") (invoke "git" "config" "--global" "user.name" "Your Name") (invoke "git" "config" "--global" "user.email" "you@example.com"))) (replace 'check - (lambda* (#:key inputs outputs #:allow-other-keys) + (lambda* (#:key inputs outputs tests? #:allow-other-keys) (add-installed-pythonpath inputs outputs) - ;; The file below contains about 30 tests that fail because they - ;; depend on tools from multiple languages (cargo, npm, cpan, - ;; Rscript, etc). There are other tests that pass, but it's more - ;; convenient to skip the whole file than list 30 tests to skip. - (invoke "pytest" "--ignore=tests/repository_test.py" - ;; Ruby and Node tests require node and gem. - "--ignore=tests/languages/node_test.py" - "--ignore=tests/languages/ruby_test.py" - ;; FIXME: Python tests fail because of distlib version - ;; mismatch. Even with python-distlib/next it is - ;; pulling version 0.3.0, while 0.3.1 is required. - "--ignore=tests/languages/python_test.py" "-k" - (string-append - ;; TODO: these tests fail with AssertionError. It may - ;; be possible to fix them. - "not test_install_existing_hooks_no_overwrite" - " and not test_uninstall_restores_legacy_hooks" - " and not test_installed_from_venv")))) + (when tests? + ;; The file below contains 30+ tests that fail because they + ;; depend on tools from multiple languages (cargo, npm, cpan, + ;; Rscript, etc). Other tests are passing, but it's more + ;; convenient to skip the file than list 30 tests to skip. + (invoke "pytest" "--ignore=tests/repository_test.py" + ;; Ruby and Node tests require node and gem. + "--ignore=tests/languages/node_test.py" + "--ignore=tests/languages/ruby_test.py" + ;; FIXME: Python tests fail because of distlib version + ;; mismatch. Even with python-distlib/next it is + ;; pulling version 0.3.0, while 0.3.1 is required. + "--ignore=tests/languages/python_test.py" "-k" + (string-append + ;; TODO: these tests fail with AssertionError. It may + ;; be possible to fix them. + "not test_install_existing_hooks_no_overwrite" + " and not test_uninstall_restores_legacy_hooks" + " and not test_installed_from_venv"))))) (add-before 'reset-gzip-timestamps 'make-gz-writable (lambda* (#:key outputs #:allow-other-keys) ;; Make sure .gz files are writable so that the -- 2.32.0