From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iP4DNEiVvmBfmwAAgWs5BA (envelope-from ) for ; Mon, 07 Jun 2021 23:53:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mBkkL0iVvmDwIQAAbx9fmQ (envelope-from ) for ; Mon, 07 Jun 2021 21:53:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C6522A6BE for ; Mon, 7 Jun 2021 23:53:12 +0200 (CEST) Received: from localhost ([::1]:54140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqNBH-0004En-9e for larch@yhetil.org; Mon, 07 Jun 2021 17:53:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqNB8-00047w-9r for guix-patches@gnu.org; Mon, 07 Jun 2021 17:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqNB8-0006Ra-1R for guix-patches@gnu.org; Mon, 07 Jun 2021 17:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqNB7-0004FY-TM for guix-patches@gnu.org; Mon, 07 Jun 2021 17:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48850] [PATCH v2] gnu: coreutils: Disable inotify-dir-recreate test Resent-From: Carl Dong Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Jun 2021 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48850 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org Cc: 48850@debbugs.gnu.org, Carl Dong Received: via spool by 48850-submit@debbugs.gnu.org id=B48850.162310277516322 (code B ref 48850); Mon, 07 Jun 2021 21:53:01 +0000 Received: (at 48850) by debbugs.gnu.org; 7 Jun 2021 21:52:55 +0000 Received: from localhost ([127.0.0.1]:56806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqNB0-0004FC-LZ for submit@debbugs.gnu.org; Mon, 07 Jun 2021 17:52:54 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:47463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqNAz-0004Ez-CG for 48850@debbugs.gnu.org; Mon, 07 Jun 2021 17:52:53 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6072D14A7; Mon, 7 Jun 2021 17:52:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 07 Jun 2021 17:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=rmkNj4xtgj5aI HZlBzXbD2qufBh1+7wf1hOfzyTh3gM=; b=t8SLFG6G1aeYl6HQAprOtJxsIQckC 13wcgfdeGx6BbeLBS3apxSwvr37AKDKsl7+L2tCQM6FJuzkWSFeO8uyysz7CJWwQ sz6quKqLN+b5cLlYqBaQc2pTvbml49WyrKgi4bWHycE0FgBWuBLBp0N1lmLhqMtx MnENjRDPF5czhx9sDRCB9m1f4oi7MpxA1ccNRcvP0U9mwZry8zl3rJ/wNLSh8sK4 4oWW9Tl43dOtRYysS5tMDVxLjLjQxnP5RmAwS2ASXILctysWOHDh80zEU5BJmx3+ ctUQwReyLyEkH/tw36m8BoQaMm4W2o5e/8WHfcFZNa9jLWxQwNXHJKTEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=rmkNj4xtgj5aIHZlBzXbD2qufBh1+7wf1hOfzyTh3gM=; b=kzMTGvxM mZrjagNzHYr5/C0wHaP9Pk+5U0yjuiI7NNb5VVxfHph9XuO6gzlEkeU12/wg/HqH xpFMtLxhOow+h+v2oHuyTnsTDh7d9g5QKInnpsMm01XIhZNY7SoDOmYInDJXlYCu eRjyyB4iAO7V+IW4seSZHG6kT4QhPDkis5jRxZv5wW0rMdjAjNqOpJ0HTLJOg+IR 1TTVlZRC8OsCApLQg7yOevl3wmMdOt911nTVz1Ipwteaw1CjaR3R02j8ZCi2JME/ xeRk6hOHTtBqodv+vqCy22Sq9E9MyjyPCdbSDMIRJ5G0idWJdNZa88Gt8XajyD7y 7pdawBD47cqZOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtjedgudeihecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpeevrghrlhcuffhonhhguceotghonhhtrggtthestggrrhhl ughonhhgrdhmvgeqnecuggftrfgrthhtvghrnhepuefftefhteevgffflefffeevffefgf dvgefffffhvdetfeekudffgfeuvdejtdejnecuffhomhgrihhnpehgnhhurdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghonhhtrg gtthestggrrhhlughonhhgrdhmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Jun 2021 17:52:46 -0400 (EDT) From: Carl Dong Date: Mon, 7 Jun 2021 17:50:59 -0400 Message-Id: <20210607215058.3989424-1-contact@carldong.me> X-Mailer: git-send-email 2.31.1 In-Reply-To: <878s3onjzl.fsf@gnu.org> References: <878s3onjzl.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623102792; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rmkNj4xtgj5aIHZlBzXbD2qufBh1+7wf1hOfzyTh3gM=; b=IXQLggN8aAhnRhpVUQoNXI0TxOTwHQsBxbfl7NDrbw7bVG89tewHUdbj6o/76JYnN2hfg6 XNoN4zLYgtZn9RtkD6f5wiUTwZDVFG2qRwN2OYKZUXhJkT03SAhmtdMXqyLne7GC0YJT37 BLE/TDFihhwpqsULi54CXh45oviNb/51NDndL8tFg+DGKJ0+bRVUmHs5iKHFppv4fw+n5E 1Y8+YxgxKsu0Y9ErUUuLqDNFau+OIVzNK+M3pyHiatc5yxsl5GVw9ulyYz1hx711VQiyHz xxpH79r9JGHej/Xv62tioHd4NJvRax351vKi8/KZgyxrwuPt4yufc/vOPpzT1w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623102792; a=rsa-sha256; cv=none; b=DEOyadLauN38ZrV9hVMqzuJL4DpZsvq5+zB8XdKgurw09IWb7ygBupQvagjCusdbW5CI7k TYmQ8Gzc3mG76levVTWG1I304FEiviqJa1wdmIB5Ydn1Cdh1EtWleYHsVTqzT+bkuXCA38 eLUq9YxpzzyXFzZ5uARGpWZRv8huw57tooKkPVhaNkVhRJq64a9ktT2kGv3e94O4T6wXc/ 08snCtYuQ+dDAGZnaeDUFF2auQpsWsTdH6qN//KBydc/05+7uiG8Kn9ixqsItF2IldQNhJ 2LpHf62+Kn3gw2m1VLoJNE9WRuYfNCvIhBu+lXqYjs3Mu/RtEWTkJRcRmsedAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm1 header.b=t8SLFG6G; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=kzMTGvxM; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 3.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=carldong.me header.s=fm1 header.b=t8SLFG6G; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=kzMTGvxM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3C6522A6BE X-Spam-Score: 3.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: W3i76IZkPEfI > I’d write it like this: > > (lambda _ > ,@(if (hurd-target?) > '((substitute* …)) > '()) > > …) I'm not entirely familiar with the quoting here, but I trust that this is correct... Does the following patch look okay? --- This test fails on filesystems where tail detects that it cannot use inotify safely. See https://issues.guix.gnu.org/47935 for more details. * gnu/packages/base.scm (coreutils)[phases]: Disable inotify-dir-recreate tests. --- gnu/packages/base.scm | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index d30299a7b6..1ab50dfaf9 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -378,13 +378,17 @@ used to apply commands with arbitrarily long arguments.") (("/bin/sh") (which "sh"))) (substitute* (find-files "tests" "\\.sh$") (("#!/bin/sh") (string-append "#!" (which "sh")))))) - ,@(if (hurd-target?) - `((add-after 'unpack 'remove-tests - (lambda _ - (substitute* "Makefile.in" - ;; this test hangs - (("^ *tests/misc/timeout-group.sh.*") ""))))) - '())))) + (add-after 'unpack 'remove-tests + (lambda _ + ,@(if (hurd-target?) + '(substitute* "Makefile.in" + ;; this test hangs + (("^ *tests/misc/timeout-group.sh.*") "")) + '()) + (substitute* "Makefile.in" + ;; fails on filesystems where inotify cannot be used, + ;; more info in #47935 + (("^ *tests/tail-2/inotify-dir-recreate.sh.*") ""))))))) (synopsis "Core GNU utilities (file, text, shell)") (description "GNU Coreutils package includes all of the basic command-line tools that -- 2.31.1