From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gKlsLUVirWAeIgAAgWs5BA (envelope-from ) for ; Tue, 25 May 2021 22:47:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mLYZKUVirWA+agAAbx9fmQ (envelope-from ) for ; Tue, 25 May 2021 20:47:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FA401C1B2 for ; Tue, 25 May 2021 22:47:01 +0200 (CEST) Received: from localhost ([::1]:46776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldx6-0002LA-DZ for larch@yhetil.org; Tue, 25 May 2021 16:47:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llcVA-0000jd-95 for guix-patches@gnu.org; Tue, 25 May 2021 15:14:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llcVA-0004Jf-0y for guix-patches@gnu.org; Tue, 25 May 2021 15:14:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llcV8-00017Y-Rn for guix-patches@gnu.org; Tue, 25 May 2021 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48630] Acknowledgement ([PATCH] adds `ack' package and it's perl module dependency File::Next) Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 May 2021 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48630 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48630@debbugs.gnu.org Received: via spool by 48630-submit@debbugs.gnu.org id=B48630.16219699954225 (code B ref 48630); Tue, 25 May 2021 19:14:02 +0000 Received: (at 48630) by debbugs.gnu.org; 25 May 2021 19:13:15 +0000 Received: from localhost ([127.0.0.1]:46809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llcUM-000164-QY for submit@debbugs.gnu.org; Tue, 25 May 2021 15:13:14 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:44957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llcUK-00015q-2J for 48630@debbugs.gnu.org; Tue, 25 May 2021 15:13:12 -0400 Received: from silver (212-51-128-14.fiber7.init7.net [212.51.128.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA id B984740315 for <48630@debbugs.gnu.org>; Tue, 25 May 2021 21:13:05 +0200 (CEST) Date: Tue, 25 May 2021 21:12:59 +0200 From: Gabriel Wicki Message-ID: <20210525191259.23awunfcwdr6p3cg@silver> References: <20210524191054.7wtb4wopstgx2c77@silver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Tue, 25 May 2021 16:40:13 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621975621; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=5Jdn41N8Ba9XraDNOTKRhFUhhS8rXQBLM8X67g7Rc4c=; b=oU7uyYLXKnsHszLHM8bcXxj9zflESjr1JL3blVcC+a3D1IgLMzh76ePtcnB2tlMxxH5SzX YANNtEaIsRBskKpy6s/xTeBDeq0mwN5XdMwOEIT1kYaPegX997ltfm3pVtpnuJ5/Uq9lxj K8N2hVJSbAhru542ODnqA2eVxwFhYXJAjm29uhEtKmGU38x6KP76rpnVAUWKmapm3zmiIi DzkA18RiTygwM6Y7jobrFor4Dyihoi2OmM1I3fMyjVvjAMcLP/xiHF+4ATfWdHBE1e6psG gDAiePOGaXSdADPeTl12iw6M3S56dlExEcROYWl/0YzzNy2k68DizNlY8Wl5sA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621975621; a=rsa-sha256; cv=none; b=g6Mf2sdrvbKuYU88K4UEU1bgODbm8YBfqSStfPOZwr8cM9rYotZKMExnBwoSevaVfnRDTS ncmATR61zvgHMFdI8d0M99H9vM+AHWbxW7eXFIBK0gD5UWKTsiwKbuO+hyPzXdjjSFutVk inPVt7gd3cN58u9egXbaBDcnY6pggxQnO7HZ+ea2wwMRwVx5aAlbFDLunFsYt0GdHhnc8H inkmweJtYeN0RqViCfrnIXXTZ6qRrNuhRXHOXoGdvzWcRkLJELZfgwaX6ILq61iU10eS4Y dr5/MHeh0eNFbiZ9YflklGLZOlCVJtZtbEvWivUDhe5ucSnVm6Xd4dCC6A8uYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6FA401C1B2 X-Spam-Score: -0.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1JtLR9UdBOQQ thanks for the advice, i'll update and split the patch into a small series soon! the tests are deactivated because 3 of 841 fail. they seem to check some kind of shebang #! paths. see this excerpt from the build log: # Failed test 'Util::sets_match( TEST_TYPE with -t perl )' # at t/ack-type.t line 43. # actual[ # 't/swamp/0:1:#!/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/bin/perl -w', ... # ] # expected[ # 't/swamp/0:1:#!/usr/bin/perl -w', ... # ] these lines are being ignored by the patch-generated-file-shebangs phase, maybe because the #! aren't at the beginning of the line? i'm a total novice in Perl, so i'm not sure what exactly is happening there or why this is even tested. should i try and add my own version of a patch-shebang after the patch-generated-file-shebangs phase?