[bug#48295] [PATCH 0/1] gnu: Add python-sqlalchemy-stubs

[bug#48295] [PATCH 0/1] gnu: Add python-sqlalchemy-stubs

[BonfaceKilz]

Hi Guix! This package provides more precise static types and type inference
for SQLAlchemy framework.

BonfaceKilz (1):
  gnu: Add python-sqlalchemy-stubs.

 gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.31.1

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[BonfaceKilz]

* gnu/packages/databases.scm (python-sqlalchemy-stubs): New variable.
---
 gnu/packages/databases.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 2777293200..54cf394d17 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2021 Greg Hogan <code@greghogan.com>
 ;;; Copyright © 2021 David Larsson <david.larsson@selfhosted.xyz>
 ;;; Copyright © 2021 Pjotr Prins <pjotr.guix@thebird.nl>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -114,6 +115,7 @@
   #:use-module (gnu packages popt)
   #:use-module (gnu packages protobuf)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-check)
   #:use-module (gnu packages python-crypto)
   #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-web)
@@ -2926,6 +2928,30 @@ simple and Pythonic domain language.")
 (define-public python2-sqlalchemy
   (package-with-python2 python-sqlalchemy))
 
+(define-public python-sqlalchemy-stubs
+  (package
+    (name "python-sqlalchemy-stubs")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "sqlalchemy-stubs" version))
+       (sha256
+        (base32
+         "1bppjmv7v7m0q8gwg791pgxbx4ay7mna0zq204pn9vw28kfxcrf6"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-mypy" ,python-mypy)
+       ("python-typing-extensions"
+        ,python-typing-extensions)))
+    (home-page
+     "https://github.com/dropbox/sqlalchemy-stubs")
+    (synopsis "SQLAlchemy stubs and mypy plugin")
+    (description "This package contains type stubs and a mypy plugin to
+provide more precise static types and type inference for SQLAlchemy
+framework.")
+    (license license:expat)))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")
-- 
2.31.1

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]


Hi Bonface,

> +    (license license:expat)))

Save minor cosmetic changes, this packages LGTM. But, there is some
confusion with the license. The LICENSE file is Apache 2.0, but setup.py
says "MIT License". Could you clarify this with upstream?

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Bonface Munyoki K.]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

Hi Arun!

Arun Isaac <arunisaac@systemreboot.net> anaandika:

> Hi Bonface,
>
>> +    (license license:expat)))
>
> Save minor cosmetic changes, this packages LGTM. But, there is some
> confusion with the license. The LICENSE file is Apache 2.0, but setup.py
> says "MIT License". Could you clarify this with upstream?
>
Thanks for catching that. I've just created an
issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216


-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

bug#48296: [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]


> Thanks for catching that. I've just created an
> issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216

Thanks for reporting the bug. I changed the license in your package
description, made a few cosmetic changes and pushed to master.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Bonface Munyoki K.]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

>> Thanks for catching that. I've just created an
>> issue here: https://github.com/dropbox/sqlalchemy-stubs/issues/216
>
> Thanks for reporting the bug. I changed the license in your package
> description, made a few cosmetic changes and pushed to master.
>
> Thanks!
>
Thanks for taking the time to work on this. FWIW,
upstream updated the setup.py too.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]


> Thanks for taking the time to work on this. FWIW,
> upstream updated the setup.py too.

That's great, thank you! Next time we update this package, we will have
the fixed setup.py too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

[bug#48296] [PATCH 1/1] gnu: Add python-sqlalchemy-stubs.

[Bonface Munyoki K.]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Arun Isaac <arunisaac@systemreboot.net> anaandika:

>> Thanks for taking the time to work on this. FWIW,
>> upstream updated the setup.py too.
>
> That's great, thank you! Next time we update this package, we will have
> the fixed setup.py too.
>

Yup. This makes sense.

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: <https://upbookclub.com> | Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

bug#48295: [PATCH 0/1] gnu: Add python-sqlalchemy-stubs

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]


Hi Bonface,

It seems like you accidentally opened two bug reports. I'm closing this
one.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]