From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mAT3AvgHl2BCfAEAgWs5BA (envelope-from ) for ; Sat, 08 May 2021 23:51:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YHkZOvcHl2CGbwAAB5/wlQ (envelope-from ) for ; Sat, 08 May 2021 21:51:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8315718C04 for ; Sat, 8 May 2021 23:51:51 +0200 (CEST) Received: from localhost ([::1]:39298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfUrW-00067J-K7 for larch@yhetil.org; Sat, 08 May 2021 17:51:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfNLG-0000gP-V6 for bug-guix@gnu.org; Sat, 08 May 2021 09:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfNLG-0001ew-OA for bug-guix@gnu.org; Sat, 08 May 2021 09:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lfNLG-0001UK-Jm for bug-guix@gnu.org; Sat, 08 May 2021 09:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41948: Shepherd deadlocks Resent-From: Andrew Whatson Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 08 May 2021 13:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41948 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 41948@debbugs.gnu.org Received: via spool by 41948-submit@debbugs.gnu.org id=B41948.16204817705695 (code B ref 41948); Sat, 08 May 2021 13:50:02 +0000 Received: (at 41948) by debbugs.gnu.org; 8 May 2021 13:49:30 +0000 Received: from localhost ([127.0.0.1]:50422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfNKk-0001Tn-F2 for submit@debbugs.gnu.org; Sat, 08 May 2021 09:49:30 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:40951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfNKi-0001Th-5J for 41948@debbugs.gnu.org; Sat, 08 May 2021 09:49:28 -0400 Received: by mail-pf1-f176.google.com with SMTP id x188so9885230pfd.7 for <41948@debbugs.gnu.org>; Sat, 08 May 2021 06:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=w+c2fpTRlD7sCpi4p8jPE4mbLfTSL2QUr6wcBvrEXoE=; b=ZMgm2lPdtjImSVfpnZVxTpZZaB2BOIwSJruN1h7ucTTL0NBlId8eaNx0GB8g2jMd01 AJ5NbuOXzBHBYVgNSzrsfTsc7Pj7Q62l84WCClDRiAGdVCjI+YaB8WNbW2jVo2iJRkgn xkPlwWlPP9SLptrGQWiBkvlQY96O9H3HJO/YxkhVsPggyewwu3/rQMZTtB3EOrdfAhxU HZtOAon4qR6h6594/g8Mw41C34QxiHVQo34xALrQANKN+SJdD/KgI728egk2iFSy2hTc EFeP+ty+K+oMWZYpX+xUTb0znIj2Gpc1H8C4ILTN3DL9ORQknbVax3BUOkzfpiHO+OPZ oNJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w+c2fpTRlD7sCpi4p8jPE4mbLfTSL2QUr6wcBvrEXoE=; b=QXjNGhgFL6/PnjOHiFuTSxfG1gDarXItaeTuVV6t4aamihry1DP4K8IROrRpV0aFDB I0823OuRWgPyskTEXSitshcEl1cSDoacw8CH40bvOvADvMKL8zsPLdYSLhjD4ghw1OKw Ra7BfbPSf2HY3a/miYbTJXMTyWXzy6731KEMgZkVnotrzN+aRE+H3T/obHYpzszKyZBB raqHcn317dgRNrotPCIfoFJEhQGz0TKwHdHi40xc69aCLE+BEPTcMYOIjjn4dIHrWLOQ cds/NMfKyd771xL1OtwDhGjjKWpAi5ol6/D39WQ0iM+BRhlDvSU73kYW4GmhjQf3VAVd HWBQ== X-Gm-Message-State: AOAM530J6D98hwOXOh8ExyauTX9aQuSxdUigeBOd+MTkyiGQmhJ8UOZB i6DIg6XnD+n+Z3hb+Faebe+GSoyO8vw= X-Google-Smtp-Source: ABdhPJwu309skckJSh8G5uWEqEZD151JugKPWFbKPzb51JKiuxPYiXbRBdtjJ8dd6XaZV/L02YpxJQ== X-Received: by 2002:a65:564c:: with SMTP id m12mr564792pgs.298.1620481761918; Sat, 08 May 2021 06:49:21 -0700 (PDT) Received: from muon.fritz.box (220-235-201-222.tpgi.com.au. [220.235.201.222]) by smtp.gmail.com with ESMTPSA id u21sm6858442pfm.89.2021.05.08.06.49.20 for <41948@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 06:49:21 -0700 (PDT) From: Andrew Whatson Date: Sat, 8 May 2021 23:49:07 +1000 Message-Id: <20210508134908.3133397-1-whatson@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <87im3ta7dg.fsf@gnu.org> References: <87im3ta7dg.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sat, 08 May 2021 17:51:20 -0400 X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620510711; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=w+c2fpTRlD7sCpi4p8jPE4mbLfTSL2QUr6wcBvrEXoE=; b=nv1E7b6gWww54XAOKLxj4spu9IbH7+CVzLzsH83ZMx/pREQSso4PxYdL+w0p5Wtn6yTamw PWOR0Aj/dL7gdHopgNrmd1gxZje2sN90GVWihep+4m5mNnAwGnErzAZBNs1QbLRet4nBmA 5EHxB0R4cuhJmOe54tV2ooI7izXx1GziDfjUn/NLUW4WGTS3ld6YXiU3281dC4wenj1Onm 6H6kqZ482YYNsiRiAHMCgkLcsYREzN/XEXVIvjRu3Z7F5nhLZvrtZNftZNus54dxBQT6vo ZHmnVIpBZOf0i1+rmYEXcOfIry6RllmCeMw/C8sXwEi0xXdxll13jhBnuaQSEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620510711; a=rsa-sha256; cv=none; b=jmujz4Tsu82Ee4aQKW2MRk029dTVCGfhGJ5+pMCP8Ddt4MJinr2ddwmopBX1LukE4Hi1Aq eTmM7U6duE+/UBjkKvBXvSuXG9XDmAcODdUZVmLQmTXP7urIxi9YpP9fqn4nMqsdslmpwP lWaa5BhYrgVEO2KRDe7qZ/o1I3d74vmVwmydqnsDDZVNtNkZovqMlPTdQJirKX3S+XuuuQ 0TY4D6M6XigH6x9ePqvw5OPj48rsSLgD4DKZU3NjzXEn61+rv2uWUmHCiKG7bpjHfX3dlP I+WfFMCWamDRij/3e/YSVJpcKp60i9yjOM/udsyKqt/YO6WQgNzwCVKmcWgBGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZMgm2lPd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 3.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=ZMgm2lPd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 8315718C04 X-Spam-Score: 3.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9/3foGV5Fcwo Hi, I've reviewed the finalizer patch and made some changes to ensure that it works correctly if pipe creation or thread creation fail. Thread creation fails in an out-of-memory scenario, so this part can be verified by running Guile's test-out-of-memory test case. You'll need a libgc built with --disable-munmap for the test to survive long enough to retry launching the finalizer thread. Cheers!