From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 7AXiHPW0kWBgUQAAgWs5BA (envelope-from ) for ; Tue, 04 May 2021 22:56:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uFngF/W0kWCzNQAAB5/wlQ (envelope-from ) for ; Tue, 04 May 2021 20:56:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C00E1B758 for ; Tue, 4 May 2021 22:56:20 +0200 (CEST) Received: from localhost ([::1]:40932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le25a-0003X4-0O for larch@yhetil.org; Tue, 04 May 2021 16:56:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25K-0003Ww-QP for guix-patches@gnu.org; Tue, 04 May 2021 16:56:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1le25K-0000Wd-Hb for guix-patches@gnu.org; Tue, 04 May 2021 16:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1le25K-0008Pf-HL for guix-patches@gnu.org; Tue, 04 May 2021 16:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48230] [PATCH] tests: go: Rename and fix duplicate test. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 May 2021 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48230 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48230@debbugs.gnu.org Cc: francois.joulaud@radiofrance.com, maxim.cournoyer@gmail.com X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162016176032331 (code B ref -1); Tue, 04 May 2021 20:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 May 2021 20:56:00 +0000 Received: from localhost ([127.0.0.1]:55374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25I-0008PP-0i for submit@debbugs.gnu.org; Tue, 04 May 2021 16:56:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:42544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25E-0008PJ-NE for submit@debbugs.gnu.org; Tue, 04 May 2021 16:55:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25E-0003VV-8M for guix-patches@gnu.org; Tue, 04 May 2021 16:55:56 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:47042) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25C-0000OT-7H for guix-patches@gnu.org; Tue, 04 May 2021 16:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=jjppBQJmzoe6aO6RhcJQfGjObTgqZhBKisYXDq7uWII=; h=date:subject:cc:to: from; b=H2sP2OT55Kv0F7Y4tIolwgeJ4YBMaD6S16zOPHgyDmXxoXZPv+PX1ArY0TWDL6 usgAEWEcquR/DWE7FVlzks4L1iIak5PmO1VmrNqMuH6I513GRo/vI8/B5EkZ8qElGx9uV2 mABpCDBqMCBuFaDKWd8AbmBxHoNFp/ZYq29S5b/y3cSZQImR76rHz9OPb9lZ3o01VFQrxc pD0rCPy7kkUtpqRnEeN1k4NEAOdu3f/tw27coFwjPozXJuRsbp7gYvPTN4VyGtos1qeUot SMrq9wrZuPLQ4X6r6Bp9ILgP21AX8dR0bN2CpiaQfPBzzQALP6DB6CNiKiLG/INB2Nfr/Q == Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 41b309fa (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 4 May 2021 20:55:59 +0000 (UTC) Date: Tue, 4 May 2021 22:55:48 +0200 Message-Id: <20210504205548.4232-1-me@tobias.gr> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620161781; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=jjppBQJmzoe6aO6RhcJQfGjObTgqZhBKisYXDq7uWII=; b=NyAmw9H/ezBYVgq41o1xxL0pubud+GbgtQ7o+tRgym5n7DSrahzOLWqw2XecOulEF9oY0Z sA+AWyN0VNTiGUm4bnux/PmO7OIaZAgPGatpvfLsAzFrOVxDMdjTSrZGBaP9EwDezuUUj9 2ZomPAQjnouaQgNGZOIxwnQ0ZtXqfyzCizCo3ra/8RnjsSbkd0zRAU3miD4WoOs2t6eTlJ qwd/YjQtO8gDEkVepPJ0+D6LaL0TJlam7chtWJulehKPIfgMHLaltHwDNEp+TAGSDo6DvX OjWgV496KqM1hSU+unhx4uIirV3SbudxxEYuMkVODtjB2drNFq1qGcqhd7EPzw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620161781; a=rsa-sha256; cv=none; b=qqlO40yJl2AuI2y911LSqKunIyOh0vIQvRVcUlo74jDfze+WAhOzwqvPT97XuxFcU3OmbX vtO/mWEv1++Rt8GPuLNANoIizR35KBLL13y0L0WxccyKtgC3c27f74LWLRueX/D5vgSjAu fkn0PCt/OQi4AQEz9a9ObiyHwCwrAWzwqVmtxm4lcPTpna4W6+wqsSaxuQBhM8wekStl+X kL66OM5TFrlLwnjJpjqm66IC5tsvJ4AOJHC+VgoxKsFRNbRbCNMHtbYxsOOODmCua2o+ss kI1jum4M3gDAzY+OzqEwj+f7EXexYb+xHeCoLtVILgSdkkqaX2DUfz3h/rKRgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=H2sP2OT5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=H2sP2OT5; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1C00E1B758 X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1Vgo6XhI3JAM * tests/go.scm: Rename "go-version omited 'v' character" to "go-version without 'v' prefix" and change the code to match. --- Hi all, Found on a typo hunt. This is my best-effort guess at what was intended. Maybe I'm mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead? Let me know! Kind regards, T G-R tests/go.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/go.scm b/tests/go.scm index c33a834f69..565a0d451d 100644 --- a/tests/go.scm +++ b/tests/go.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2021 François Joulaud +;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1 "v1.0.2" (go-version->git-ref "v1.0.2")) -(test-equal "go-version omited 'v' character" - "v1.0.2" - (go-version->git-ref "v1.0.2")) +(test-equal "go-version without 'v' prefix" + "1.0.2" + (go-version->git-ref "1.0.2")) (test-equal "go-version with embedded git-ref" "65e3620a7ae7" -- 2.31.1