all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#46715] [PATCH] guix import: Fixing detection of Fortran files.
@ 2021-02-23 11:00 Mădălin Ionel Patrașcu
  2021-03-01 21:47 ` bug#46715: " Ricardo Wurmus
  0 siblings, 1 reply; 2+ messages in thread
From: Mădălin Ionel Patrașcu @ 2021-02-23 11:00 UTC (permalink / raw)
  To: 46715; +Cc: rekado, Mădălin Ionel Patrașcu

This fixes a bug whereby Guix importer considers files like .f.*
being Fortran's files.

(find-files dir "\\.f(90|95)?")

would consider a lot of files with an extension starting with f
being a Fortran file. The right way is to consider only files
ending with .f90 or .f95.

*guix/import/cran.scm: changing pattern of the detection for
Fortran's files to .f(90|95)$.

Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
---
 guix/import/cran.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/cran.scm b/guix/import/cran.scm
index e8caf080fd..dbc858cb84 100644
--- a/guix/import/cran.scm
+++ b/guix/import/cran.scm
@@ -361,7 +361,7 @@ empty list when the FIELD cannot be found."
 
 (define (directory-needs-fortran? dir)
   "Check if the directory DIR contains Fortran source files."
-  (match (find-files dir "\\.f(90|95)?")
+  (match (find-files dir "\\.f(90|95)$")
     (() #f)
     (_ #t)))
 
-- 
2.30.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#46715: [PATCH] guix import: Fixing detection of Fortran files.
  2021-02-23 11:00 [bug#46715] [PATCH] guix import: Fixing detection of Fortran files Mădălin Ionel Patrașcu
@ 2021-03-01 21:47 ` Ricardo Wurmus
  0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Wurmus @ 2021-03-01 21:47 UTC (permalink / raw)
  To: Mădălin Ionel Patrașcu; +Cc: 46715-done

Hi Mădălin,

Thanks!  I applied this with a few changes in the commit message.
(Commit 35814292b6.)

-- 
Ricardo




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-01 21:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 11:00 [bug#46715] [PATCH] guix import: Fixing detection of Fortran files Mădălin Ionel Patrașcu
2021-03-01 21:47 ` bug#46715: " Ricardo Wurmus

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git