* [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory.
@ 2021-02-20 23:58 Leo Prikler
2021-02-21 0:39 ` Leo Famulari
0 siblings, 1 reply; 3+ messages in thread
From: Leo Prikler @ 2021-02-20 23:58 UTC (permalink / raw)
To: 46671
This prevents generated launchers and desktop files from inadvertently
crashing if the directory name contains a space.
* gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s
to format data directory.
---
guix/build/renpy-build-system.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/guix/build/renpy-build-system.scm b/guix/build/renpy-build-system.scm
index 464fc97b13..66683971c5 100644
--- a/guix/build/renpy-build-system.scm
+++ b/guix/build/renpy-build-system.scm
@@ -57,7 +57,7 @@
(delete-file (string-append data "/renpy-build.json"))
(call-with-output-file launcher
(lambda (port)
- (format port "#!~a~%~a ~a \"$@\""
+ (format port "#!~a~%~a ~s \"$@\""
(which "bash")
(which "renpy")
data)))
@@ -77,8 +77,9 @@
(string-append out "/share/applications/" executable-name ".desktop")
#:name (assoc-ref json-dump "name")
#:generic-name (assoc-ref build "display_name")
- #:exec (string-append (which "renpy") " "
- out "/share/renpy/" directory-name)
+ #:exec (format #f "~a ~s"
+ (which "renpy")
+ (string-append out "/share/renpy/" directory-name))
#:categories '("Game" "Visual Novel")))
#t)
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory.
2021-02-20 23:58 [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory Leo Prikler
@ 2021-02-21 0:39 ` Leo Famulari
2021-02-24 0:11 ` bug#46671: " Leo Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2021-02-21 0:39 UTC (permalink / raw)
To: Leo Prikler; +Cc: 46671
On Sun, Feb 21, 2021 at 12:58:27AM +0100, Leo Prikler wrote:
> This prevents generated launchers and desktop files from inadvertently
> crashing if the directory name contains a space.
>
> * gnu/build/renpy-build-system.scm (install, install-desktop-file): Use ~s
> to format data directory.
s/gnu/guix
Otherwise LGTM if it fixes the problem for you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#46671: [PATCH] gnu: renpy-build-system: Quote data directory.
2021-02-21 0:39 ` Leo Famulari
@ 2021-02-24 0:11 ` Leo Prikler
0 siblings, 0 replies; 3+ messages in thread
From: Leo Prikler @ 2021-02-24 0:11 UTC (permalink / raw)
To: Leo Famulari; +Cc: 46671-done
Am Samstag, den 20.02.2021, 19:39 -0500 schrieb Leo Famulari:
> On Sun, Feb 21, 2021 at 12:58:27AM +0100, Leo Prikler wrote:
> > This prevents generated launchers and desktop files from
> > inadvertently
> > crashing if the directory name contains a space.
> >
> > * gnu/build/renpy-build-system.scm (install, install-desktop-file):
> > Use ~s
> > to format data directory.
>
> s/gnu/guix
>
> Otherwise LGTM if it fixes the problem for you.
I hope not too many packages are troubled by spaces in their directory
names, but it's better to be safe than to be sorry.
Pushed!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-24 0:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-20 23:58 [bug#46671] [PATCH] gnu: renpy-build-system: Quote data directory Leo Prikler
2021-02-21 0:39 ` Leo Famulari
2021-02-24 0:11 ` bug#46671: " Leo Prikler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.