From: "Ludovic Courtès" <ludo@gnu.org>
To: 45018@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#45018] [PATCH v2 0/6] Process and connection reuse for substitutions
Date: Sun, 6 Dec 2020 23:04:09 +0100 [thread overview]
Message-ID: <20201206220415.23279-1-ludo@gnu.org> (raw)
In-Reply-To: <87o8janf50.fsf@gnu.org>
Hello!
This update fixes issues that Chris uncovered during testing and
addresses comments Mathieu made. Changes since v1:
1. The daemon, in ‘SubstitutionGoal::handleChildOutput’, properly
deal with the case where ‘data’ contains several lines, such as a
“sha256:…” line and a “success” line.
2. ‘call-with-cached-connection’ catches exceptions that may be
raised by (web response) when reusing a stale socket.
3. The connection cache is now an alist instead of a hash table and
care is taken to evict old entries once it has reached
‘%max-cached-connections’.
4. Fixed typo in comment in (guix scripts substitute).
I’ll go ahead with this version soonish if there are no objections.
Ludo’.
Ludovic Courtès (6):
daemon: 'Agent' constructor takes a list of environment variables.
daemon: Use 'Agent' to spawn 'guix substitute --query'.
daemon: Factorize substituter agent spawning.
daemon: Run 'guix substitute --substitute' as an agent.
substitute: Cache and reuse connections while substituting.
daemon: Raise an error if substituter doesn't send the expected hash.
guix/http-client.scm | 12 +-
guix/progress.scm | 8 +-
guix/scripts/substitute.scm | 243 ++++++++++++++++++++++++------------
nix/libstore/build.cc | 173 +++++++++++++------------
nix/libstore/local-store.cc | 170 ++++++-------------------
nix/libstore/local-store.hh | 25 +---
nix/libutil/util.cc | 6 +-
nix/libutil/util.hh | 7 +-
tests/substitute.scm | 98 +++++++++------
9 files changed, 381 insertions(+), 361 deletions(-)
--
2.29.2
next prev parent reply other threads:[~2020-12-06 22:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 10:13 [bug#45018] [PATCH 0/6] Process and connection reuse for substitutions Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 1/6] daemon: 'Agent' constructor takes a list of environment variables Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query' Ludovic Courtès
2020-12-04 8:23 ` Mathieu Othacehe
2020-12-06 21:51 ` Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning Ludovic Courtès
2020-12-04 8:19 ` Mathieu Othacehe
2020-12-03 10:19 ` [bug#45018] [PATCH 4/6] daemon: Run 'guix substitute --substitute' as an agent Ludovic Courtès
2020-12-04 8:27 ` Mathieu Othacehe
2020-12-06 21:53 ` Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 5/6] substitute: Cache and reuse connections while substituting Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 6/6] daemon: Raise an error if substituter doesn't send the expected hash Ludovic Courtès
2020-12-03 11:48 ` [bug#45018] [PATCH 0/6] Process and connection reuse for substitutions 宋文武
2020-12-03 20:52 ` Ludovic Courtès
2020-12-04 8:34 ` Mathieu Othacehe
2020-12-06 22:04 ` Ludovic Courtès [this message]
2020-12-06 22:04 ` [bug#45018] [PATCH v2 1/6] daemon: 'Agent' constructor takes a list of environment variables Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query' Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 3/6] daemon: Factorize substituter agent spawning Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 4/6] daemon: Run 'guix substitute --substitute' as an agent Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 5/6] substitute: Cache and reuse connections while substituting Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 6/6] daemon: Raise an error if substituter doesn't send the expected hash Ludovic Courtès
2020-12-08 22:39 ` bug#45018: [PATCH v2 0/6] Process and connection reuse for substitutions Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206220415.23279-1-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=45018@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.