From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4PpBLgxevl/YTQAA0tVLHw (envelope-from ) for ; Wed, 25 Nov 2020 13:37:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0GhWKgxevl99XgAAB5/wlQ (envelope-from ) for ; Wed, 25 Nov 2020 13:37:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 516A19402B0 for ; Wed, 25 Nov 2020 13:37:16 +0000 (UTC) Received: from localhost ([::1]:46450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khuyv-00053t-V0 for larch@yhetil.org; Wed, 25 Nov 2020 08:37:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khuq4-0007Ym-LD for guix-devel@gnu.org; Wed, 25 Nov 2020 08:28:04 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:39618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khupz-00014F-Le; Wed, 25 Nov 2020 08:28:04 -0500 Received: from localhost (unknown [213.147.165.14]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 6EC7A336025C; Wed, 25 Nov 2020 14:27:48 +0100 (CET) Date: Wed, 25 Nov 2020 14:27:38 +0100 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: Phases and snippets no longer returning a Boolean Message-ID: <20201125142738.7b60ebf1@scratchpost.org> In-Reply-To: <87sg8ycpka.fsf@inria.fr> References: <87sg8ycpka.fsf@inria.fr> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/KqUoCLR9ZgN9iAu/iHqDR=Q"; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: NRuZSooue18o --Sig_/KqUoCLR9ZgN9iAu/iHqDR=Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Wed, 25 Nov 2020 00:17:41 +0100 Ludovic Court=C3=A8s wrote: > With these changes, the return value of origin snippets and build phases > is now ignored. Good riddance :) No, seriously, good change. > I only removed trailing #t in a couple of files unlikely to result in > merge conflicts down the road, as Marius rightfully suggested on IRC. I agree that we shouldn't graciously remove "#t"s in existing packages too much. It can just be done slowly as we touch each package anyway. Since returning #f was effectively broken anyway for a year now (it wouldn't cancel the build) I doubt we have any legitimate places in build phases whe= re it legitimately wants to cancel the build and thus returns #f, because that wouldn't have worked anyway. But the origin snippets, I'm not sure. I guess those are lower risk anyway since if the origin snippet doesn't like something, the result probably doesn't have all the files anyway--cancelled or not. Thanks for this change! --Sig_/KqUoCLR9ZgN9iAu/iHqDR=Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl++W8oACgkQ5xo1VCww uqVhgQgAkyMt33sDP+fPn7uhFJ6fppyzAPh8gZyBsi0ViMvC16YkDzeNk7erDGR/ 9MwEksiw33z1A6WqGutU08QC3RZHmVeLJRCDNL07jc25S7Tvj9wq05Q++JdZg+Jd WUKa7Ad2crnt5cGJln18fwe/kUgxIvZo41iXRGsPf2JyYMhNwTuzE6WzjK9EOySZ sCXigppSKKQPv7+6fzl6Dd9Nvm6MDqSsIysmIhmbLoQhMF4JIvDXLyC3xKdV/8fz EFIyGvcbvh+Jx+Ab3IRUSCyOkJJaPvU+AAYt0Tknxjy9dtb3DnpGogORtpyvF3RS 1G2ic3a0KPCs4JtdMQ1Lfv/vw0Mgbg== =kIZI -----END PGP SIGNATURE----- --Sig_/KqUoCLR9ZgN9iAu/iHqDR=Q--