From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Phases and snippets no longer returning a Boolean
Date: Wed, 25 Nov 2020 14:27:38 +0100 [thread overview]
Message-ID: <20201125142738.7b60ebf1@scratchpost.org> (raw)
In-Reply-To: <87sg8ycpka.fsf@inria.fr>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Hi Ludo,
On Wed, 25 Nov 2020 00:17:41 +0100
Ludovic Courtès <ludo@gnu.org> wrote:
> With these changes, the return value of origin snippets and build phases
> is now ignored.
Good riddance :)
No, seriously, good change.
> I only removed trailing #t in a couple of files unlikely to result in
> merge conflicts down the road, as Marius rightfully suggested on IRC.
I agree that we shouldn't graciously remove "#t"s in existing packages too
much. It can just be done slowly as we touch each package anyway.
Since returning #f was effectively broken anyway for a year now (it wouldn't
cancel the build) I doubt we have any legitimate places in build phases where
it legitimately wants to cancel the build and thus returns #f, because that
wouldn't have worked anyway.
But the origin snippets, I'm not sure. I guess those are lower risk anyway
since if the origin snippet doesn't like something, the result probably
doesn't have all the files anyway--cancelled or not.
Thanks for this change!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-25 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 23:17 Phases and snippets no longer returning a Boolean Ludovic Courtès
2020-11-25 10:53 ` 宋文武
2020-11-25 13:27 ` Danny Milosavljevic [this message]
2020-11-25 14:02 ` zimoun
2020-11-25 17:53 ` Leo Famulari
2020-11-27 10:59 ` Ludovic Courtès
2020-11-29 19:30 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125142738.7b60ebf1@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.