* [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
@ 2020-11-18 6:00 Oleg Pykhalov
2020-11-18 16:26 ` Danny Milosavljevic
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Pykhalov @ 2020-11-18 6:00 UTC (permalink / raw)
To: 44718
[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]
Hello,
According to Git bisect, the 977eb5d0 commit breaks docker-service-type
with the following error during “guix system build” or “guix system
reconfigure”:
guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
The following patch fixes this.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Fix docker-service-type file-system-/sys/fs/cgroup/blkio --]
[-- Type: text/x-patch, Size: 1174 bytes --]
From dcc259c3a33a470eee761f4deadf9149f0a65c55 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 18 Nov 2020 08:57:05 +0300
Subject: [PATCH] Fix file-system->shepherd-service-name.
This commit follow 977eb5d023cfdf8e336f1896480eea9cef5c04e9, which breaks
docker-service-type with error:
guix system: error: service 'dockerd' requires
'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
* gnu/services/base.scm (file-system->shepherd-service-name): Add '/' to
valid characters.
---
gnu/services/base.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 712b3a018f..6fc966e268 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -288,7 +288,7 @@ FILE-SYSTEM."
(define valid-characters
;; Valid store characters; see 'checkStoreName' in the daemon.
(string->char-set
- "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?="))
+ "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=/"))
(define mount-point
(string-map (lambda (chr)
--
2.29.2
[-- Attachment #1.3: Type: text/plain, Size: 8 bytes --]
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
2020-11-18 6:00 [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio Oleg Pykhalov
@ 2020-11-18 16:26 ` Danny Milosavljevic
2020-11-18 21:26 ` Marius Bakke
0 siblings, 1 reply; 5+ messages in thread
From: Danny Milosavljevic @ 2020-11-18 16:26 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 44718
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
Hi,
On Wed, 18 Nov 2020 09:00:34 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:
> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
> with the following error during “guix system build” or “guix system
> reconfigure”:
>
> guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
I can confirm this bug.
However, I cannot say one way or another where the patch is the right fix.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
2020-11-18 16:26 ` Danny Milosavljevic
@ 2020-11-18 21:26 ` Marius Bakke
2020-11-19 0:26 ` Danny Milosavljevic
2020-11-20 5:11 ` Oleg Pykhalov
0 siblings, 2 replies; 5+ messages in thread
From: Marius Bakke @ 2020-11-18 21:26 UTC (permalink / raw)
To: Danny Milosavljevic, Oleg Pykhalov; +Cc: 44718
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> skriver:
> Hi,
>
> On Wed, 18 Nov 2020 09:00:34 +0300
> Oleg Pykhalov <go.wigust@gmail.com> wrote:
>
>> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
>> with the following error during “guix system build” or “guix system
>> reconfigure”:
>>
>> guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
>
> I can confirm this bug.
>
> However, I cannot say one way or another where the patch is the right fix.
I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
can you confirm?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
2020-11-18 21:26 ` Marius Bakke
@ 2020-11-19 0:26 ` Danny Milosavljevic
2020-11-20 5:11 ` Oleg Pykhalov
1 sibling, 0 replies; 5+ messages in thread
From: Danny Milosavljevic @ 2020-11-19 0:26 UTC (permalink / raw)
To: Marius Bakke; +Cc: Oleg Pykhalov, 44718
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
Hi,
On Wed, 18 Nov 2020 22:26:38 +0100
Marius Bakke <marius@gnu.org> wrote:
> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?
Yes, it is indeed fixed for me.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio
2020-11-18 21:26 ` Marius Bakke
2020-11-19 0:26 ` Danny Milosavljevic
@ 2020-11-20 5:11 ` Oleg Pykhalov
1 sibling, 0 replies; 5+ messages in thread
From: Oleg Pykhalov @ 2020-11-20 5:11 UTC (permalink / raw)
To: 44718
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
Marius Bakke <marius@gnu.org> writes:
[…]
> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?
Yes, closing the issue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-20 5:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-18 6:00 [bug#44718] Fix dockerd requires file-system-/sys/fs/cgroup/blkio Oleg Pykhalov
2020-11-18 16:26 ` Danny Milosavljevic
2020-11-18 21:26 ` Marius Bakke
2020-11-19 0:26 ` Danny Milosavljevic
2020-11-20 5:11 ` Oleg Pykhalov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.