From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 44663@debbugs.gnu.org
Subject: [bug#44663] [PATCH] ui: Launch $PAGER through the shell.
Date: Sun, 15 Nov 2020 19:47:26 +0100 [thread overview]
Message-ID: <20201115184726.29944-1-me@tobias.gr> (raw)
This is the convention elsewhere and sounds like the right thing to do.
* guix/ui.scm (call-with-paginated-output-port): Substitute OPEN-PIPE
for OPEN-PIPE*.
Reported by Daniel Brooks <db48x@db48x.net>.
---
guix/ui.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/guix/ui.scm b/guix/ui.scm
index 4e686297e8..2b7d9dd64b 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -72,7 +72,7 @@
#:use-module (ice-9 match)
#:use-module (ice-9 format)
#:use-module (ice-9 regex)
- #:autoload (ice-9 popen) (open-pipe* close-pipe)
+ #:autoload (ice-9 popen) (open-pipe close-pipe)
#:autoload (system base compile) (compile-file)
#:autoload (system repl repl) (start-repl)
#:autoload (system repl debug) (make-debug stack->vector)
@@ -1673,9 +1673,9 @@ zero means that PACKAGE does not match any of REGEXPS."
;; instead of 'r': this strips hyperlinks but allows 'less' to make a
;; good estimate of the line length.
(let ((pager (with-environment-variables `(("LESS" ,less-options))
- (open-pipe* OPEN_WRITE
- (or (getenv "GUIX_PAGER") (getenv "PAGER")
- "less")))))
+ (open-pipe (or (getenv "GUIX_PAGER") (getenv "PAGER")
+ "less")
+ OPEN_WRITE))))
(dynamic-wind
(const #t)
(lambda () (proc pager))
--
2.29.2
next reply other threads:[~2020-11-15 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:47 Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-11-15 19:46 ` [bug#44663] [PATCH] ui: Launch $PAGER through the shell Tobias Geerinckx-Rice via Guix-patches via
2020-11-15 20:46 ` Ludovic Courtès
2020-11-15 21:38 ` Daniel Brooks
2020-11-16 8:16 ` Ludovic Courtès
2020-11-29 16:43 ` [bug#44663] [PATCH v2] ui: Handle multiword and empty $PAGER values Tobias Geerinckx-Rice via Guix-patches via
2020-11-29 16:56 ` Tobias Geerinckx-Rice via Guix-patches via
2021-08-03 20:02 ` bug#44663: [PATCH] ui: Launch $PAGER through the shell Maxim Cournoyer
2020-11-29 16:52 ` [bug#44663] " Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115184726.29944-1-me@tobias.gr \
--to=guix-patches@gnu.org \
--cc=44663@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.