From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SD/dIq0ToV/OIwAA0tVLHw (envelope-from ) for ; Tue, 03 Nov 2020 08:24:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gIC4Hq0ToV9sKQAAbx9fmQ (envelope-from ) for ; Tue, 03 Nov 2020 08:24:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0801D9405D1 for ; Tue, 3 Nov 2020 08:24:12 +0000 (UTC) Received: from localhost ([::1]:42490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZrbu-0006us-6X for larch@yhetil.org; Tue, 03 Nov 2020 03:24:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZrbm-0006uM-M7 for bug-guix@gnu.org; Tue, 03 Nov 2020 03:24:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZrbm-0001CN-Cb for bug-guix@gnu.org; Tue, 03 Nov 2020 03:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZrbm-0006sf-8a for bug-guix@gnu.org; Tue, 03 Nov 2020 03:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44254: Performance of package input rewriting Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 03 Nov 2020 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44254 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 44254-submit@debbugs.gnu.org id=B44254.160439183226433 (code B ref 44254); Tue, 03 Nov 2020 08:24:02 +0000 Received: (at 44254) by debbugs.gnu.org; 3 Nov 2020 08:23:52 +0000 Received: from localhost ([127.0.0.1]:43264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrbc-0006sH-CG for submit@debbugs.gnu.org; Tue, 03 Nov 2020 03:23:52 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrbb-0006s4-7Q for 44254@debbugs.gnu.org; Tue, 03 Nov 2020 03:23:51 -0500 Received: by mail-wr1-f52.google.com with SMTP id x7so17489777wrl.3 for <44254@debbugs.gnu.org>; Tue, 03 Nov 2020 00:23:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leibniz-psychology-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L1beBSc/H4MF13ftalbYuwlrusr2p0oQ5kcHvtZeGbA=; b=XaG84lF5UWAfeTmnueoxG+84Gz8iiGvrTH+G4IChyvRwAKnnYHoSBCRUT2st3dMS/A yFGWZ3elIgHDcwPALEUvcRMCS0ANYxGo/HL33e5qT2NtPTlMgb6hbdhM8gwtIFW8vH59 YXjIACiYN3p0PVgjeRWyLugeFVeuE3e47CSCO3sufPyS07tadRce+ofWENbxAiSor43F I7vV23pRracIKXKeBidKmxbIyvZGf0dcgPn3V04Eb9hYHVx5k4RhxElsJy2736bOHjwW ecmLFxzO9WCc7mzwR2Jr1rdihL3tr1/NavZWCh1oLc8smIL9cct7hw6ghezaQ+kdoY5e upNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L1beBSc/H4MF13ftalbYuwlrusr2p0oQ5kcHvtZeGbA=; b=C5gHZeiU2g+/lvZKhEVUfWnYzy7TYl/+smj+EzJ5KKgOoKIZfu33/oO46XmYcKae5T sdn5bjsm1XPDBgND/LOH2oe2KsS4b5s8fhR8IIlK4PXzaN9hp8/dwVr+uRrWWt/6YSHU VwwydrxU7GCguRRD9D6oyntTalP7APRgfTBfuI4ONCo5Ob2Yq4DUi3RS2Iit+3tVnbMZ BKzmHh8qo7SX8/Mqi8RVEM+TtRwd4fIadxyGphGiUc0KU3IpKSa/lM4VpnllyEnbx45N Fq4vDUi+sbcG+uFIc8HFDeKHekzual3XvhAldeTfbBF+91yqM9jEdD4YaEcDlQpKCjn0 yWIg== X-Gm-Message-State: AOAM531XhGYv46/mUU87ZmQntOVAszVYajJDtOs1hxg+uC9wNTZRNfUF 3bcrDMv1urSe1guWZMLX3G1c5RyEMFARwqNEoAOdDw6VTFCSa27js+FO6ubzLN92PuzdrY3Au6/ Phwpw+hqfv7sCNyXKI2X3nuxGCSdfFyYVxhTOPU2OjArLtmdc7d3olNLefy7nKa96s6BQx98vtf AY6jo= X-Google-Smtp-Source: ABdhPJzUOrM2HFoASV0O/1oUhWjhh4z7ATfsFFUov8ZJJLGvka5C8McEP4ChakSSCj8hXwAyEz/9Rw== X-Received: by 2002:adf:de89:: with SMTP id w9mr24522866wrl.212.1604391825321; Tue, 03 Nov 2020 00:23:45 -0800 (PST) Received: from localhost (dynamic-2a01-0c23-7840-f200-1dfb-7920-a3a3-0bf8.c23.pool.telefonica.de. [2a01:c23:7840:f200:1dfb:7920:a3a3:bf8]) by smtp.gmail.com with ESMTPSA id x10sm24419895wrp.62.2020.11.03.00.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 00:23:44 -0800 (PST) Date: Tue, 3 Nov 2020 09:23:43 +0100 From: Lars-Dominik Braun Message-ID: <20201103082343.GC3127@zpidnp36> References: <20201030084245.GB3128@zpidnp36> <87tuuavgg5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mvpLiMfbWzRoNl4x" Content-Disposition: inline In-Reply-To: <87tuuavgg5.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44254@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=leibniz-psychology-org.20150623.gappssmtp.com header.s=20150623 header.b=XaG84lF5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: hBYqKhL4s3cY --mvpLiMfbWzRoNl4x Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Ludo, > I guess it=E2=80=99s easy to end up creating huge object graphs. Here=E2= =80=99s an > example of an anti-pattern: >=20 > (define a > ((package-input-rewriting x) ((package-input-rewriting y) p1)))=20 >=20 > (define b > ((package-input-rewriting x) ((package-input-rewriting y) p2))) >=20 > The correct use is: >=20 > (define transform > (package-input-rewriting (append x y))) >=20 > (define a (transform p1)) > (define b (transform p2)) that sounds like a section for the cookbook :) > It seems to me that you=E2=80=99re redefining a dependency graph, node by= node. > Thus, you probably don=E2=80=99t need =E2=80=98package-input-rewriting=E2= =80=99 here. What you > did in Guix-Science commit 972795a23cc9eb5a0bb1a2ffb5681d151fc4d4b0 > looks more appropriate to me, in terms of style and semantics. Okay, got it. My initial concern was that rewriting the graph =E2=80=9Cby h= and=E2=80=9D (i.e. alist-delete) would be tedious and error-prone. Thank you very much, Lars --=20 Lars-Dominik Braun Wissenschaftlicher Mitarbeiter/Research Associate www.leibniz-psychology.org ZPID - Leibniz-Institut f=C3=BCr Psychologie / ZPID - Leibniz Institute for Psychology Universit=C3=A4tsring 15 D-54296 Trier - Germany Tel.: +49=E2=80=93651=E2=80=93201-4964 --mvpLiMfbWzRoNl4x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl+hE4sACgkQQhN3ARo3 hEZxzgwA0HnQCSUKVxjo9Q0EPYBRZR5OBV1AADcFQ+aLy48K2F/5oS6+Dm5fsK3o Wpog7EbunDAub8ry3oAfqnAMDfmLL0mLFiWpIZpLp5UEMnRpnc9PxifWvJRA3SAq DAhtMhBkEjuJ48+y4IxzFK7BzWTdTTuwUy6fv0Um7Bzy6uh515D9r0pJZ33EJunU GufM1llTjre+9rDo+orXWy52TwlqbiNaZm58tJ5DmrLeoOS5l8DoFcCA4Y076KPD 91O/TXQMwU2a9pRwrBu+p1i+q9mjbHhJJVXZNJjvKQPMo6tiuS7z9+1LD2+0I4t6 SC3rkEyXOpx49nV/yBzo6+K902MzqPEy97SfQKmeNLkO5rTuIMK7Z8auu4mFP8Do o+cyPRC/tl2UqJPDAK11tXrDj+C5TGsDpGsVNvM6MkoeXoMQdjQzr/YdFT/uASjA 1/Wf2UINl/Rlfu0tZtI4UY2csHlJjy21fDyx9X4w+arBQVFh5YyC+fBv4TtIikJ6 jluKAbfR =jZax -----END PGP SIGNATURE----- --mvpLiMfbWzRoNl4x--