From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EHZPAhgjnl8iKQAA0tVLHw (envelope-from ) for ; Sun, 01 Nov 2020 02:53:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0IHdORcjnl+aJwAAbx9fmQ (envelope-from ) for ; Sun, 01 Nov 2020 02:53:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68B239403CC for ; Sun, 1 Nov 2020 02:53:11 +0000 (UTC) Received: from localhost ([::1]:55138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZ3UU-0000DZ-EX for larch@yhetil.org; Sat, 31 Oct 2020 22:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZ3UN-0000BU-4O for guix-patches@gnu.org; Sat, 31 Oct 2020 22:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZ3UM-00057h-RL for guix-patches@gnu.org; Sat, 31 Oct 2020 22:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZ3UM-0000p7-QE for guix-patches@gnu.org; Sat, 31 Oct 2020 22:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44174] [PATCH 00/16] Add hledger and its dependencies. Resent-From: Carlo Holl Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 01 Nov 2020 02:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 44174@debbugs.gnu.org Received: via spool by 44174-submit@debbugs.gnu.org id=B44174.16041991813151 (code B ref 44174); Sun, 01 Nov 2020 02:53:02 +0000 Received: (at 44174) by debbugs.gnu.org; 1 Nov 2020 02:53:01 +0000 Received: from localhost ([127.0.0.1]:35207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ3UK-0000oi-ND for submit@debbugs.gnu.org; Sat, 31 Oct 2020 22:53:01 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZ2qC-0008BH-H6 for 44174@debbugs.gnu.org; Sat, 31 Oct 2020 22:11:33 -0400 Received: by mail-pg1-f194.google.com with SMTP id r10so7973049pgb.10 for <44174@debbugs.gnu.org>; Sat, 31 Oct 2020 19:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k0oTbDIDDeZfwMm+qS56XAoVJIcrJMk1Dpz4KmBFKro=; b=B38oihTIPuIB2kcp0Uo9/DCOfw3yqkh9g59tkwCGTQRxiyebv6fPwBmzG3Ut1I0Wod Fmy6ysoPPLsaqXorZeNt/306HyuUKl7aXhoF4gfUmxk5G1icTehpMwb9hpi9hRolp+dO PV/rmSyB4Z0rh70qvAQwseBB3A6yU6N80U0GORV/K1/C+P8FlcOoCXwcOiq3yhMKTUW2 FyUQsrbfqba/gkcNhtNgmKywHNW73b9EolHh3dPI+UzpXTfwbmQA6Sn9Xw3gSLXTgNlw t6Qz2IwgQEcne3lRASd1Swp836y2+a76utpqTazAihb1tAJjp+yL41LMbxbPlnEqOEoU GiFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k0oTbDIDDeZfwMm+qS56XAoVJIcrJMk1Dpz4KmBFKro=; b=ihiRxlvShJ38A1+Y1vS6DmEPY5RYfSRR3u4uBa+SNlgbrQN3AQHG2c/J+baUTUSHpo N9i/EebADtwuk4O96A1HCQgx0eRZpKKFqqitpeiKa3pMvYwSTrQcFlPjhoCQ4hgmR9Dc P5HXKzfWdZnxufgGiZ7VCNH6s2xIDzjHBDr/eECMI0V/gkjweskQqWKDCJ1SWwXtM6lf uqCI2tYJGZ8Sl8c7I9vPFEKqedABBlN+jXWepiSLCAhAG9gqjcQozMc6nf/CY+JUZUiZ WvIKP0rPRr6G3m81G5amLn6pSQd2qdMJf3BbCMhWXrI2vm1Jky/7DPCG9OzF9Mpi1we3 2ipw== X-Gm-Message-State: AOAM531BT/4I1OpSVdwLLNwPQRcWettM6jIUgEa03ltCj1m9WvlIB85l OvCAqcBkQ/X65rjYubo+4sw= X-Google-Smtp-Source: ABdhPJzhzdIPkAgym0vuKzhwGtst8QE5+IKY2ZS4NKg3OHFK2YYBRCzR+8uYnGdKTLuCybPJftSgCQ== X-Received: by 2002:a63:4825:: with SMTP id v37mr8089588pga.256.1604196686732; Sat, 31 Oct 2020 19:11:26 -0700 (PDT) Received: from localhost ([2603:3024:1704:300::8401]) by smtp.gmail.com with ESMTPSA id h16sm102233pjz.10.2020.10.31.19.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Oct 2020 19:11:26 -0700 (PDT) Date: Sat, 31 Oct 2020 19:11:25 -0700 From: Carlo Holl Message-ID: <20201101021125.vfvyzwwy4skmx26t@cehdev> References: <20201023074653.8885-1-carloholl@gmail.com> <87eelnb9ik.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <87eelnb9ik.fsf@cbaines.net> X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Sat, 31 Oct 2020 22:53:00 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=B38oihTI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: NNka9mOZ1nae On 24.10.2020 22:26, Christopher Baines wrote: > >Carlo Holl writes: > >> Guix, >> >> This patch series adds hledger, a plaintext accounting >> program. hledger started as a Haskell reimplementation of Ledger >> CLI. I use hledger regularly to manage personal finances and those of >> several businesses, and would not be suprised to find other hledger >> users in the Guix community. >> >> More information is available at https://hledger.org. > >Hi Carlo, thanks for the patches! > >> A couple of notes: >> >> 1. The hledger package is placed in (gnu packages finance), and >> its dependencies in (gnu packages haskell-xyz). > >That sounds good :) > >> 2. The hledger package is *not* prefixed with 'ghc', but its >> dependencies are. > >Also fine. > >> 3. The package ghc-doctest was bumped (minor version), affecting several dependent packages. >> I was able to build most of these affected packages (querying guix refresh --list-dependents), >> but it was taking forever so I cut that effort short. I consider this a rough heuristic to determine >> that there are no substantial changes associated with this >> version bump. > >Sounds good. > >> 4. I'm not terribly familiar with the Texinfo format, so there are >> likely some rough edges there. > >Looks like you've done pretty well from what I've seen :) > >> 5. I am able to build hledger and its dependencies without error, but was unsuccessful building >> on different architectures with qemu. I wasn't even able to build GHC under qemu so I didn't bother >> digging any further. > >No problem, if it builds on x86_64-linux, that's good enough at least >initially. > >> This is my first contribution to Guix, and I'm also not a Haskell >> expert, so expect some headaches. I am happy to attend to any issues >> as best I am able. > >Great, I'll make some more comments on the individual patches, a few >general comments though: > > - The commits should include changelog entries. For new packages, these > are pretty easy to write, it's just: > >* gnu/packages/FILE.scm (PACKAGE): New variable. > > - The indentation looks off in places, there's some stuff here about > indentation [1]. What editor are you using? > >1: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html > > >Let me know if you have any questions, and it would be great if you >could send an updated set of patches. > >Thanks, > >Chris Chris, Apologies for the late reply, I was away last week. Thank you for the feedback. I've send a new patch series that I think addresses all the issues you raised. Best, -- Carlo Holl carloholl@gmail.com