From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
To: "Ricardo Wurmus" <rekado@elephly.net>, "Ludovic Courtès" <ludo@gnu.org>
Cc: 44254@debbugs.gnu.org
Subject: bug#44254: Performance of package input rewriting
Date: Fri, 30 Oct 2020 09:42:45 +0100 [thread overview]
Message-ID: <20201030084245.GB3128@zpidnp36> (raw)
In-Reply-To: <87o8km301f.fsf@gnu.org> <87imav1lwp.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
Hi,
> Yes, that’s a possible culprit. Try passing #:deep? #f if it works for
> your use case.
Yeah, that brings it down to ~8s, which is still alot.
> Another thing to look at is the <package> object graph (as show by ‘guix
> graph’). Input rewriting can duplicate parts of the graph, which in
> turn defeats package->derivation memoization. Just looking at the
> number of nodes in the graph can give hints.
Aha, it’s 913 nodes without rewriting, 13916 with rewriting (#:deep? #t) and
4286 with rewriting (#:deep? #f) as determined by a rather ad-hoc `guix graph
-L . -t package python-jupyterlab | grep 'shape = box' | wc -l`. That seems way
too much. Does that mean I’m using package rewriting in the wrong way or is
that a bug?
Unfortunately I don’t have a short reproducer right now. I’ll look at the graph
more closely to figure out which parts are actually duplicated. Maybe I can
create a reproducing testcase with more information.
Cheers,
Lars
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2020-10-30 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 13:26 bug#44254: Performance of package input rewriting Lars-Dominik Braun
2020-10-27 14:14 ` zimoun
2020-10-28 14:19 ` Ludovic Courtès
2020-10-27 19:58 ` Ricardo Wurmus
2020-10-30 8:42 ` Lars-Dominik Braun [this message]
2020-10-31 10:27 ` Ludovic Courtès
2020-11-03 8:23 ` Lars-Dominik Braun
2020-11-03 9:32 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030084245.GB3128@zpidnp36 \
--to=ldb@leibniz-psychology.org \
--cc=44254@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.