all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tanguy Le Carrour <tanguy@bioneland.org>
To: Leo Famulari <leo@famulari.name>
Cc: 44275@debbugs.gnu.org
Subject: [bug#44275] [PATCH] gnu: Add python-pydub.
Date: Thu, 29 Oct 2020 09:26:57 +0100	[thread overview]
Message-ID: <20201029082657.xb3we5aqncp7qqci@rafflesia> (raw)
In-Reply-To: <20201028163450.GE12095@jasmine.lan>

Hi Leo,

Thanks for taking the time to review this!

Le 10/28, Leo Famulari a écrit :
> On Wed, Oct 28, 2020 at 09:56:54AM +0100, Tanguy Le Carrour wrote:
> > * gnu/packages/python-xyz.scm (python-pydub): New variable.
> 
> > +    (propagated-inputs
> > +     `(("ffmpeg" ,ffmpeg)
> > +       ("python-scipy" ,python-scipy)))
> 
> It would be good if store references to these programs could be "baked in" to
> the pydub code, rather than propagated. Can you take a look at how they
> are called and see if that is feasible? Often there is only one location
> that must be patched.

mmm… haven't done that so far, it would be my first time! Always good to
learn new tricks! :-)
I'll try to patch the call to `ffmpeg` and let you know.

`python-scipy` is a different problem, though. This module is not listed
as a requirement, but… it's required at run time. Event if I don't see the
point of having SciPy loaded when you want to manipulate audio. But that's
a different matter!

Regards,

-- 
Tanguy




  reply	other threads:[~2020-10-29  8:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  8:56 [bug#44275] [PATCH] gnu: Add python-pydub Tanguy Le Carrour
2020-10-28 16:34 ` Leo Famulari
2020-10-29  8:26   ` Tanguy Le Carrour [this message]
2020-10-29 14:14     ` Leo Famulari
2020-10-29 14:39       ` Tanguy Le Carrour
2020-10-29 21:50       ` Leo Famulari
2020-10-30  9:19         ` Tanguy Le Carrour
2020-10-30 20:42           ` Leo Famulari
2020-10-29  9:09 ` [bug#44275] [PATCH v2] " Tanguy Le Carrour
2020-10-30 20:40   ` bug#44275: " Leo Famulari
2020-10-30 21:10     ` [bug#44275] " Tanguy LE CARROUR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029082657.xb3we5aqncp7qqci@rafflesia \
    --to=tanguy@bioneland.org \
    --cc=44275@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.