From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id s0NzOzs+kV/ZJwAA0tVLHw (envelope-from ) for ; Thu, 22 Oct 2020 08:09:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8GxKNTs+kV8QRwAAbx9fmQ (envelope-from ) for ; Thu, 22 Oct 2020 08:09:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 553E6940222 for ; Thu, 22 Oct 2020 08:09:31 +0000 (UTC) Received: from localhost ([::1]:59230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVUwH-0000M8-UJ for larch@yhetil.org; Thu, 22 Oct 2020 03:23:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVUwB-0000KV-78 for guix-patches@gnu.org; Thu, 22 Oct 2020 03:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVUwA-0008NX-7m for guix-patches@gnu.org; Thu, 22 Oct 2020 03:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kVUwA-0004YC-3M for guix-patches@gnu.org; Thu, 22 Oct 2020 03:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core. Resent-From: Tanguy Le Carrour Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Oct 2020 07:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44077 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 44077@debbugs.gnu.org Received: via spool by 44077-submit@debbugs.gnu.org id=B44077.160335133617423 (code B ref 44077); Thu, 22 Oct 2020 07:23:02 +0000 Received: (at 44077) by debbugs.gnu.org; 22 Oct 2020 07:22:16 +0000 Received: from localhost ([127.0.0.1]:51295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVUvP-0004Wv-TN for submit@debbugs.gnu.org; Thu, 22 Oct 2020 03:22:16 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:45773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVUvO-0004Wh-KM for 44077@debbugs.gnu.org; Thu, 22 Oct 2020 03:22:15 -0400 X-Originating-IP: 176.159.32.89 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D7B24C0008; Thu, 22 Oct 2020 07:22:07 +0000 (UTC) Date: Thu, 22 Oct 2020 09:22:07 +0200 From: Tanguy Le Carrour Message-ID: <20201022072207.nk5elqr53zoxqjbi@rafflesia> References: <20201019132649.13548-1-tanguy@bioneland.org> <20201019132912.13941-1-tanguy@bioneland.org> <87zh4h6roz.fsf@nicolasgoaziou.fr> <20201020153036.bwradn2fitkmfgfy@rafflesia> <87h7qn746a.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h7qn746a.fsf@nicolasgoaziou.fr> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: gqhPVuNP7Hdx Hi Nicolas, Le 10/21, Nicolas Goaziou a écrit : > Tanguy Le Carrour writes: > > Le 10/20, Nicolas Goaziou a écrit : > >> > + (base32 > >> > + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka")))) > >> > >> Nitpick: move the string on the same line as `base32'. > > > > I have no clue what the rule is, but… most (but not all!?) packages in > > `gnu/packages/python-xyz.scm` have the string on a new line. > > Note that "everyone else does this" may not be a strong reason to do > something. ;) +1 :-) The thing is, I'm not yet sure to understand the coding style, and `etc/indent-code.el` leaves you some (too much?) freedom. I've been happily using Black [1] to format my Python code for some time now, and I *might* have become a bit lazy! [1]: https://github.com/psf/black > I suspect that most packages in this file come from the "pypi" importer, > which automatically adds this newline character, for some reason. > > > I'll leave it on a new line if it's OK with you. You've got me there! I imported it! Actually, I'd rather put everything on a single line if it fits (and `indent-code.el` does not complain when I put `sha256` and `base32` on the same line). I just didn't want to be pointed at as "the guys who does not split the line". ^_^' > This spurious newline character hurts my eyes and my logic, but > ultimately, it will not hurt me. So, if that's important to you, go > ahead. Updated and pushed! Thanks again for your time and your advice! -- Tanguy