bug#43950: lz4 CC=gcc - Why?

bug#43950: lz4 CC=gcc - Why?

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

* lz4 has "CC=gcc".  Shouldn't that be (string-append "CC=" (cc-for-target)) ?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#43950: lz4 CC=gcc - Why?

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Danny,

Danny Milosavljevic 写道：
> lz4 CC=gcc - Why?

For the same reason as the *hundreds* of other ‘CC=gcc’ 
occurrences in the tree: CC-FOR-TARGET is new.  Out of all of 
them, why are you so interested in LZ4 (I think this is your 
second mail on it :-)?

I'm currently slogging through the "CC=gcc"s & removing as many as 
possible; not fun work but can be done completely off-line.

LZ4 tweaked in 2b6ecdf41a09ab9ecae06d7c537583a2f0f28efc,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

bug#43950: lz4 CC=gcc - Why?

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hi,

On Mon, 12 Oct 2020 15:18:26 +0200
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> For the same reason as the *hundreds* of other ‘CC=gcc’ 
> occurrences in the tree: CC-FOR-TARGET is new.  Out of all of 
> them, why are you so interested in LZ4

It's a dependency of genimage (via squashfs-tools).  Breaking it breaks
guix system image generation.

It's a dependency of u-boot.  Breaking it breaks booting on all ARM
machines.

So I rather didn't want to touch it without confirmation...

> (I think this is your  second mail on it :-)?

Ludo said to send extra mails for each--so that's what I am doing.

> LZ4 tweaked in 2b6ecdf41a09ab9ecae06d7c537583a2f0f28efc,

Thanks!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#43950: lz4 CC=gcc - Why?

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi Danny,

Danny Milosavljevic 写道：
> It's a dependency of genimage (via squashfs-tools).  Breaking it 
> breaks
> guix system image generation.
>
> It's a dependency of u-boot.  Breaking it breaks booting on all 
> ARM
> machines.

Thanks.  Yes, unfortunately it's a dependency of a lot, making it 
a staging package.

I didn't rebuild all dependents before pushing but I did build 
several packages including u-boot-pine64-lts (on x86_64) as a 
smoke test.  I also verified that lz4 with 
--target=aarch64-linux-gnu actually builds for aarch64 now.  I 
think it's safe.

If anything were to break I'd say it must have been broken before, 
but do let me know if it happens.

> Ludo said to send extra mails for each--so that's what I am 
> doing.

Each package using CC=gcc?  There are currently hundreds; I don't 
think that's what Ludo' meant.  Do hope to have it down to tens 
soon...

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]