From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MKiHMf6wc1+/CAAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 22:11:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cLhjLf6wc18YIwAAB5/wlQ (envelope-from ) for ; Tue, 29 Sep 2020 22:11:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDB73940237 for ; Tue, 29 Sep 2020 22:11:09 +0000 (UTC) Received: from localhost ([::1]:42814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNNpz-0003Z2-QD for larch@yhetil.org; Tue, 29 Sep 2020 18:11:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNNpt-0003Yu-Vx for guix-patches@gnu.org; Tue, 29 Sep 2020 18:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNNpt-0000My-Mg for guix-patches@gnu.org; Tue, 29 Sep 2020 18:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNNpt-0001zo-IZ for guix-patches@gnu.org; Tue, 29 Sep 2020 18:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43591] [PATCH core-updates] gnu: glibc-final: Catch all cases of a glibc user not requesting 64-bit offsets and then using readdir. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Sep 2020 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43591@debbugs.gnu.org, Marius Bakke Received: via spool by 43591-submit@debbugs.gnu.org id=B43591.16014174057597 (code B ref 43591); Tue, 29 Sep 2020 22:11:01 +0000 Received: (at 43591) by debbugs.gnu.org; 29 Sep 2020 22:10:05 +0000 Received: from localhost ([127.0.0.1]:57430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNNoy-0001yS-Kt for submit@debbugs.gnu.org; Tue, 29 Sep 2020 18:10:04 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:34450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNNow-0001xw-72 for 43591@debbugs.gnu.org; Tue, 29 Sep 2020 18:10:03 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 9150F33640C3; Wed, 30 Sep 2020 00:10:00 +0200 (CEST) Date: Wed, 30 Sep 2020 00:09:34 +0200 From: Danny Milosavljevic Message-ID: <20200930000934.6812b7c8@scratchpost.org> In-Reply-To: <87h7rg4879.fsf@gnu.org> References: <20200924141211.21649-1-dannym@scratchpost.org> <87363759at.fsf@gnu.org> <20200924222711.2f22281a@scratchpost.org> <87tuvm4vop.fsf@gnu.org> <87h7rg4879.fsf@gnu.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/=5Hj0j0dlOK_SAu_+/Kcfbf"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.39 X-TUID: ijroh7qmXJmI --Sig_/=5Hj0j0dlOK_SAu_+/Kcfbf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Tue, 29 Sep 2020 22:52:10 +0200 Ludovic Court=C3=A8s wrote: > Marius Bakke skribis: >=20 > > Arguably running code for foreign architectures through QEMU binfmt is > > something of a hack. Mandating that every package *must* be patched to > > support it seems user-hostile. I'm more in favor of dropping it on the > > build farm, or just keep fixing things on a per-package basis. =20 >=20 > I=E2=80=99m fine with dropping things on the build farm; it=E2=80=99s jus= t about > modifying machines-for-berlin.scm in maintenance.git. Any takers? :-) I don't know what "dropping things on the build farm" means in this context. Dropping what exactly? > The above would override the default CFLAGS in Autoconf-generated > configure scripts (which is =E2=80=9C-O2 -g=E2=80=9D). =20 That is correct. I'm currently working on v2 (testing a patchset already) and I totally forgot to add "-g -O2" the first time around. Also, glibc itself must NOT have -D_FILE_OFFSET_BITS=3D64 (it makes sense not to, too). >So we=E2=80=99d have to be cautious. > But I think a global solution is preferable to adding > -D_FILE_OFFSET_BITS=3D64 to tens of packages. I agree. I still would like to see what actually changes--and I think with guix-data-services it should actually be possible to compare derivations before-and-after and find out which derivations of which packages changed at all because of the global -D_FILE_OFFSET_BITS=3D64. I'd like some help using guix-data-services to find that out. Otherwise a risk estimation cannot be done. Technically, if a package used direct assembly offsets (for some unfathomab= le reason), it could have an undetectable problem with the size change of off_t (and also struct dirent). So examining the source code of the most essenti= al packages manually is still good. That's what I did in branch wip-file-offsets-64. I'm in the process of testing a patchset that globally sets CFLAGS=3D"-D_FILE_OFFSET_BITS=3D64 -g -O2" instead. That alone is not enough since there are a lot of non-autotools projects th= at just ignore the environment variable entirely--not to mention languages oth= er than C. I have access to bayfront--but I don't remember how to evaluate a new branch there (the new branch is "wip-file-offset-bits-64-sledgehammer"). How does it work? --Sig_/=5Hj0j0dlOK_SAu_+/Kcfbf Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9zsJ4ACgkQ5xo1VCww uqX2cQgAmvzuWUzAWHm6T9M58P3PhM7dlK5gtkowB3hgxzYk/KkpluX56HXE2P54 q+m78K5rumyDkoVVtMtsAQbrJLnd+HuHOrlwBipcTuBsCPJ6r7Fc4BMVbvfm/kvd y7fxqsmDybtrynFpUNiQadQZNT//NaSRLqa7XKv7HWblmGYVwuQ0+fdj+IEqUv5X 3l8h/ziDg2vB10rmtmFzh9kjN/lGsYYfHlnY87iNqoYbtY4Klkg9xQiGpKULWdA4 tUATpX9JsHpAmMYN/Rja3Yk1inpMZ4aWpSdYETZGi90WvItyrp8tSlsK0uqh7/Ak 8u39izKY7Yx4fNKDJqtUiy2DHHQW9g== =F4u0 -----END PGP SIGNATURE----- --Sig_/=5Hj0j0dlOK_SAu_+/Kcfbf--