From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CM/mLRdbW18FGQAA0tVLHw (envelope-from ) for ; Fri, 11 Sep 2020 11:10:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KMkYKBdbW1/1PgAAB5/wlQ (envelope-from ) for ; Fri, 11 Sep 2020 11:10:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 62A9094051F for ; Fri, 11 Sep 2020 11:10:15 +0000 (UTC) Received: from localhost ([::1]:45698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGgwY-0006gN-Dh for larch@yhetil.org; Fri, 11 Sep 2020 07:10:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGgwP-0006eM-4x for guix-devel@gnu.org; Fri, 11 Sep 2020 07:10:05 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:47352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGgwN-0006Ou-6E; Fri, 11 Sep 2020 07:10:04 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 136F233687FB; Fri, 11 Sep 2020 13:10:01 +0200 (CEST) Date: Fri, 11 Sep 2020 13:09:59 +0200 From: Danny Milosavljevic To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: linux-module-builder leads to huge store items Message-ID: <20200911130959.479f9348@scratchpost.org> In-Reply-To: <87mu1x7g32.fsf@inria.fr> References: <874ko6jbo8.fsf@inria.fr> <20200910150453.7f968562@scratchpost.org> <87mu1x7g32.fsf@inria.fr> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/5f45O+mxe.=qWKjQ36bP1rt"; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=85.13.145.193; envelope-from=dannym@scratchpost.org; helo=dd26836.kasserver.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/11 07:07:37 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix-devel , Mathieu Othacehe Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: wfEdHczN4Xjx --Sig_/5f45O+mxe.=qWKjQ36bP1rt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Thu, 10 Sep 2020 18:26:57 +0200 Ludovic Court=C3=A8s wrote: > > 150 MB a2fs24bgghjvlzq5lzr6zki7mqxx8mpi-linux-libre-module-builder-5.8.= 7/lib/modules/build/drivers/gpu/drm/amd/include/asic_reg > > 30 MB a2fs24bgghjvlzq5lzr6zki7mqxx8mpi-linux-libre-module-builder-5.8.7= /lib/modules/build/drivers/staging > > > > I don't think we need these in any potential Linux kernel module--but w= ho > > knows? Maybe somebody does need those. =20 >=20 > So, I can think of the following ways to address that: >=20 > 1. Remove for example *.c, assuming the out-of-tree modules we package > only care about *.h + build machinery. The biggest source files, see above, are header files (drivers/gpu/drm/amd/include/asic_reg). > 2. Don=E2=80=99t add all of the Linux source to the store, or at least = not > under a new name each time. One way to do that would be to unpack > the Linux-libre tree within the build tree of the out-of-tree > module. We=E2=80=99d be reducing GC stress at the expense of a > (reasonable?) increase in module build time. And patch it correctly etc just like make-linux-libre does? That doesn't sound safe. The current setup is basically inheriting from the package make-linux-libre gave us and changing the 'build phase slightly. That means it will be exactly the same otherwise. The only way to reduce effort safely is to delete the set of source files (especially header files) which we don't need for out-of-tree modules. I checked--that would reduce the size of linux-libre-builder by about 800 MB (to 255 MB; see [1][2]). That would mean that some modules can't be out-of-tree. But I guess that's okay--and we could not-delete some files later if need be. Btw, linux-libre is currently not reproducible--see bug 43301. That could introduce a security problem if the Linux kernel and an out-of-tree module are compiled differently (they are) and then loaded into the same kernel (even now). [1] Toplevel files in linux-libre-module-builder would be then (sizes are i= ncluded if size > 1 MB): arch/ (134 MB) block/ (2 MB) certs/ COPYING CREDITS crypto/ (4 MB) include/ (59 MB) init/ ipc/ Kbuild Kconfig kernel/ (11 MB) lib/ (6 MB) LICENSES/ MAINTAINERS Makefile mm/ (5 MB) Module.symvers (2 MB) README scripts/ (6 MB) security/ (4 MB) System.map (5 MB) tools/ (14 MB) usr/ virt/ [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D43332 --Sig_/5f45O+mxe.=qWKjQ36bP1rt Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl9bWwcACgkQ5xo1VCww uqVoTwf+MxBXWx18pvtQR2SY+jlheIDzIBOWJ7Cxdil2pEAZNK0e+mgKpr3r0zJn EwJU+AYbHTf3dtVt6lHZEQN9oWIYXpCBHtic1LOw09iF1ZH2s/aTWtGgxUdCRiM1 AzYnVL/2039Pnqm6Vq10exyMKGKY+0BOszwc7wCnYaRfWO9LkxFbej8kEOktOhJs /2m8ZPl7ENXxqB8RR3isc7fW9XOID/xZVWdxfVdApNuMaMX7vnuRMztqtxr6JTmf U07LEz8SryA4ZrIwxIXFBTKvOchQ0MsMvVkPeWattz5LwJUuYWH6/S1n9Zdazt3H t1c0f4D4USo+rHSLOc5asxKXidrahg== =ymma -----END PGP SIGNATURE----- --Sig_/5f45O+mxe.=qWKjQ36bP1rt--