From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sNzLHyKdVF/EJgAA0tVLHw (envelope-from ) for ; Sun, 06 Sep 2020 08:26:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +PeeGyKdVF/dHgAAB5/wlQ (envelope-from ) for ; Sun, 06 Sep 2020 08:26:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30DFA940390 for ; Sun, 6 Sep 2020 08:26:10 +0000 (UTC) Received: from localhost ([::1]:58230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEq01-0006uP-6U for larch@yhetil.org; Sun, 06 Sep 2020 04:26:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEpzu-0006uB-8i for bug-guix@gnu.org; Sun, 06 Sep 2020 04:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33203) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEpzt-0006hk-Vw for bug-guix@gnu.org; Sun, 06 Sep 2020 04:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEpzt-0002OD-Ta for bug-guix@gnu.org; Sun, 06 Sep 2020 04:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43151: Calibre ebook-viewer requires QtWebEngine Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 06 Sep 2020 08:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43151 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Brendan Tildesley Received: via spool by 43151-submit@debbugs.gnu.org id=B43151.15993807409153 (code B ref 43151); Sun, 06 Sep 2020 08:26:01 +0000 Received: (at 43151) by debbugs.gnu.org; 6 Sep 2020 08:25:40 +0000 Received: from localhost ([127.0.0.1]:44749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEpzX-0002NZ-S8 for submit@debbugs.gnu.org; Sun, 06 Sep 2020 04:25:40 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:44948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEpzV-0002NQ-Ua for 43151@debbugs.gnu.org; Sun, 06 Sep 2020 04:25:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1EAB71CA9; Sun, 6 Sep 2020 10:25:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JICpewg6pfo3; Sun, 6 Sep 2020 10:25:35 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:910:103f::bf5]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0085F1C6B; Sun, 6 Sep 2020 10:25:34 +0200 (CEST) Date: Sun, 6 Sep 2020 10:25:19 +0200 From: Andreas Enge Message-ID: <20200906082519.GA1716@jurong> References: <20200901094817.GB4371@jurong> <20200903095847.GA3534@jurong> <8eae6c95-6f98-ffb7-45ad-72a0ca053ce6@brendan.scot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8eae6c95-6f98-ffb7-45ad-72a0ca053ce6@brendan.scot> X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.3 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43151@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: pVDLqyBp//JH (cc-ing this and only this bug, the other one seems to have diverged towards css and typescript) On Fri, Sep 04, 2020 at 07:53:02PM +1000, Brendan Tildesley wrote: > > I did not realise there was already an open ticket for updating calibre, > > thanks for pointing it out. Indeed I do not think we need to wrap all > > programs. I tried out the programs in ...calibre-4.18.0/bin, and only these > > two fail with an error message: > > ebook-edit > > ebook-viewer > > I did not try the different calibre-*; calibre itself starts. Then it can call > > ebook-viewer, and I do not know the mechanism, so it might just call the > > wrapped binary ebook-viewer, or it might need wrapping itself because of using > > internal python mechanics. I would give it a try and not wrap it in the first > > place. > > > > All "binaries" are already wrappend with PYTHONPATH, so there is probably some > > mechanic to avoid double wrapping (which your patch may already address). > Since it uses (replace 'wrap..., it won't run the old wrap phase any more. > Also I don't think it matters much that the other variables also have the Qt > variable wrapped, perhaps it is more correct anyway. Especially since the > wrap script uses '=, which wrap-program interprets as overwriting the > variable completely, so applying it twice won't make a difference anyway. Well, I think we should not wrap more than absolutely necessary. And it would even be easier to write (no need to look for all the binaries, just use these two names). Would you like to create a patch maybe for the current calibre, and handle the update following the other bug? Andreas