all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#34207: grantlee fails to build
@ 2019-01-26 10:47 Ricardo Wurmus
  2020-09-05 20:48 ` bug#34207: Closing Andreas Enge
  0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Wurmus @ 2019-01-26 10:47 UTC (permalink / raw)
  To: 34207

Grantlee has two test failures:

--8<---------------cut here---------------start------------->8---
FAIL!  : TestFilters::testDateBasedFilters(date01) Compared values are not the same
   Actual   (result): ""
   Expected (output): "01"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/tests/testfilters.cpp(117)]
FAIL!  : TestFilters::testDateBasedFilters(date02) Compared values are not the same
   Actual   (result): ""
   Expected (output): "Jan. 1, 2008"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/tests/testfilters.cpp(117)]
--8<---------------cut here---------------end--------------->8---

The tests in templates/tests/testfilters.cpp look like this:

 --8<---------------cut here---------------start------------->8---
  Dict dict;
 …
  QDateTime d(QDate(2008, 1, 1));

  dict.clear();
  dict.insert(QStringLiteral("d"), d);

  QTest::newRow("date01") << "{{ d|date:\"MM\" }}" << dict
                          << QStringLiteral("01") << NoError;
  QTest::newRow("date02") << QStringLiteral("{{ d|date }}") << dict
                          << d.toString(QStringLiteral("MMM. d, yyyy"))
                          << NoError;
--8<---------------cut here---------------end--------------->8---

The following test for “date03” passes:

--8<---------------cut here---------------start------------->8---
  dict.insert(QStringLiteral("d"), QStringLiteral("fail_string"));
  QTest::newRow("date03") << "{{ d|date:\"MM\" }}" << dict << QString()
                          << NoError;
--8<---------------cut here---------------end--------------->8---

IIUC this means: some non-date is injected and the template resulted in
the empty string.

--
Ricardo

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#34207: Closing
  2019-01-26 10:47 bug#34207: grantlee fails to build Ricardo Wurmus
@ 2020-09-05 20:48 ` Andreas Enge
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Enge @ 2020-09-05 20:48 UTC (permalink / raw)
  To: 34207-done

grantlee-5.2.0 is served as a substitute, so the problem is apparently
solved. Closing.

Andreas





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-05 20:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-26 10:47 bug#34207: grantlee fails to build Ricardo Wurmus
2020-09-05 20:48 ` bug#34207: Closing Andreas Enge

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.