From: Tim Howes via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 43093@debbugs.gnu.org
Subject: bug#43093: [PATCH] gnu: emacs-ess: Update to 20200903.1516.
Date: Fri, 4 Sep 2020 16:25:37 -0700 [thread overview]
Message-ID: <20200904232537.11128-1-timhowes@lavabit.com> (raw)
In-Reply-To: <605a30acc9c66c09938147cccfcaafc3b9f8d57e.camel@divoplade.fr>
* gnu/packages/statistics.scm (emacs-ess): Update to 20200903.1516.
[version]: Use latest commit, assign version based on commit date.
[source]: Fix snippet for removing julia-mode. Remove snippet to modify
roxy-preview-Rd-test. Add snippet to modify r-help-mode test. Add
snippet to fix install target to install files to correct directories.
[arguments]: Add flag to specify INFODIR. Remove patch modifying SHELL.
---
This updates emacs-ess to the current version on github and resolves
bugs #43093 and #42259.
gnu/packages/statistics.scm | 43 ++++++++++++++++---------------------
1 file changed, 19 insertions(+), 24 deletions(-)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index c1cefa8c41..aa14e2887f 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -5805,29 +5805,24 @@ Java package that provides routines for various statistical distributions.")
(define-public emacs-ess
(package
(name "emacs-ess")
- (version "18.10.2")
+ ;; Use version number based on commit date and time (UTC), similar to melpa.
+ (version "20200903.1516")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/emacs-ess/ESS")
- (commit (string-append "v" version))))
+ (commit "09c1adecf8406d85426d14e5efe2aaba6c59f224")))
(sha256
(base32
- "1yq41l2bicwjrc0b731iic20cpcnz6ppigri1jn621qv2qv22vy3"))
+ "0hl8nhf8w3rfpfqb2bfzcbh4lpsk51p83w2j5fc2knd4da4sb1s5"))
(file-name (git-file-name name version))
(modules '((guix build utils)))
(snippet
'(begin
;; Stop ESS from trying to bundle an external julia-mode.el.
(substitute* "lisp/Makefile"
- (("^ess-julia.elc: julia-mode.elc") "")
- (("^all: julia-mode.el")
- "all:"))
- ;; Include *.el files in install target.
- (substitute* "lisp/Makefile"
- (("\t\\$\\(INSTALL) \\$\\(ELC\\) \\$\\(LISPDIR\\)" elc)
- (string-append "\t$(INSTALL) $(ELS) ess-autoloads.el "
- "$(LISPDIR)\n" elc)))
+ ((" \\$\\(JULIAS)") "")
+ (("\ttest.*julia-mode.*\\.el") ""))
;; Only build docs in info format.
(substitute* "doc/Makefile"
(("all : info text")
@@ -5836,12 +5831,16 @@ Java package that provides routines for various statistical distributions.")
"install: install-info"))
;; Stop install-info from trying to update the info directory.
(substitute* "doc/Makefile"
- ((".*\\$\\(INFODIR\\)/dir.*") ""))
- ;; Fix roxygen preview test.
- (substitute* "test/ess-r-tests.el"
- (("Add together two numbers.\n")
- "Add together two numbers. ")
- (("##' add\\(10, 1\\)") "add(10, 1)"))
+ ((".*/dir.*") ""))
+ ;; Fix r-help-mode test.
+ (substitute* "test/ess-test-r.el"
+ (("\\(equal ess-help-object \"plot.default\")") "t"))
+ ;; Install to correct directories.
+ (substitute* "Makefile"
+ (("mkdir -p \\$\\(ESSDESTDIR)")
+ "$(MAKE) -C lisp install; $(MAKE) -C doc install")
+ (("\\$\\(INSTALL) -R \\./\\* \\$\\(ESSDESTDIR)/")
+ "$(MAKE) -C etc install"))
#t))))
(build-system gnu-build-system)
(arguments
@@ -5850,16 +5849,12 @@ Java package that provides routines for various statistical distributions.")
(string-append "ETCDIR=" %output
,base-directory "/etc")
(string-append "LISPDIR=" %output
- ,base-directory))
+ ,base-directory)
+ (string-append "INFODIR=" %output
+ "/share/info"))
#:phases
(modify-phases %standard-phases
(delete 'configure)
- (add-before 'build 'more-shebang-patching
- (lambda* (#:key inputs #:allow-other-keys)
- (substitute* "Makeconf"
- (("SHELL = /bin/sh")
- (string-append "SHELL = " (which "sh"))))
- #t))
(replace 'check
(lambda _
(invoke "make" "test")))))))
--
2.28.0
next prev parent reply other threads:[~2020-09-04 23:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 20:07 bug#43093: emacs-ess is broken by emacs 27.1 divoplade
2020-09-04 14:44 ` bug#43093: Is Emacs 27.1 that breaks emacs-ess? zimoun
2020-09-04 15:26 ` divoplade
2020-09-04 17:00 ` Mark H Weaver
2020-09-04 18:09 ` zimoun
2020-09-04 18:25 ` bug#43093: emacs-ess is broken by emacs 27.1 Tim Howes via Bug reports for GNU Guix
2020-09-07 21:19 ` divoplade
2020-09-07 21:43 ` divoplade
2020-09-07 21:52 ` divoplade
2020-09-08 19:24 ` Tim Howes via Bug reports for GNU Guix
2020-09-04 23:25 ` Tim Howes via Bug reports for GNU Guix [this message]
2020-09-28 3:28 ` bug#43093: [PATCH] gnu: emacs-ess: Update to 20200903.1516 Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904232537.11128-1-timhowes@lavabit.com \
--to=bug-guix@gnu.org \
--cc=43093@debbugs.gnu.org \
--cc=timhowes@lavabit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.