all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#43060] usage text for git-lfs
@ 2020-08-26 14:41 Prafulla Giri
  2020-08-27 21:50 ` bug#43060: " Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Prafulla Giri @ 2020-08-26 14:41 UTC (permalink / raw)
  To: 43060


[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

Esteemed maintainers,

This is a follow-up to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43044

Despite making the man pages available, the usage text (--help) was still
not available. While `git lfs --help` did bring up the man page, `git-lfs
--help` threw 'Sorry, no usage text found for "git-lfs"'.

The attached patch fixes that. And any calls to invalid lfs commands, or
just `git-lfs` (without any sub-commands).

Thank you.

[-- Attachment #1.2: Type: text/html, Size: 716 bytes --]

[-- Attachment #2: 0001-gnu-git-lfs-Make-usage-text-available.patch --]
[-- Type: text/x-patch, Size: 1258 bytes --]

From 933ae9f1eab0eb74f59f379877d9b442b6ec96f2 Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Wed, 26 Aug 2020 20:16:54 +0545
Subject: [PATCH] gnu: git-lfs: Make usage text available.

* gnu/packages/version-control.scm (git-lfs)[arguments]: Add phase
'man-gen to make usage text available for embedding for the 'build
phase.
---
 gnu/packages/version-control.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 3b23e8b873..bc8e5f21ab 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2591,6 +2591,12 @@ interrupted, published, and collaborated on while in progress.")
        #:install-source? #f
        #:phases
        (modify-phases %standard-phases
+         (add-before 'build 'man-gen
+           ;; Without this, the binary generated in 'build
+           ;; phase won't have any embedded usage-text.
+           (lambda _
+             (with-directory-excursion "src/github.com/git-lfs/git-lfs"
+               (invoke "make" "mangen"))))
          (add-after 'build 'build-man-pages
            (lambda _
              (with-directory-excursion "src/github.com/git-lfs/git-lfs"
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#43060: usage text for git-lfs
  2020-08-26 14:41 [bug#43060] usage text for git-lfs Prafulla Giri
@ 2020-08-27 21:50 ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2020-08-27 21:50 UTC (permalink / raw)
  To: Prafulla Giri; +Cc: 43060-done

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

Looks good. Patch pushed!


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-27 21:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 14:41 [bug#43060] usage text for git-lfs Prafulla Giri
2020-08-27 21:50 ` bug#43060: " Efraim Flashner

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.