From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OBDqJ/OnPV9yNwAA0tVLHw (envelope-from ) for ; Wed, 19 Aug 2020 22:30:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eK/DI/OnPV+yUQAAB5/wlQ (envelope-from ) for ; Wed, 19 Aug 2020 22:30:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 220FE9401CF for ; Wed, 19 Aug 2020 22:30:10 +0000 (UTC) Received: from localhost ([::1]:43800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8Wav-00069P-2M for larch@yhetil.org; Wed, 19 Aug 2020 18:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8Wao-00069E-Tq for guix-patches@gnu.org; Wed, 19 Aug 2020 18:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8Wao-00078h-Jh for guix-patches@gnu.org; Wed, 19 Aug 2020 18:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8Wao-0000xG-FZ for guix-patches@gnu.org; Wed, 19 Aug 2020 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits. Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Aug 2020 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42868 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 42868@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15978761763615 (code B ref -1); Wed, 19 Aug 2020 22:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Aug 2020 22:29:36 +0000 Received: from localhost ([127.0.0.1]:41200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8WaN-0000wF-Ro for submit@debbugs.gnu.org; Wed, 19 Aug 2020 18:29:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:51698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8WaM-0000w7-2n for submit@debbugs.gnu.org; Wed, 19 Aug 2020 18:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8WaL-00068F-Sa for guix-patches@gnu.org; Wed, 19 Aug 2020 18:29:33 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:41060) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8WaJ-00075u-PI for guix-patches@gnu.org; Wed, 19 Aug 2020 18:29:33 -0400 Received: (qmail 25192 invoked by uid 1009); 20 Aug 2020 00:29:29 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25904. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.053104 secs); 19 Aug 2020 22:29:29 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 20 Aug 2020 00:29:29 +0200 Date: Thu, 20 Aug 2020 00:29:27 +0200 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200819222927.l5hcfqrjvenpufhy@gravity> References: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tgw6jhfbpuz27joj" Content-Disposition: inline In-Reply-To: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name> Received-SPF: none client-ip=37.59.186.212; envelope-from=kuba@kadziolka.net; helo=pat.zlotemysli.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/19 17:38:45 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.61 X-TUID: C83x15MqEjto --tgw6jhfbpuz27joj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 14, 2020 at 04:30:47PM -0400, Leo Famulari wrote: > +z40=3D0000000000000000000000000000000000000000 > + > +# If deleting a branch, there are no commits to check. > +if [ "$local_sha" =3D $z40 ] > +then > + true > +else Is there a reason this `if' is written like that? I would use !=3D and get rid of the do-nothing branch entirely. Regards, Jakub K=C4=85dzio=C5=82ka --tgw6jhfbpuz27joj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl89p8cACgkQ4xWnWEYT FWTAhhAAsEnqBYe0l51UZmujyo1JyAKwVkBA+t6Soh/FOeFnm138vGADoEKKPKmY r9jyiIcIcFSK9Bb/sFc3JpMEqgshURnpgXVMybCWavoH1CmoDttNtAniEmoP0SDS fK9xMiDC0RTgqpNHMNRx+H+jWBMT75dbtu+Bb1drOcIwySbOAwbQeZ0LH1rm2/pA 7hbxMGaNYvbwMuh9EjeqmmqyiMYUQuccY9b0TJ0bfdNUzHynvrFm/cG8+Bpfiy64 qQtoMb7cY8/pzRrwQoiZoqK9WKShs2BXHb8E78STVHrQvUOSmAMrjHnIxtsODINo eYVC34BTItbNpTGECq9HTv0P3GLzAky5uDa8fiUuqAi8yH8R+uEZoA+2i8rTjVuP DUZaf7DHXdrNUIJVarx3aOp4Um120uFlvV1gLSECVEmXTNrqafiXFASMJNN6H/kh PfgogJylZggBOBGQ+dmpKIoaFXsyaHExOiqnd38uS+3vEXzM0Vjn1kCOXH5bKSYl tyr8zOvCEyoBfb7HMYplxY4Nlt6iqWwNLkJj6QtzR5/bw7XTDHvU/Nmjo1XjyZKC nYIMv82KPnHUyYU2qBnj21JSMakgv7MzvNRH7gRz4zaFM1cHQurrFFSNu6tL/hRY NdybCnCaew+Vj42v4gxYWVFBwHUCJ155k9/OKSMFps4LMFeGGpw= =SGHl -----END PGP SIGNATURE----- --tgw6jhfbpuz27joj--