From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Leo Famulari <leo@famulari.name>
Cc: 42868@debbugs.gnu.org
Subject: [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits.
Date: Thu, 20 Aug 2020 00:29:27 +0200 [thread overview]
Message-ID: <20200819222927.l5hcfqrjvenpufhy@gravity> (raw)
In-Reply-To: <12ad49f9266b146b81f7c7347ec4d62d18602039.1597437024.git.leo@famulari.name>
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Fri, Aug 14, 2020 at 04:30:47PM -0400, Leo Famulari wrote:
> +z40=0000000000000000000000000000000000000000
> +
> +# If deleting a branch, there are no commits to check.
> +if [ "$local_sha" = $z40 ]
> +then
> + true
> +else
Is there a reason this `if' is written like that? I would use != and get
rid of the do-nothing branch entirely.
Regards,
Jakub Kądziołka
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-19 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 20:30 [bug#42868] [PATCH] maint: Only run `make authenticate` when pushing commits Leo Famulari
2020-08-19 22:29 ` Jakub Kądziołka [this message]
2020-08-30 19:47 ` Ludovic Courtès
2020-12-13 20:35 ` Leo Famulari
2020-12-14 8:28 ` Ludovic Courtès
2020-12-14 17:17 ` bug#42868: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819222927.l5hcfqrjvenpufhy@gravity \
--to=kuba@kadziolka.net \
--cc=42868@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.